On Mon, 2014-03-24 at 10:49 -0400, Russell Bryant wrote:
Gerrit support for a patch series could certainly be better.
There has long been talking about gerrit getting topic review
functionality, whereby you could e.g. approve a whole series of patches
from a topic view.
See:
On Mon, Mar 24 2014, John Dennis wrote:
But from that point forward it appears as if each commit is handled
independently rather than being an ordered list of commits that are
grouped together sharing a single review where their relationship is
explicit. Also the jenkins tests either needs to
On 03/24/2014 10:31 AM, John Dennis wrote:
When a change is complex good practice is to break the change into a
series of smaller individual patches that show the individual
incremental steps needed to get to the final goal. When partitioned into
small steps each change is easier to review and
On Mon, Mar 24, 2014 at 8:31 AM, John Dennis jden...@redhat.com wrote:
When a change is complex good practice is to break the change into a
series of smaller individual patches that show the individual
incremental steps needed to get to the final goal. When partitioned into
small steps each
On 03/24/2014 11:08 AM, John Griffith wrote:
On Mon, Mar 24, 2014 at 8:31 AM, John Dennis jden...@redhat.com
mailto:jden...@redhat.com wrote:
When a change is complex good practice is to break the change into a
series of smaller individual patches that show the individual
On 2014-03-24 09:31, John Dennis wrote:
When a change is complex good practice is to break the change into a
series of smaller individual patches that show the individual
incremental steps needed to get to the final goal. When partitioned into
small steps each change is easier to review and
+1 to all Ben said.
There are reasons to split things up in to a logical progression of
changes but each change must stand alone and must pass tests.
Carl
On Mon, Mar 24, 2014 at 10:03 AM, Ben Nemec openst...@nemebean.com wrote:
I should point out that Jenkins can't apply the next patch in
