Overall, this looks good.
Your alternate implementation misses LVM support, and leaves an unused file
behind in the instance directory. Other than that, it's acceptable for a
late-stage change, IMO.
Best Regards,
Solly
- Original Message -
From: Michael Still mi...@stillhq.com
To:
I think we should leave LVM out for now -- I am not sure it makes
sense to put a tens of megabyte file into its own LV. I'll fix the
cleanup thing today.
Michael
On Tue, Sep 23, 2014 at 5:21 AM, Solly Ross sr...@redhat.com wrote:
Overall, this looks good.
Your alternate implementation misses
