Re: [OpenStack-Infra] [openstack-infra][puppet-pip]

2015-08-12 Thread Ricardo Carrillo Cruz
Interesting, I was not aware of puppetlabs-inifile. Anyway, I think Jeremy mentioned to me that the creation of puppet-pip class was to manage the python3-python2 differences for pip paths (Jeremy can you chime in?) The manage pip.conf functionality was added afterwards (I think it was Yolanda

Re: [OpenStack-Infra] Puppet lint checks for system-config

2015-08-12 Thread Yolanda Robla Mota
Hi So my point here, is that i don't want to do a discrimination between rules on puppet modules and system-config. If we enforce lint rules, we should do it everywhere. For lint in system-config, once concern was that it affects history. But as long as we are moving more functionality to

Re: [OpenStack-Infra] Puppet lint checks for system-config

2015-08-12 Thread Ricardo Carrillo Cruz
Having lint checks as non-voting seems like a good compromise to me here. 2015-08-12 17:09 GMT+02:00 Yolanda Robla Mota yolanda.robla-m...@hp.com: Hi So my point here, is that i don't want to do a discrimination between rules on puppet modules and system-config. If we enforce lint rules, we

[OpenStack-Infra] Puppet lint checks for system-config

2015-08-12 Thread Paul Belanger
Greetings, This email comes from some personal frustrations regarding our code review policy for system-config. Specifically, lint or style checks for puppet code. Back in Nov. 30 2012 (yes I checked) I enabled voting for gate-ci-puppet-lint[1]. It was one of my first efforts for infra :) Since

[OpenStack-Infra] IBM XIV CI account

2015-08-12 Thread Isaac Beckman
Dear Infra team, A new CI account was created for IBM XIV as we could not edit the ssh public key that was assigned to the original account. We did this after we saw the following thread The new account is: Account full name: IBM XIV CI Account email: ibmxi...@il.ibm.com The old account was

Re: [OpenStack-Infra] [openstack-infra][puppet-pip]

2015-08-12 Thread Jeremy Stanley
On 2015-08-12 17:10:49 +0200 (+0200), Ricardo Carrillo Cruz wrote: [...] Anyway, I think Jeremy mentioned to me that the creation of puppet-pip class was to manage the python3-python2 differences for pip paths (Jeremy can you chime in?) Looking back at the history[1] the _original_ intent was

Re: [OpenStack-Infra] Puppet lint checks for system-config

2015-08-12 Thread Paul Belanger
On Wed, Aug 12, 2015 at 09:00:10AM -0700, James E. Blair wrote: Paul Belanger pabelan...@redhat.com writes: ... However, recently. I got my hand smacked in 2 different code reviews for arrow alignment issues. Honestly, I wasn't even mad about the -1 for the alignment. However, I'm

Re: [OpenStack-Infra] Puppet lint checks for system-config

2015-08-12 Thread James E. Blair
Paul Belanger pabelan...@redhat.com writes: ... However, recently. I got my hand smacked in 2 different code reviews for arrow alignment issues. Honestly, I wasn't even mad about the -1 for the alignment. However, I'm concerned about the wasted effort the -1 caused me. Basically, I had to