Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-21 Thread Jesse Keating
On Wed, May 24, 2017 at 4:04 PM, James E. Blair wrote: > Depends-On: https://github.com/ansible/ansible/pull/12345 > I've implemented this for the github driver. I have not changed the gerrit driver, that's still a thing to be done. https://review.openstack.org/474401

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-06 Thread Clint Byrum
Excerpts from Jamie Lennox's message of 2017-06-07 11:04:53 +1000: > On 25 May 2017 at 09:04, James E. Blair wrote: > > > Hi, > > > > As part of Zuul v3, we're adding support for GitHub (and later possibly > > other systems). We want these systems to have access to the full

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-06 Thread Jamie Lennox
On 25 May 2017 at 09:04, James E. Blair wrote: > Hi, > > As part of Zuul v3, we're adding support for GitHub (and later possibly > other systems). We want these systems to have access to the full power > of cross-project-dependencies in the same way as Gerrit. However, the

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-03 Thread Clint Byrum
Excerpts from Joshua Hesketh's message of 2017-06-02 13:45:00 +1000: > On Fri, Jun 2, 2017 at 3:30 AM, Paul Belanger wrote: > > > On Wed, May 24, 2017 at 04:04:20PM -0700, James E. Blair wrote: > > > Hi, > > > > > > As part of Zuul v3, we're adding support for GitHub (and

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-01 Thread Joshua Hesketh
On Fri, Jun 2, 2017 at 3:30 AM, Paul Belanger wrote: > On Wed, May 24, 2017 at 04:04:20PM -0700, James E. Blair wrote: > > Hi, > > > > As part of Zuul v3, we're adding support for GitHub (and later possibly > > other systems). We want these systems to have access to the

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-06-01 Thread Paul Belanger
On Wed, May 24, 2017 at 04:04:20PM -0700, James E. Blair wrote: > Hi, > > As part of Zuul v3, we're adding support for GitHub (and later possibly > other systems). We want these systems to have access to the full power > of cross-project-dependencies in the same way as Gerrit. However, the >

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-29 Thread Joshua Hesketh
On Tue, May 30, 2017 at 4:55 AM, Jeremy Stanley wrote: > On 2017-05-29 13:34:47 +1000 (+1000), Joshua Hesketh wrote: > [...] > > We could extend the 'start message' of zuul to explain what it is > > about to do. eg: "Testing change XYZ against $branch, with change > > XYZ

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-29 Thread Jeremy Stanley
On 2017-05-29 13:34:47 +1000 (+1000), Joshua Hesketh wrote: [...] > We could extend the 'start message' of zuul to explain what it is > about to do. eg: "Testing change XYZ against $branch, with change > XYZ applied to $project $branch, with..." etc. This would be hard (I think for definitions of

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-28 Thread Joshua Hesketh
On Sat, May 27, 2017 at 12:53 AM, James E. Blair wrote: > Joshua Hesketh writes: > > > On Fri, May 26, 2017 at 1:09 AM, James E. Blair > wrote: > >> So I think that we should start out by simply silently ignoring any > >>

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-26 Thread James E. Blair
Joshua Hesketh writes: > On Fri, May 26, 2017 at 1:09 AM, James E. Blair wrote: >> So I think that we should start out by simply silently ignoring any >> patchset elements in the URL. We could consider having Zuul leave a >> note indicating that

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread Joshua Hesketh
On Fri, May 26, 2017 at 1:09 AM, James E. Blair wrote: > Sean Dague writes: > > > On 05/24/2017 07:04 PM, James E. Blair wrote: > > > >> The natural way to identify a GitHub pull request is with its URL. > >> > >> This can be used to identify Gerrit changes

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread Jesse Keating
On Wed, May 24, 2017 at 4:04 PM, James E. Blair wrote: > Hi, > > As part of Zuul v3, we're adding support for GitHub (and later possibly > other systems). We want these systems to have access to the full power > of cross-project-dependencies in the same way as Gerrit.

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread Jeremy Stanley
On 2017-05-25 08:10:33 -0700 (-0700), James E. Blair wrote: > Jeremy Stanley writes: [...] > > Alternative/complimentary idea, Gerrit hooks can also be used to > > reject uploads, so when the time comes to stop supporting the old > > syntax we can also see about rejecting new

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread James E. Blair
Jeremy Stanley writes: > On 2017-05-25 08:50:14 -0500 (-0500), Kevin L. Mitchell wrote: >> Can I suggest that, for OpenStack purposes, we also deploy some sort of >> bot that comments on reviews using the old syntax, to at least alert >> developers to the pending deprecation?

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread James E. Blair
Sean Dague writes: > On 05/24/2017 07:04 PM, James E. Blair wrote: > >> The natural way to identify a GitHub pull request is with its URL. >> >> This can be used to identify Gerrit changes as well, and will likely be >> well supported by other systems. Therefore, I propose we

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-25 Thread Kevin L. Mitchell
On Wed, 2017-05-24 at 16:04 -0700, James E. Blair wrote: > I propose we adopt support for URLs in all source drivers in v3, and > declare Gerrit change IDs deprecated.  We will continue to support both > for a generous deprecation period (at least 6 months after the initial > Zuul 3.0 release),

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-24 Thread Jeremy Stanley
On 2017-05-25 00:33:10 + (+), Tristan Cacqueray wrote: > On May 24, 2017 11:04 pm, James E. Blair wrote: > [...] > >How does that sound? > > Thinking about further connections support, could this also works > for a (theorical) mail based patch cross dependency? I can imagine wanting

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-24 Thread Tristan Cacqueray
On May 24, 2017 11:04 pm, James E. Blair wrote: [...] How does that sound? Thinking about further connections support, could this also works for a (theorical) mail based patch cross dependency? What's the logic to match the Depends-On syntax to a connection driver? -Tristan

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-24 Thread Jeremy Stanley
On 2017-05-24 16:04:20 -0700 (-0700), James E. Blair wrote: [...] > How does that sound? I ain't afraid of no ghosts. Let's do it! -- Jeremy Stanley signature.asc Description: Digital signature ___ OpenStack-Infra mailing list

Re: [OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-24 Thread Morgan Fainberg
From someone who has used/consumed/worked with/contributed to Zuul, this seems very straight forward and reasonable. The only concern is ensuring that the metadata on "if this has in-fact merged" is clearly available in the URL. I want to ensure we're implementing something generally useful and if

[OpenStack-Infra] Zuul v3: proposed new Depends-On syntax

2017-05-24 Thread James E. Blair
Hi, As part of Zuul v3, we're adding support for GitHub (and later possibly other systems). We want these systems to have access to the full power of cross-project-dependencies in the same way as Gerrit. However, the current syntax for the Depends-On footer is currently the Gerrit-specific