Hello community, here is the log from the commit of package rrdtool for openSUSE:11.4 checked in at Tue May 17 00:24:18 CEST 2011.
-------- --- old-versions/11.4/all/rrdtool/rrdtool.changes 2010-12-28 03:59:32.000000000 +0100 +++ 11.4/rrdtool/rrdtool.changes 2011-05-12 13:12:54.000000000 +0200 @@ -1,0 +2,10 @@ +Thu May 12 10:33:46 UTC 2011 - m...@novell.com + +- Fix two segfaults in the Tcl binding. + +------------------------------------------------------------------- +Wed May 11 11:57:13 UTC 2011 - m...@novell.com + +- Fix a version dependency problem with Tcl (bnc#693085). + +------------------------------------------------------------------- Package does not exist at destination yet. Using Fallback old-versions/11.4/all/rrdtool Destination is old-versions/11.4/UPDATES/all/rrdtool calling whatdependson for 11.4-i586 New: ---- rrdtool-tclsegfault.patch rrdtool-tclversion.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rrdtool.spec ++++++ --- /var/tmp/diff_new_pack.0f5FuB/_old 2011-05-17 00:23:09.000000000 +0200 +++ /var/tmp/diff_new_pack.0f5FuB/_new 2011-05-17 00:23:09.000000000 +0200 @@ -1,5 +1,5 @@ # -# spec file for package rrdtool (Version 1.4.5) +# spec file for package rrdtool # # Copyright (c) 2011 SUSE LINUX Products GmbH, Nuernberg, Germany. # @@ -35,11 +35,13 @@ Group: Productivity/Scientific/Math Requires: perl = %{perl_version} Version: 1.4.5 -Release: 1 +Release: 4.<RELEASE5> %define cgilib_version 0.7 # http://oss.oetiker.ch/rrdtool/pub/rrdtool-%{version}.tar.gz Source: %{name}-%{version}.tar.bz2 Patch1: rrdtool-lua_lib64.patch +Patch2: rrdtool-tclversion.patch +Patch3: rrdtool-tclsegfault.patch # http://www.infodrom.org/projects/cgilib/download/cgilib-%{cgilib_version}.tar.gz Source1: cgilib-%{cgilib_version}.tar.bz2 Patch11: cgilib-fix_automake.patch @@ -59,6 +61,8 @@ %if %{_lib}==lib64 %patch1 %endif +%patch2 +%patch3 pushd "cgilib-%{cgilib_version}" %patch11 popd #cgilib ++++++ rrdtool-tclsegfault.patch ++++++ --- bindings/tcl/tclrrd.c +++ bindings/tcl/tclrrd.c @@ -472,6 +472,12 @@ static int Rrd_Graph( char **argv2; CONST84 char *save; + if (argc < 2) { + Tcl_AppendResult(interp, "RRD Error: needs image filename", + (char *) NULL); + return TCL_ERROR; + } + /* * If the "filename" is a Tcl fileID, then arrange for rrd_graph() to write to * that file descriptor. Will this work with windoze? I have no idea. @@ -597,6 +603,12 @@ static int Rrd_Resize( { char **argv2; + if (argc < 2) { + Tcl_AppendResult(interp, "RRD Error: needs rrd filename", + (char *) NULL); + return TCL_ERROR; + } + argv2 = getopt_init(argc, argv); rrd_resize(argc, argv2); getopt_cleanup(argc, argv2); ++++++ rrdtool-tclversion.patch ++++++ Index: bindings/tcl/tclrrd.c =================================================================== --- bindings/tcl/tclrrd.c.orig +++ bindings/tcl/tclrrd.c @@ -678,10 +678,6 @@ static int init( if (Tcl_InitStubs(interp, TCL_VERSION, 0) == NULL) return TCL_ERROR; - if (Tcl_PkgRequire(interp, "Tcl", TCL_VERSION, 1) == NULL) { - return TCL_ERROR; - } - /* * Why a global array? In keeping with the Rrd:: namespace, why * not simply create a normal variable Rrd::version and set it? ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun... -- To unsubscribe, e-mail: opensuse-commit+unsubscr...@opensuse.org For additional commands, e-mail: opensuse-commit+h...@opensuse.org