commit python-rtslib-fb for openSUSE:Factory

2020-10-22 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2020-10-22 14:20:25

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3463 (New)


Package is "python-rtslib-fb"

Thu Oct 22 14:20:25 2020 rev:26 rq:842426 version:2.1.74

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2020-09-01 20:06:42.876574070 +0200
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3463/python-rtslib-fb.changes  
2020-10-22 14:20:53.622675445 +0200
@@ -1,0 +2,17 @@
+Fri Oct 16 18:47:04 UTC 2020 - ldun...@suse.com
+
+- Update to version v2.1.74:
+  * version 2.1.74
+  * rtslib: safely call shutil.copy()
+  * Fix fail when target_core_mod doesn't exists
+  * Fix EPERM errors with scsi_generic devices
+  Also, add this commit submitted upstream:
+  * rtslib-Fix-handling-of-sysfs-RW-attrs-that-are-actually-RO.patch
+  And this commit for SUSE:
+  * rtslib-target-service-for-suse.patch
+  Lastly, this package now installs systemd unit file target.service,
+  which will replace eventually targetcli.service (from the
+  targetcli-fb package), since this matches how upstream works.
+  This also meant updating the SPEC file.
+
+---

Old:

  python-rtslib-fb-v2.1.73.tar.xz

New:

  python-rtslib-fb-v2.1.74.tar.xz
  rtslib-Fix-handling-of-sysfs-RW-attrs-that-are-actually-RO.patch
  rtslib-target-service-for-suse.patch



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.OI9JqX/_old  2020-10-22 14:20:57.326678768 +0200
+++ /var/tmp/diff_new_pack.OI9JqX/_new  2020-10-22 14:20:57.330678772 +0200
@@ -19,7 +19,7 @@
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-rtslib-fb
-Version:2.1.73
+Version:2.1.74
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
@@ -27,6 +27,8 @@
 URL:https://github.com/open-iscsi/rtslib-fb.git
 Source: %{name}-v%{version}.tar.xz
 Patch1: rbd-support.patch
+Patch2: 
rtslib-Fix-handling-of-sysfs-RW-attrs-that-are-actually-RO.patch
+Patch3: rtslib-target-service-for-suse.patch
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module six}
@@ -56,6 +58,8 @@
 # RBD support is dependent on LIO changes present in the SLE/Leap kernel
 %patch1 -p1
 %endif
+%patch2 -p1
+%patch3 -p1
 
 %build
 %python_build
@@ -73,12 +77,25 @@
 install -d -m755 %{buildroot}/%{dbdir}
 install -d -m755 %{buildroot}/%{dbdir}/pr
 install -d -m755 %{buildroot}/%{dbdir}/alua
+mkdir -p %{buildroot}/%{_unitdir}/
+install -m644 systemd/target.service %{buildroot}/%{_unitdir}
+install -d -m755 %{buildroot}%{_sbindir}
+ln -s %{_sbindir}/service %{buildroot}/%{_sbindir}/rctarget
 
 %post
 %python_install_alternative targetctl targetctl.8 saveconfig.json.5
+%{service_add_post target.service}
 
 %postun
 %python_uninstall_alternative targetctl
+%{service_del_postun target.service}
+
+%pre
+%{service_add_pre target.service}
+
+%preun
+%{stop_on_removal target}
+%{service_del_preun target.service}
 
 %files %{python_files}
 %python_alternative %{_bindir}/targetctl
@@ -90,5 +107,7 @@
 %dir %{dbdir}
 %dir %{dbdir}/pr
 %dir %{dbdir}/alua
+%{_unitdir}/target.service
+%{_sbindir}/rctarget
 
 %changelog

++ _service ++
--- /var/tmp/diff_new_pack.OI9JqX/_old  2020-10-22 14:20:57.362678800 +0200
+++ /var/tmp/diff_new_pack.OI9JqX/_new  2020-10-22 14:20:57.362678800 +0200
@@ -7,7 +7,7 @@
 @PARENT_TAG@
 v(\d*\.\d*\.)fb(\d*)
 \1\2
-v2.1.73
+v2.1.74
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.OI9JqX/_old  2020-10-22 14:20:57.382678819 +0200
+++ /var/tmp/diff_new_pack.OI9JqX/_new  2020-10-22 14:20:57.382678819 +0200
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  4766d9d07338778a599d7d7e2b5012ac5b03bc16
\ No newline at end of file
+  33b174f313ba4f8aec2e2a159ff337ae7ca42cb8
\ No newline at end of file

++ python-rtslib-fb-v2.1.73.tar.xz -> python-rtslib-fb-v2.1.74.tar.xz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.73/rtslib/__init__.py 
new/python-rtslib-fb-v2.1.74/rtslib/__init__.py
--- old/python-rtslib-fb-v2.1.73/rtslib/__init__.py 2020-06-24 
10:16:57.0 +0200
+++ new/python-rtslib-fb-v2.1.74/rtslib/__init__.py 2020-08-24 
10:05:02.0 +0200
@@ -36,7 +36,7 @@
 
 from .alua import 

commit python-rtslib-fb for openSUSE:Factory

2020-09-01 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2020-09-01 20:05:44

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3399 (New)


Package is "python-rtslib-fb"

Tue Sep  1 20:05:44 2020 rev:25 rq:829899 version:2.1.73

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2020-07-02 23:54:29.564505786 +0200
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3399/python-rtslib-fb.changes  
2020-09-01 20:06:42.876574070 +0200
@@ -1,0 +2,7 @@
+Thu Aug 27 02:10:59 UTC 2020 - Matthew Oliver 
+
+- Updated the rbd-support.patch (bsc#1175808):
+  * Fixed the signiture of the RBDStorageObject to match changes made
+to parent StorageObject class.
+
+---



Other differences:
--
++ rbd-support.patch ++
--- /var/tmp/diff_new_pack.69fsex/_old  2020-09-01 20:06:45.080575101 +0200
+++ /var/tmp/diff_new_pack.69fsex/_new  2020-09-01 20:06:45.084575103 +0200
@@ -36,7 +36,7 @@
 +# RBDStorageObject private stuff
 +
 +def __init__(self, name, dev=None, wwn=None, readonly=False,
-+ write_back=False):
++ write_back=False, index=None):
 +'''
 +A RBDIOStorageObject can be instantiated in two ways:
 +- B{Creation mode}: If I{dev} is specified, the underlying 
configFS
@@ -62,14 +62,14 @@
 +'''
 +
 +if dev is not None:
-+super(RBDStorageObject, self).__init__(name, 'create')
++super(RBDStorageObject, self).__init__(name, 'create', index)
 +try:
 +self._configure(dev, wwn, readonly)
 +except:
 +self.delete()
 +raise
 +else:
-+super(RBDStorageObject, self).__init__(name, 'lookup')
++super(RBDStorageObject, self).__init__(name, 'lookup', index)
 +
 +def _configure(self, dev, wwn, readonly):
 +self._check_self()




commit python-rtslib-fb for openSUSE:Factory

2020-07-02 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2020-07-02 23:54:09

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3060 (New)


Package is "python-rtslib-fb"

Thu Jul  2 23:54:09 2020 rev:24 rq:817942 version:2.1.73

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2020-03-05 23:21:54.845298769 +0100
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.3060/python-rtslib-fb.changes  
2020-07-02 23:54:29.564505786 +0200
@@ -1,0 +2,15 @@
+Tue Jun 30 17:49:04 UTC 2020 - ldun...@suse.com
+
+- Update to version v2.1.73 (bsc#1173257 CVE-2020-14019):
+  * version 2.1.73
+  * save_to_file: fix fd open mode
+  * saveconfig: copy temp configfile with permissions
+  * saveconfig: open the temp configfile with modes set
+  * Fix "is not" with a literal SyntaxWarning
+  * Fix an incorrect config path in two comments
+  * version 2.1.72
+  * Do not change dbroot after drivers have been registered
+  * Remove '_if_needed' from RTSRoot._set_dbroot()'s name
+  Replacing old tarball with python-rtslib-fb-v2.1.73.tar.xz
+
+---

Old:

  python-rtslib-fb-v2.1.71.tar.xz

New:

  python-rtslib-fb-v2.1.73.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.cDHhUY/_old  2020-07-02 23:54:31.716512920 +0200
+++ /var/tmp/diff_new_pack.cDHhUY/_new  2020-07-02 23:54:31.720512933 +0200
@@ -19,7 +19,7 @@
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-rtslib-fb
-Version:2.1.71
+Version:2.1.73
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0

++ _service ++
--- /var/tmp/diff_new_pack.cDHhUY/_old  2020-07-02 23:54:31.788513158 +0200
+++ /var/tmp/diff_new_pack.cDHhUY/_new  2020-07-02 23:54:31.792513172 +0200
@@ -7,7 +7,7 @@
 @PARENT_TAG@
 v(\d*\.\d*\.)fb(\d*)
 \1\2
-v2.1.71
+v2.1.73
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.cDHhUY/_old  2020-07-02 23:54:31.816513251 +0200
+++ /var/tmp/diff_new_pack.cDHhUY/_new  2020-07-02 23:54:31.816513251 +0200
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  b37bc67fc7ed3d1ec447e9f43eb68d30dd716367
\ No newline at end of file
+  4766d9d07338778a599d7d7e2b5012ac5b03bc16
\ No newline at end of file

++ python-rtslib-fb-v2.1.71.tar.xz -> python-rtslib-fb-v2.1.73.tar.xz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.71/rtslib/__init__.py 
new/python-rtslib-fb-v2.1.73/rtslib/__init__.py
--- old/python-rtslib-fb-v2.1.71/rtslib/__init__.py 2019-11-06 
13:35:08.0 +0100
+++ new/python-rtslib-fb-v2.1.73/rtslib/__init__.py 2020-06-24 
10:16:57.0 +0200
@@ -36,7 +36,7 @@
 
 from .alua import ALUATargetPortGroup
 
-__version__ = '2.1.71'
+__version__ = '2.1.73'
 __author__ = "Jerome Martin "
 __url__ = 'http://github.com/open-iscsi/rtslib-fb'
 __description__ = 'API for Linux kernel SCSI target (aka LIO)'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.71/rtslib/fabric.py 
new/python-rtslib-fb-v2.1.73/rtslib/fabric.py
--- old/python-rtslib-fb-v2.1.71/rtslib/fabric.py   2019-11-06 
13:35:08.0 +0100
+++ new/python-rtslib-fb-v2.1.73/rtslib/fabric.py   2020-06-24 
10:16:57.0 +0200
@@ -486,3 +486,7 @@
 def all(cls):
 for mod in six.itervalues(fabric_modules):
 yield mod()
+
+@classmethod
+def list_registered_drivers(cls):
+return os.listdir('/sys/module/target_core_mod/holders')
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.71/rtslib/root.py 
new/python-rtslib-fb-v2.1.73/rtslib/root.py
--- old/python-rtslib-fb-v2.1.71/rtslib/root.py 2019-11-06 13:35:08.0 
+0100
+++ new/python-rtslib-fb-v2.1.73/rtslib/root.py 2020-06-24 10:16:57.0 
+0200
@@ -85,7 +85,7 @@
 modprobe('target_core_mod')
 self._create_in_cfs_ine('any')
 
-self._set_dbroot_if_needed()
+self._set_dbroot()
 
 def _list_targets(self):
 self._check_self()
@@ -160,13 +160,21 @@
 def __str__(self):
 return "rtslib"
 
-def _set_dbroot_if_needed(self):
+def _set_dbroot(self):
 dbroot_path = self.path + "/dbroot"
 if not os.path.exists(dbroot_path):
 

commit python-rtslib-fb for openSUSE:Factory

2020-03-05 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2020-03-05 23:21:50

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.26092 (New)


Package is "python-rtslib-fb"

Thu Mar  5 23:21:50 2020 rev:23 rq:781620 version:2.1.71

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2020-03-04 09:48:10.198207018 +0100
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.26092/python-rtslib-fb.changes 
2020-03-05 23:21:54.845298769 +0100
@@ -4 +4 @@
-- Update to version v2.1.71 (jre#SLE-9345):
+- Update to version v2.1.71 (jre#SLE-7751):



Other differences:
--



commit python-rtslib-fb for openSUSE:Factory

2020-03-04 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2020-03-04 09:47:52

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.26092 (New)


Package is "python-rtslib-fb"

Wed Mar  4 09:47:52 2020 rev:22 rq:781294 version:2.1.71

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2019-09-17 13:39:46.181820277 +0200
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.26092/python-rtslib-fb.changes 
2020-03-04 09:48:10.198207018 +0100
@@ -1,0 +2,8 @@
+Tue Mar 03 15:46:53 UTC 2020 - ldun...@suse.com
+
+- Update to version v2.1.71 (jre#SLE-9345):
+  * version 2.1.71
+  * restoreconfig: fix skipping of targets [re]loading
+  Replacing python-rtslib-fb-v2.1.70.tar.xz with 
python-rtslib-fb-v2.1.71.tar.xz
+
+---

Old:

  python-rtslib-fb-v2.1.70.tar.xz

New:

  python-rtslib-fb-v2.1.71.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.loPB6c/_old  2020-03-04 09:48:12.634208478 +0100
+++ /var/tmp/diff_new_pack.loPB6c/_new  2020-03-04 09:48:12.634208478 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2020 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -19,12 +19,12 @@
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-rtslib-fb
-Version:2.1.70
+Version:2.1.71
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Url:https://github.com/open-iscsi/rtslib-fb.git
+URL:https://github.com/open-iscsi/rtslib-fb.git
 Source: %{name}-v%{version}.tar.xz
 Patch1: rbd-support.patch
 BuildRequires:  %{python_module pyudev}
@@ -83,7 +83,8 @@
 %files %{python_files}
 %python_alternative %{_bindir}/targetctl
 %{python_sitelib}/*
-%doc COPYING README.md
+%license COPYING
+%doc README.md
 %doc %python_alternative %{_mandir}/man5/saveconfig.json.5.gz
 %doc %python_alternative %{_mandir}/man8/targetctl.8.gz
 %dir %{dbdir}

++ _service ++
--- /var/tmp/diff_new_pack.loPB6c/_old  2020-03-04 09:48:12.662208495 +0100
+++ /var/tmp/diff_new_pack.loPB6c/_new  2020-03-04 09:48:12.662208495 +0100
@@ -7,7 +7,7 @@
 @PARENT_TAG@
 v(\d*\.\d*\.)fb(\d*)
 \1\2
-v2.1.70
+v2.1.71
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.loPB6c/_old  2020-03-04 09:48:12.674208502 +0100
+++ /var/tmp/diff_new_pack.loPB6c/_new  2020-03-04 09:48:12.674208502 +0100
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  2b160b754d48d5dfdfe1d41089d4e9af24ba3b29
\ No newline at end of file
+  b37bc67fc7ed3d1ec447e9f43eb68d30dd716367
\ No newline at end of file

++ python-rtslib-fb-v2.1.70.tar.xz -> python-rtslib-fb-v2.1.71.tar.xz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.70/rtslib/__init__.py 
new/python-rtslib-fb-v2.1.71/rtslib/__init__.py
--- old/python-rtslib-fb-v2.1.70/rtslib/__init__.py 2019-08-26 
12:06:22.0 +0200
+++ new/python-rtslib-fb-v2.1.71/rtslib/__init__.py 2019-11-06 
13:35:08.0 +0100
@@ -36,7 +36,7 @@
 
 from .alua import ALUATargetPortGroup
 
-__version__ = '2.1.70'
+__version__ = '2.1.71'
 __author__ = "Jerome Martin "
 __url__ = 'http://github.com/open-iscsi/rtslib-fb'
 __description__ = 'API for Linux kernel SCSI target (aka LIO)'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-v2.1.70/rtslib/root.py 
new/python-rtslib-fb-v2.1.71/rtslib/root.py
--- old/python-rtslib-fb-v2.1.70/rtslib/root.py 2019-08-26 12:06:22.0 
+0200
+++ new/python-rtslib-fb-v2.1.71/rtslib/root.py 2019-11-06 13:35:08.0 
+0100
@@ -433,8 +433,8 @@
 # Instantiate target
 Target.setup(fm_obj, t, err_func)
 
-if target:
-break
+if target:
+break
 
 return errors
 

++ rbd-support.patch ++
--- /var/tmp/diff_new_pack.loPB6c/_old  2020-03-04 09:48:12.782208567 +0100
+++ /var/tmp/diff_new_pack.loPB6c/_new  2020-03-04 09:48:12.786208569 +0100
@@ -8,12 +8,10 @@
 
 Reviewed-by: David Disseldorp 
 ---
- rtslib/__init__.py |   1 +
- 

commit python-rtslib-fb for openSUSE:Factory

2019-09-17 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2019-09-17 13:39:44

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.7948 (New)


Package is "python-rtslib-fb"

Tue Sep 17 13:39:44 2019 rev:21 rq:731405 version:2.1.70

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2019-02-19 12:03:01.809056633 +0100
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.7948/python-rtslib-fb.changes  
2019-09-17 13:39:46.181820277 +0200
@@ -1,0 +2,22 @@
+Mon Sep 16 18:14:18 UTC 2019 - ldun...@suse.com
+
+- Update to version v2.1.70:
+  * version 2.1.70
+  * restoreconfig: add ability to restore/reload single target or 
storage_object
+  * rtslib: fix __version__
+  * saveconfig: add hw_block_size support in control string
+  * remove extra semicolons in _get_saveconf
+  * Add 'readable' param to Group list_*() methods
+  * Handle write-only parameters like attributes
+  * save_to_file() function breaks symbolic link when saving configuration
+  * Handle write-only attributes.
+  * Allow bs_cache to be bypassed
+  * report the correct size for partitions
+  * restoreconfig: support restore when list is non-empty
+  Replacing python-rtslib-fb-2.1.69.tar.xz with 
python-rtslib-fb-v2.1.70.tar.xz,
+  and removing patches:
+  * 0001-Handle-write-only-attributes.patch
+  * 0002-Handle-write-only-parameters-like-attributes.patch
+  * 0003-Add-readable-param-to-Group-list_-methods.patch
+
+---

Old:

  0001-Handle-write-only-attributes.patch
  0002-Handle-write-only-parameters-like-attributes.patch
  0003-Add-readable-param-to-Group-list_-methods.patch
  python-rtslib-fb-2.1.69.tar.xz

New:

  python-rtslib-fb-v2.1.70.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.UlH7UI/_old  2019-09-17 13:39:46.761820184 +0200
+++ /var/tmp/diff_new_pack.UlH7UI/_new  2019-09-17 13:39:46.765820184 +0200
@@ -12,24 +12,21 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-rtslib-fb
-Version:2.1.69
+Version:2.1.70
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
 Url:https://github.com/open-iscsi/rtslib-fb.git
-Source: %{name}-%{version}.tar.xz
+Source: %{name}-v%{version}.tar.xz
 Patch1: rbd-support.patch
-Patch2: 0001-Handle-write-only-attributes.patch
-Patch3: 0002-Handle-write-only-parameters-like-attributes.patch
-Patch4: 0003-Add-readable-param-to-Group-list_-methods.patch
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module six}
@@ -39,7 +36,7 @@
 Requires(post): update-alternatives
 Requires(postun): update-alternatives
 Provides:   python-rtslib = %{version}-%{release}
-Obsoletes:  python-rtslib
+Obsoletes:  python-rtslib < %{version}
 %if 0%{?sle_version} >= 15
 # explicit Provides advertising RBD support
 Provides:   python-rtslib-rbd = %{version}
@@ -54,14 +51,11 @@
 the Apache 2.0 license. Contributions are welcome
 
 %prep
-%setup -q
+%setup -q -n %{name}-v%{version}
 %if 0%{?sle_version} >= 15
 # RBD support is dependent on LIO changes present in the SLE/Leap kernel
 %patch1 -p1
 %endif
-%patch2 -p1
-%patch3 -p1
-%patch4 -p1
 
 %build
 %python_build

++ _service ++
--- /var/tmp/diff_new_pack.UlH7UI/_old  2019-09-17 13:39:46.785820180 +0200
+++ /var/tmp/diff_new_pack.UlH7UI/_new  2019-09-17 13:39:46.789820180 +0200
@@ -7,7 +7,7 @@
 @PARENT_TAG@
 v(\d*\.\d*\.)fb(\d*)
 \1\2
-v2.1.fb69
+v2.1.70
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.UlH7UI/_old  2019-09-17 13:39:46.805820177 +0200
+++ /var/tmp/diff_new_pack.UlH7UI/_new  2019-09-17 13:39:46.805820177 +0200
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  b2ec3746fb772aa3ff8b8853965292ca7dc2d7b1
\ No newline at end of file
+  2b160b754d48d5dfdfe1d41089d4e9af24ba3b29
\ No newline at end of file




commit python-rtslib-fb for openSUSE:Factory

2019-02-19 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2019-02-19 12:02:47

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.28833 (New)


Package is "python-rtslib-fb"

Tue Feb 19 12:02:47 2019 rev:20 rq:677187 version:2.1.69

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2019-01-03 18:09:50.16395 +0100
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.28833/python-rtslib-fb.changes 
2019-02-19 12:03:01.809056633 +0100
@@ -1,0 +2,9 @@
+Mon Feb 18 17:56:57 UTC 2019 - ldun...@suse.com
+
+- Added 3 patches subbmitted and accepted upstream, to deal with
+  possibly-write-only sysfs attributes (bsc#1123933), adding:
+  * 0001-Handle-write-only-attributes.patch
+  * 0002-Handle-write-only-parameters-like-attributes.patch
+  * 0003-Add-readable-param-to-Group-list_-methods.patch
+
+---

New:

  0001-Handle-write-only-attributes.patch
  0002-Handle-write-only-parameters-like-attributes.patch
  0003-Add-readable-param-to-Group-list_-methods.patch



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.T9szIe/_old  2019-02-19 12:03:02.393056335 +0100
+++ /var/tmp/diff_new_pack.T9szIe/_new  2019-02-19 12:03:02.397056333 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2019 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via https://bugs.opensuse.org/
+# Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
 
@@ -24,9 +24,12 @@
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Url:http://github.com/open-iscsi/rtslib-fb.git
+Url:https://github.com/open-iscsi/rtslib-fb.git
 Source: %{name}-%{version}.tar.xz
 Patch1: rbd-support.patch
+Patch2: 0001-Handle-write-only-attributes.patch
+Patch3: 0002-Handle-write-only-parameters-like-attributes.patch
+Patch4: 0003-Add-readable-param-to-Group-list_-methods.patch
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module six}
@@ -56,6 +59,9 @@
 # RBD support is dependent on LIO changes present in the SLE/Leap kernel
 %patch1 -p1
 %endif
+%patch2 -p1
+%patch3 -p1
+%patch4 -p1
 
 %build
 %python_build

++ 0001-Handle-write-only-attributes.patch ++
>From 03c8c15983a21bc2b158c58140a2871bb1ed857b Mon Sep 17 00:00:00 2001
From: Lee Duncan 
Date: Wed, 6 Feb 2019 12:29:41 -0800
Subject: [PATCH 1/3] Handle write-only attributes.
Patch-mainline: In developer's queue

A recent kernel change (see commit 6baca7601bdee2e5) makes
the pi_prot_format protection information attribute write-only,
since it always returned 0 when being read. This commit is being
reverted, but it still brought up the prospect of write-only
attributes.

Currently, when doing a dump(), rtslib iterates through all
readable attributes to decide which ones to save as part of
our current state, but saving write-only attributes
makes no sense, since we cannot read them to capture their
value. Towards this end, enhande the _list_files() internal
method to allow filtering on whether the file is writable
as well as whether or not it is readable. Then modify
list_attributes() to allow this new parameter and modify
dump() to request only R/W attributes.
---
 rtslib/node.py | 53 ++---
 1 file changed, 34 insertions(+), 19 deletions(-)

diff --git a/rtslib/node.py b/rtslib/node.py
index 1d77cd1b81ba..1ab7d9b8c58b 100644
--- a/rtslib/node.py
+++ b/rtslib/node.py
@@ -81,31 +81,42 @@ class CFSNode(object):
 raise RTSLibNotInCFS("This %s does not exist in configFS"
  % self.__class__.__name__)
 
-def _list_files(self, path, writable=None):
+def _list_files(self, path, writable=None, readable=None):
 '''
 List files under a path depending on their owner's write permissions.
 @param path: The path under which the files are expected to be. If the
 path itself is not a directory, an empty list will be returned.
 @type path: str
-@param 

commit python-rtslib-fb for openSUSE:Factory

2019-01-03 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2019-01-03 18:09:49

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new.28833 (New)


Package is "python-rtslib-fb"

Thu Jan  3 18:09:49 2019 rev:19 rq:662617 version:2.1.69

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-10-22 11:23:17.947158503 +0200
+++ 
/work/SRC/openSUSE:Factory/.python-rtslib-fb.new.28833/python-rtslib-fb.changes 
2019-01-03 18:09:50.16395 +0100
@@ -1,0 +2,10 @@
+Fri Dec  7 09:29:54 UTC 2018 - dd...@suse.com
+
+- Enable RBD support for SLE/Leap 15+ (bsc#1118516)
+
+---
+Tue Dec  4 12:54:00 UTC 2018 - Matej Cepl 
+
+- Remove superfluous devel dependency for noarch package
+
+---



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.oabGaW/_old  2019-01-03 18:09:50.579966242 +0100
+++ /var/tmp/diff_new_pack.oabGaW/_new  2019-01-03 18:09:50.579966242 +0100
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -27,7 +27,6 @@
 Url:http://github.com/open-iscsi/rtslib-fb.git
 Source: %{name}-%{version}.tar.xz
 Patch1: rbd-support.patch
-BuildRequires:  %{python_module devel}
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
 BuildRequires:  %{python_module six}
@@ -38,7 +37,7 @@
 Requires(postun): update-alternatives
 Provides:   python-rtslib = %{version}-%{release}
 Obsoletes:  python-rtslib
-%if 0%{?sle_version} == 15
+%if 0%{?sle_version} >= 15
 # explicit Provides advertising RBD support
 Provides:   python-rtslib-rbd = %{version}
 Obsoletes:  python-rtslib-rbd < %{version}
@@ -53,7 +52,7 @@
 
 %prep
 %setup -q
-%if 0%{?sle_version} == 15
+%if 0%{?sle_version} >= 15
 # RBD support is dependent on LIO changes present in the SLE/Leap kernel
 %patch1 -p1
 %endif




commit python-rtslib-fb for openSUSE:Factory

2018-10-22 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-10-22 11:23:14

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Mon Oct 22 11:23:14 2018 rev:18 rq:643053 version:2.1.69

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-04-19 15:29:24.199264772 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-10-22 11:23:17.947158503 +0200
@@ -1,0 +2,23 @@
+Thu Oct 18 23:27:42 UTC 2018 - opensuse-packag...@opensuse.org
+
+- Update to version 2.1.69:
+  * version 2.1.fb69
+  * fix compiler warning
+  * version 2.1.fb68
+  * Fix typo
+  * - remove underscore in hostname
+  * tcm: allow to enable asynchronous I/O for file backing stores
+  * saveconfig: way for block-level save with delete command
+  * saveconfig: fix missing import
+  * saveconfig: handle no attr exception in _parse_info()
+  * saveconfig: fix failure in absence of save file
+  * saveconfig: dump control string containing control=value tuples
+  * restoreconfig: fix alua tpg config setup
+  * tcmu: add control constructor arg
+  * save_to_file: support saveconfig at storage object level
+  * Allow creating more than 256 LUNs per target
+  * Ship a systemd service file
+ Which replaces python-rtslib-fb-2.1.67.tar.xz with
+ python-rtslib-fb-2.1.69.tar.xz, and updates the SPEC file as well.
+
+---

Old:

  python-rtslib-fb-2.1.67.tar.xz

New:

  python-rtslib-fb-2.1.69.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.EZYHrD/_old  2018-10-22 11:23:18.611157836 +0200
+++ /var/tmp/diff_new_pack.EZYHrD/_new  2018-10-22 11:23:18.611157836 +0200
@@ -19,7 +19,7 @@
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-rtslib-fb
-Version:2.1.67
+Version:2.1.69
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0

++ _service ++
--- /var/tmp/diff_new_pack.EZYHrD/_old  2018-10-22 11:23:18.635157812 +0200
+++ /var/tmp/diff_new_pack.EZYHrD/_new  2018-10-22 11:23:18.635157812 +0200
@@ -7,7 +7,7 @@
 @PARENT_TAG@
 v(\d*\.\d*\.)fb(\d*)
 \1\2
-v2.1.fb67
+v2.1.fb69
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.EZYHrD/_old  2018-10-22 11:23:18.651157796 +0200
+++ /var/tmp/diff_new_pack.EZYHrD/_new  2018-10-22 11:23:18.651157796 +0200
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  a46e6bf9ea0f83acdff1761a11c502ea5863945f
\ No newline at end of file
+  b2ec3746fb772aa3ff8b8853965292ca7dc2d7b1
\ No newline at end of file

++ python-rtslib-fb-2.1.67.tar.xz -> python-rtslib-fb-2.1.69.tar.xz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-2.1.67/rtslib/alua.py 
new/python-rtslib-fb-2.1.69/rtslib/alua.py
--- old/python-rtslib-fb-2.1.67/rtslib/alua.py  2018-02-12 18:34:38.0 
+0100
+++ new/python-rtslib-fb-2.1.69/rtslib/alua.py  2018-09-18 08:47:13.0 
+0200
@@ -19,6 +19,7 @@
 
 from .node import CFSNode
 from .utils import RTSLibError, RTSLibALUANotSupported, fread, fwrite
+import six
 
 alua_rw_params = ['alua_access_state', 'alua_access_status',
   'alua_write_metadata', 'alua_access_type', 'preferred',
@@ -393,5 +394,10 @@
 return
 
 alua_tpg_obj = cls(storage_obj, name, alua_tpg['tg_pt_gp_id'])
-for param in alua_rw_params:
-setattr(alua_tpg_obj, param, alua_tpg[param])
+for param, value in six.iteritems(alua_tpg):
+if param != 'name' and param != 'tg_pt_gp_id':
+try:
+setattr(alua_tpg_obj, param, value)
+except:
+raise RTSLibError("Could not set attribute '%s' for alua 
tpg '%s'"
+  % (param, alua_tpg['name']))
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/python-rtslib-fb-2.1.67/rtslib/root.py 
new/python-rtslib-fb-2.1.69/rtslib/root.py
--- old/python-rtslib-fb-2.1.67/rtslib/root.py  2018-02-12 18:34:38.0 
+0100
+++ new/python-rtslib-fb-2.1.69/rtslib/root.py  2018-09-18 08:47:13.0 
+0200
@@ -22,6 +22,7 @@
 import stat
 import json
 import glob
+import errno
 
 from .node import CFSNode
 from .target import Target
@@ -176,6 +177,88 @@
 def _get_dbroot(self):
 return 

commit python-rtslib-fb for openSUSE:Factory

2018-04-19 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-04-19 15:29:22

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Thu Apr 19 15:29:22 2018 rev:17 rq:597224 version:2.1.67

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-04-11 14:02:53.36711 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-04-19 15:29:24.199264772 +0200
@@ -1,0 +2,15 @@
+Tue Apr 10 16:03:33 UTC 2018 - dd...@suse.com
+
+- Merge RBD support from non-fb version (bsc#1079329)
+  + rbd-support.patch (SLE/Leap only, due to LIO kernel dependency)
+  + Add explicit Provides for "python-rtslib-rbd"
+
+---
+Tue Apr 10 12:41:16 UTC 2018 - dd...@suse.com
+
+- Automatically generate version string from upstream tag
+  + Retain current fb-removed version format used
+  + Rename rtslib-fb-2.1.fb67.tar.xz to python-rtslib-fb-2.1.67.tar.xz and
+cleanup hardcoded duplicate name/version values in spec
+
+---

Old:

  rtslib-fb-2.1.fb67.tar.xz

New:

  python-rtslib-fb-2.1.67.tar.xz
  rbd-support.patch



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.oGRNoR/_old  2018-04-19 15:29:24.731242993 +0200
+++ /var/tmp/diff_new_pack.oGRNoR/_new  2018-04-19 15:29:24.731242993 +0200
@@ -16,18 +16,17 @@
 #
 
 
-%define oname rtslib-fb
-%define realver 2.1.fb67
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
-Name:   python-%{oname}
+Name:   python-rtslib-fb
 Version:2.1.67
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
 Url:http://github.com/open-iscsi/rtslib-fb.git
-Source: %{oname}-%{realver}.tar.xz
+Source: %{name}-%{version}.tar.xz
+Patch1: rbd-support.patch
 BuildRequires:  %{python_module devel}
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
@@ -39,6 +38,11 @@
 Requires(postun): update-alternatives
 Provides:   python-rtslib = %{version}-%{release}
 Obsoletes:  python-rtslib
+%if 0%{?sle_version} == 15
+# explicit Provides advertising RBD support
+Provides:   python-rtslib-rbd = %{version}
+Obsoletes:  python-rtslib-rbd < %{version}
+%endif
 BuildArch:  noarch
 %python_subpackages
 
@@ -48,7 +52,11 @@
 the Apache 2.0 license. Contributions are welcome
 
 %prep
-%setup -q -n %{oname}-%{realver}
+%setup -q
+%if 0%{?sle_version} == 15
+# RBD support is dependent on LIO changes present in the SLE/Leap kernel
+%patch1 -p1
+%endif
 
 %build
 %python_build

++ _service ++
--- /var/tmp/diff_new_pack.oGRNoR/_old  2018-04-19 15:29:24.775241191 +0200
+++ /var/tmp/diff_new_pack.oGRNoR/_new  2018-04-19 15:29:24.779241028 +0200
@@ -3,8 +3,10 @@
 git
 https://github.com/open-iscsi/rtslib-fb.git
 
-rtslib-fb
-2.1.fb67
+python-rtslib-fb
+@PARENT_TAG@
+v(\d*\.\d*\.)fb(\d*)
+\1\2
 v2.1.fb67
 enable
   

++ rbd-support.patch ++
>From 9496352d515b9f440b68c8534e41899cf1a9570e Mon Sep 17 00:00:00 2001
From: Mike Christie 
Date: Wed, 29 Jul 2015 04:28:02 -0500
Subject: [PATCH] rbd support

rtslib-fb-rbd-support.patch obtained from:
https://marc.info/?l=ceph-devel=143816209010058

Reviewed-by: David Disseldorp 
---
 rtslib/__init__.py |   1 +
 rtslib/tcm.py  | 103 +
 2 files changed, 104 insertions(+)

diff --git a/rtslib/__init__.py b/rtslib/__init__.py
index 568619e..1a5bee5 100644
--- a/rtslib/__init__.py
+++ b/rtslib/__init__.py
@@ -32,6 +32,7 @@ from .fabric import FabricModule
 
 from .tcm import FileIOStorageObject, BlockStorageObject
 from .tcm import PSCSIStorageObject, RDMCPStorageObject, 
UserBackedStorageObject
+from .tcm import RBDStorageObject
 from .tcm import StorageObjectFactory
 
 from .alua import ALUATargetPortGroup
diff --git a/rtslib/tcm.py b/rtslib/tcm.py
index 1aeea23..17df8e9 100644
--- a/rtslib/tcm.py
+++ b/rtslib/tcm.py
@@ -780,6 +780,107 @@ class BlockStorageObject(StorageObject):
 d['dev'] = self.udev_path
 return d
 
+class RBDStorageObject(StorageObject):
+'''
+An interface to configFS storage objects for RBD backstore.
+'''
+
+# RBDStorageObject private stuff
+
+def __init__(self, name, dev=None, 

commit python-rtslib-fb for openSUSE:Factory

2018-04-11 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-04-11 14:00:35

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Wed Apr 11 14:00:35 2018 rev:16 rq:595002 version:2.1.67

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-02-27 16:58:12.647493716 +0100
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-04-11 14:02:53.36711 +0200
@@ -1,0 +2,20 @@
+Mon Apr 09 21:41:01 UTC 2018 - ldun...@suse.com
+
+- Update to version 2.1.fb67:
+  * Add missing dependency on six in setup.py
+  * Display a more meaningful error when targetcli cannot change "dbroot"
+  * Raise an error about failing to change the dbroot value only if the 
directory does not exist
+  * More compatibility syntax for legacy distros
+  * Remove hba-only directories in clear_existing()
+  * Correct name for Xen pvscsi
+  * version 2.1.fb65
+  * Fix unqualified reference to pyudev.Device
+  * version 2.1.fb66
+  * create: remove stale hba-only dir
+  * version 2.1.fb67
+- This replaced rtslib-fb-2.1.fb64.tar.xz with
+  rtslib-fb-2.1.fb67.tar.xz, and it also removed
+  the patch correct-name-for-xen-pvscsi.patch,
+  since it is already in the updated tarball
+
+---

Old:

  correct-name-for-xen-pvscsi.patch
  rtslib-fb-2.1.fb64.tar.xz

New:

  rtslib-fb-2.1.fb67.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.Lozx8U/_old  2018-04-11 14:02:55.280786403 +0200
+++ /var/tmp/diff_new_pack.Lozx8U/_new  2018-04-11 14:02:55.280786403 +0200
@@ -17,18 +17,17 @@
 
 
 %define oname rtslib-fb
-%define realver 2.1.fb64
+%define realver 2.1.fb67
 %define dbdir %{_sysconfdir}/target
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-%{oname}
-Version:2.1.64
+Version:2.1.67
 Release:0%{?dist}
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
 Url:http://github.com/open-iscsi/rtslib-fb.git
 Source: %{oname}-%{realver}.tar.xz
-Patch1: correct-name-for-xen-pvscsi.patch
 BuildRequires:  %{python_module devel}
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
@@ -50,7 +49,6 @@
 
 %prep
 %setup -q -n %{oname}-%{realver}
-%patch1 -p1
 
 %build
 %python_build

++ _service ++
--- /var/tmp/diff_new_pack.Lozx8U/_old  2018-04-11 14:02:55.316785102 +0200
+++ /var/tmp/diff_new_pack.Lozx8U/_new  2018-04-11 14:02:55.320784957 +0200
@@ -4,8 +4,8 @@
 https://github.com/open-iscsi/rtslib-fb.git
 
 rtslib-fb
-2.1.fb64
-v2.1.fb64
+2.1.fb67
+v2.1.fb67
 enable
   
   

++ _servicedata ++
--- /var/tmp/diff_new_pack.Lozx8U/_old  2018-04-11 14:02:55.340784235 +0200
+++ /var/tmp/diff_new_pack.Lozx8U/_new  2018-04-11 14:02:55.340784235 +0200
@@ -1,4 +1,4 @@
 
 
 https://github.com/open-iscsi/rtslib-fb.git
-  737496e24ede21effc807a553cebe88ed5660a2b
\ No newline at end of file
+  a46e6bf9ea0f83acdff1761a11c502ea5863945f
\ No newline at end of file

++ rtslib-fb-2.1.fb64.tar.xz -> rtslib-fb-2.1.fb67.tar.xz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.fb64/rtslib/fabric.py 
new/rtslib-fb-2.1.fb67/rtslib/fabric.py
--- old/rtslib-fb-2.1.fb64/rtslib/fabric.py 2017-08-15 23:28:33.0 
+0200
+++ new/rtslib-fb-2.1.fb67/rtslib/fabric.py 2018-02-12 18:34:38.0 
+0100
@@ -118,8 +118,8 @@
 from .target import Target
 from .utils import _get_auth_attr, _set_auth_attr
 
-version_attributes = {"lio_version", "version"}
-discovery_auth_attributes = {"discovery_auth"}
+version_attributes = set(["lio_version", "version"])
+discovery_auth_attributes = set(["discovery_auth"])
 target_names_excludes = version_attributes | discovery_auth_attributes
 
 
@@ -440,7 +440,7 @@
 
 class XenPvScsiFabricModule(_BaseFabricModule):
 def __init__(self):
-super(XenPvScsiFabricModule, self).__init__('xen_pvscsi')
+super(XenPvScsiFabricModule, self).__init__('xen-pvscsi')
 self._path = "%s/%s" % (self.configfs_dir, 'xen-pvscsi')
 self.features = ("nexus", "tpgts")
 self.wwn_types = ('naa',)
@@ -469,7 +469,7 @@
 "tcm_fc": FCoEFabricModule,
 #"usb_gadget": USBGadgetFabricModule, # very rare, don't show
 "vhost": VhostFabricModule,
-"xen_pvscsi": XenPvScsiFabricModule,
+

commit python-rtslib-fb for openSUSE:Factory

2018-02-27 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-02-27 16:58:11

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Tue Feb 27 16:58:11 2018 rev:15 rq:579975 version:2.1.64

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-01-25 12:41:01.861289780 +0100
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-02-27 16:58:12.647493716 +0100
@@ -1,0 +2,5 @@
+Sun Feb 25 08:09:45 UTC 2018 - o...@aepfle.de
+
+- Fix upgrade path by provide/obsolete python-rtslib (bsc#1082693)
+
+---



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.W1CLco/_old  2018-02-27 16:58:14.131440098 +0100
+++ /var/tmp/diff_new_pack.W1CLco/_new  2018-02-27 16:58:14.135439954 +0100
@@ -19,7 +19,6 @@
 %define oname rtslib-fb
 %define realver 2.1.fb64
 %define dbdir %{_sysconfdir}/target
-%define oldpython python
 %{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-%{oname}
 Version:2.1.64
@@ -39,7 +38,8 @@
 Requires:   python-pyudev
 Requires(post): update-alternatives
 Requires(postun): update-alternatives
-Conflicts:  %{oldpython}-rtslib
+Provides:   python-rtslib = %{version}-%{release}
+Obsoletes:  python-rtslib
 BuildArch:  noarch
 %python_subpackages
 




commit python-rtslib-fb for openSUSE:Factory

2018-01-25 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-01-25 12:40:55

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Thu Jan 25 12:40:55 2018 rev:14 rq:569368 version:2.1.64

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2018-01-10 23:35:53.174001385 +0100
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-01-25 12:41:01.861289780 +0100
@@ -1,0 +2,6 @@
+Wed Jan 24 18:43:43 UTC 2018 - ldun...@suse.com
+
+- Fix incorrect naming for XEN (bsc#1076455), adding patch:
+  * correct-name-for-xen-pvscsi.patch
+
+---

New:

  correct-name-for-xen-pvscsi.patch



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.8MdVRn/_old  2018-01-25 12:41:02.781246831 +0100
+++ /var/tmp/diff_new_pack.8MdVRn/_new  2018-01-25 12:41:02.785246644 +0100
@@ -29,6 +29,7 @@
 Group:  Development/Languages/Python
 Url:http://github.com/open-iscsi/rtslib-fb.git
 Source: %{oname}-%{realver}.tar.xz
+Patch1: correct-name-for-xen-pvscsi.patch
 BuildRequires:  %{python_module devel}
 BuildRequires:  %{python_module pyudev}
 BuildRequires:  %{python_module setuptools}
@@ -49,6 +50,7 @@
 
 %prep
 %setup -q -n %{oname}-%{realver}
+%patch1 -p1
 
 %build
 %python_build

++ correct-name-for-xen-pvscsi.patch ++
From: Olaf Hering 
Date: Wed, 17 Jan 2018 12:27:48 +0100
Subject: Correct name for Xen pvscsi
Git-commit: 5a5670608b7abab061a59d65568e8ab0a53b6ef0
References: bsc#1076455

The name used in released products is xen-pvscsi, not xen_pvscsi.

Fixes: 2bcc4cd ("Add support for xen-scsiback")

Signed-off-by: Olaf Hering 
Acked-by: Lee Duncan 
---
 rtslib/fabric.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rtslib/fabric.py b/rtslib/fabric.py
index 4e9a1ee4073a..b529f14815cc 100644
--- a/rtslib/fabric.py
+++ b/rtslib/fabric.py
@@ -440,7 +440,7 @@ class VhostFabricModule(_BaseFabricModule):
 
 class XenPvScsiFabricModule(_BaseFabricModule):
 def __init__(self):
-super(XenPvScsiFabricModule, self).__init__('xen_pvscsi')
+super(XenPvScsiFabricModule, self).__init__('xen-pvscsi')
 self._path = "%s/%s" % (self.configfs_dir, 'xen-pvscsi')
 self.features = ("nexus", "tpgts")
 self.wwn_types = ('naa',)
@@ -469,7 +469,7 @@ fabric_modules = {
 "tcm_fc": FCoEFabricModule,
 #"usb_gadget": USBGadgetFabricModule, # very rare, don't show
 "vhost": VhostFabricModule,
-"xen_pvscsi": XenPvScsiFabricModule,
+"xen-pvscsi": XenPvScsiFabricModule,
 "ibmvscsis": IbmvscsisFabricModule,
 }
 




commit python-rtslib-fb for openSUSE:Factory

2018-01-10 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2018-01-10 23:35:45

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Wed Jan 10 23:35:45 2018 rev:13 rq:562902 version:2.1.64

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2017-11-30 12:44:51.695074397 +0100
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2018-01-10 23:35:53.174001385 +0100
@@ -1,0 +2,20 @@
+Tue Jan  9 14:37:15 UTC 2018 - tchva...@suse.com
+
+- Fix the conflict to the rtslib properly
+
+---
+Wed Jan  3 16:13:57 UTC 2018 - tchva...@suse.com
+
+- Drop the epydoc dependency/documentation generating from the package
+  to allow building in py3 only enviroment
+
+---
+Sun Dec 10 21:14:08 UTC 2017 - ldun...@suse.com
+
+- Converting RPM SPEC file to singlespec format (bsc#1045332),
+  updating SPEC file only.
+- ran 'spec-cleaner' on SPEC file to clean it up.
+- Converted from manually-added rtslib-fb-2.1.fb64.tar.gz to
+  tar_scm service-retrieved rtslib-fb-2.1.fb64.tar.xz
+
+---

Old:

  rtslib-fb-2.1.fb64.tar.gz

New:

  rtslib-fb-2.1.fb64.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.M6mH9l/_old  2018-01-10 23:35:55.785878835 +0100
+++ /var/tmp/diff_new_pack.M6mH9l/_new  2018-01-10 23:35:55.785878835 +0100
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -18,37 +18,31 @@
 
 %define oname rtslib-fb
 %define realver 2.1.fb64
-%define dbdir /etc/target
-
+%define dbdir %{_sysconfdir}/target
+%define oldpython python
+%{?!python_module:%define python_module() python-%{**} python3-%{**}}
 Name:   python-%{oname}
 Version:2.1.64
 Release:0%{?dist}
-Url:http://github.com/open-iscsi/rtslib-fb.git
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Source: %{oname}-%{realver}.tar.gz
-Conflicts:  python-rtslib
+Url:http://github.com/open-iscsi/rtslib-fb.git
+Source: %{oname}-%{realver}.tar.xz
+BuildRequires:  %{python_module devel}
+BuildRequires:  %{python_module pyudev}
+BuildRequires:  %{python_module setuptools}
+BuildRequires:  %{python_module six}
 BuildRequires:  fdupes
-BuildRequires:  python-devel
-BuildRequires:  python-setuptools
-BuildRequires:  python-six
-BuildRoot:  %{_tmppath}/%{name}-%{version}-build
-Requires:   pyudev
-
-%description
-rtslib-fb is an object-based Python library for configuring the LIO generic
-SCSI target, present in 3.x Linux kernel versions. rtslib-fb is licensed under
-the Apache 2.0 license. Contributions are welcome
-
-%package doc
-Summary:Documentatoin for Python rtslib-fb
-Group:  Documentation/HTML
+BuildRequires:  python-rpm-macros
+Requires:   python-pyudev
+Requires(post): update-alternatives
+Requires(postun): update-alternatives
+Conflicts:  %{oldpython}-rtslib
 BuildArch:  noarch
-BuildRequires:  epydoc
-BuildRequires:  pyudev
+%python_subpackages
 
-%description doc
+%description
 rtslib-fb is an object-based Python library for configuring the LIO generic
 SCSI target, present in 3.x Linux kernel versions. rtslib-fb is licensed under
 the Apache 2.0 license. Contributions are welcome
@@ -57,44 +51,36 @@
 %setup -q -n %{oname}-%{realver}
 
 %build
-%__python setup.py build
-%__mkdir_p doc/
-epydoc --no-sourcecode --html -n %{oname} --exclude configobj rtslib_fb/*.py
-%__mv html doc/
+%python_build
 
 %install
-[ "%{buildroot}" != "/" ] && %__rm -rf %{buildroot}
-%__python setup.py install --skip-build --prefix=%{_prefix} --root=%{buildroot}
-%fdupes %{buildroot}%{python_sitelib}
-%__install -d -m755 %{buildroot}%{_defaultdocdir}/python-rtslib-doc-%{version}
-%__cp -r doc/* %{buildroot}%{_defaultdocdir}/python-rtslib-doc-%{version}/
-%fdupes %{buildroot}%{_defaultdocdir}
-%__install -d -m755 %{buildroot}%{_sysconfdir}/target
-%__install -d -m755 %{buildroot}%{_mandir}/man5
-%__install -m644 doc/saveconfig.json.5 %{buildroot}%{_mandir}/man5
-%__install -d -m755 %{buildroot}%{_mandir}/man8
-%__install -m644 

commit python-rtslib-fb for openSUSE:Factory

2017-11-30 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2017-11-30 12:44:51

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Thu Nov 30 12:44:51 2017 rev:12 rq:546175 version:2.1.64

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2017-07-06 00:04:05.148498031 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2017-11-30 12:44:51.695074397 +0100
@@ -1,0 +2,10 @@
+Thu Aug 17 08:03:10 UTC 2017 - ls...@suse.com
+
+- Update to version 2.1.fb64
+  *Improve ALUA and TCMU support, as well as moving the default 
+   directory for APTPL files from /var/target to /etc/target
+   for better FHS compliance.
+  *Remove patch Switch-target-driver-DB-root-dir-to-etc-target.patch
+   from the spec file because upstream already has this change.
+
+---

Old:

  Switch-target-driver-DB-root-dir-to-etc-target.patch
  rtslib-fb-2.1.fb63.tar.xz

New:

  rtslib-fb-2.1.fb64.tar.gz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.dYW2TU/_old  2017-11-30 12:44:52.467046333 +0100
+++ /var/tmp/diff_new_pack.dYW2TU/_new  2017-11-30 12:44:52.471046187 +0100
@@ -17,18 +17,17 @@
 
 
 %define oname rtslib-fb
-%define realver 2.1.fb63
+%define realver 2.1.fb64
 %define dbdir /etc/target
 
 Name:   python-%{oname}
-Version:2.1.63
+Version:2.1.64
 Release:0%{?dist}
 Url:http://github.com/open-iscsi/rtslib-fb.git
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Source: %{oname}-%{realver}.tar.xz
-Patch1: Switch-target-driver-DB-root-dir-to-etc-target.patch
+Source: %{oname}-%{realver}.tar.gz
 Conflicts:  python-rtslib
 BuildRequires:  fdupes
 BuildRequires:  python-devel
@@ -56,7 +55,6 @@
 
 %prep
 %setup -q -n %{oname}-%{realver}
-%patch1 -p1
 
 %build
 %__python setup.py build




commit python-rtslib-fb for openSUSE:Factory

2017-07-05 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2017-07-06 00:04:03

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Thu Jul  6 00:04:03 2017 rev:11 rq:508175 version:2.1.63

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2017-04-28 09:13:47.721919345 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2017-07-06 00:04:05.148498031 +0200
@@ -1,0 +2,7 @@
+Thu Jun  8 21:37:20 UTC 2017 - ldun...@suse.com
+
+- Enable Persistent Reservations (bsc#1042944):
+  * Add patch Switch-target-driver-DB-root-dir-to-etc-target.patch
+  * Add /etc/target/pr and /etc/target/alua to SPEC file
+
+---

New:

  Switch-target-driver-DB-root-dir-to-etc-target.patch



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.xDFs7F/_old  2017-07-06 00:04:05.728416333 +0200
+++ /var/tmp/diff_new_pack.xDFs7F/_new  2017-07-06 00:04:05.732415770 +0200
@@ -18,6 +18,7 @@
 
 %define oname rtslib-fb
 %define realver 2.1.fb63
+%define dbdir /etc/target
 
 Name:   python-%{oname}
 Version:2.1.63
@@ -27,6 +28,7 @@
 License:Apache-2.0
 Group:  Development/Languages/Python
 Source: %{oname}-%{realver}.tar.xz
+Patch1: Switch-target-driver-DB-root-dir-to-etc-target.patch
 Conflicts:  python-rtslib
 BuildRequires:  fdupes
 BuildRequires:  python-devel
@@ -54,6 +56,7 @@
 
 %prep
 %setup -q -n %{oname}-%{realver}
+%patch1 -p1
 
 %build
 %__python setup.py build
@@ -73,6 +76,9 @@
 %__install -m644 doc/saveconfig.json.5 %{buildroot}%{_mandir}/man5
 %__install -d -m755 %{buildroot}%{_mandir}/man8
 %__install -m644 doc/targetctl.8 %{buildroot}%{_mandir}/man8
+%__install -d -m755 %{buildroot}/%{dbdir}
+%__install -d -m755 %{buildroot}/%{dbdir}/pr
+%__install -d -m755 %{buildroot}/%{dbdir}/alua
 
 %clean
 [ "%{buildroot}" != "/" ] && %__rm -rf %{buildroot}
@@ -85,6 +91,9 @@
 %dir %{_sysconfdir}/target
 %doc %{_mandir}/man5/saveconfig.json.5.gz
 %doc %{_mandir}/man8/targetctl.8.gz
+%dir %{dbdir}
+%dir %{dbdir}/pr
+%dir %{dbdir}/alua
 
 %files doc
 %defattr(-,root,root,-)

++ Switch-target-driver-DB-root-dir-to-etc-target.patch ++
>From f823033e5c6beced0590a00064e1e7a55e76a995 Mon Sep 17 00:00:00 2001
From: Lee Duncan 
Date: Tue, 13 Jun 2017 09:45:30 -0700
Subject: [PATCH] Switch target driver DB root dir to /etc/target

This switches the kernel target driver directory from
the default of /var/target to /etc/target, if the
"dbroot" sysfs attribute is present. If not, the default
of /var/target is maintained. This has to be done
by rtslib/root.py since this module loads the
target_core_mod module, where the dbroot value
must be updated before any target_core_* drivers
register with target_core_mod.
---
 rtslib/root.py | 24 
 rtslib/tcm.py  |  3 ++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/rtslib/root.py b/rtslib/root.py
index 99a25b778cd1..ee7b1039bd06 100644
--- a/rtslib/root.py
+++ b/rtslib/root.py
@@ -28,6 +28,7 @@ from .fabric import FabricModule
 from .tcm import so_mapping, bs_cache, StorageObject
 from .utils import RTSLibError, RTSLibALUANotSupported, modprobe, 
mount_configfs
 from .utils import dict_remove, set_attributes
+from .utils import fread, fwrite
 from .alua import ALUATargetPortGroup
 
 default_save_file = "/etc/target/saveconfig.json"
@@ -57,6 +58,12 @@ class RTSRoot(CFSNode):
 '''
 
 # RTSRoot private stuff
+
+# this should match the kernel target driver default db dir
+_default_dbroot = "/var/target"
+# this is where the target DB is to be located (instead of the default)
+_preferred_dbroot = "/etc/target"
+
 def __init__(self):
 '''
 Instantiate an RTSRoot object. Basically checks for configfs setup and
@@ -75,6 +82,8 @@ class RTSRoot(CFSNode):
 modprobe('target_core_mod')
 self._create_in_cfs_ine('any')
 
+self._set_dbroot_if_needed()
+
 def _list_targets(self):
 self._check_self()
 for fabric_module in self.fabric_modules:
@@ -148,6 +157,19 @@ class RTSRoot(CFSNode):
 def __str__(self):
 return "rtslib"
 
+def _set_dbroot_if_needed(self):
+dbroot_path = self.path + "/dbroot"
+if not os.path.exists(dbroot_path):
+self._dbroot = self._default_dbroot
+return
+self._dbroot = fread(dbroot_path)
+if self._dbroot != self._preferred_dbroot:
+

commit python-rtslib-fb for openSUSE:Factory

2017-04-28 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2017-04-28 09:13:34

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Fri Apr 28 09:13:34 2017 rev:10 rq:491071 version:2.1.63

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2017-04-24 09:48:03.878060110 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2017-04-28 09:13:47.721919345 +0200
@@ -4 +4 @@
-- Update to version 2.1.63:
+- Update to version 2.1.63 (bsc#1032833):
@@ -22 +22 @@
-Tue May 17 21:37:14 UTC 2016 - ldun...@suse.com
+Tue Jun 14 17:12:34 UTC 2016 - ldun...@suse.com
@@ -27 +27 @@
-Tue May 10 20:12:50 UTC 2016 - ldun...@suse.com
+Tue Jun 14 17:12:33 UTC 2016 - ldun...@suse.com
@@ -29 +29,3 @@
-- Added SPEC-file Requires for pyudev
+- Updated SPEC file:
+  * added Requires for pyudev (bsc#984563)
+  * removed BuildRequires of pyudev for doc sub-package



Other differences:
--



commit python-rtslib-fb for openSUSE:Factory

2017-04-24 Thread root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2017-04-24 09:48:03

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Mon Apr 24 09:48:03 2017 rev:9 rq:487880 version:2.1.63

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2016-06-29 15:10:36.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2017-04-24 09:48:03.878060110 +0200
@@ -1,0 +2,14 @@
+Thu Apr 13 07:11:02 UTC 2017 - h...@suse.com
+
+- Update to version 2.1.63:
+  * Get/Set LUN's ALUA group
+  * Add ALUA restore support
+  * Delete ALUA groups with its storage object
+  * version 2.1.fb62
+  * Do not set alua_tg_pt_gp if not supported
+  * Add ability to invalidate caches
+  * Add ALUA supported method
+  * Don't raise exception when getting/setting a LUNs ALUA group
+  * update to 2.1.fb63
+
+---

Old:

  rtslib-fb-2.1.fb60.tar.gz

New:

  _service
  _servicedata
  rtslib-fb-2.1.fb63.tar.xz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.lstI0T/_old  2017-04-24 09:48:04.577961119 +0200
+++ /var/tmp/diff_new_pack.lstI0T/_new  2017-04-24 09:48:04.581960554 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,20 +17,21 @@
 
 
 %define oname rtslib-fb
-%define realver 2.1.fb60
+%define realver 2.1.fb63
 
 Name:   python-%{oname}
-Version:2.1.60
-Release:1%{?dist}
-Url:http://github.com/agrover/rtslib-fb
+Version:2.1.63
+Release:0%{?dist}
+Url:http://github.com/open-iscsi/rtslib-fb.git
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Source: %{oname}-%{realver}.tar.gz
+Source: %{oname}-%{realver}.tar.xz
 Conflicts:  python-rtslib
 BuildRequires:  fdupes
 BuildRequires:  python-devel
 BuildRequires:  python-setuptools
+BuildRequires:  python-six
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
 Requires:   pyudev
 

++ _service ++

  
git
https://github.com/open-iscsi/rtslib-fb.git

rtslib-fb
2.1.fb63
v2.1.fb63
enable
  
  
*rtslib-fb*.tar
xz
  
  

++ _servicedata ++


https://github.com/open-iscsi/rtslib-fb.git
  3637171a68889e340f553943f25d6a5ca20ad1ca


commit python-rtslib-fb for openSUSE:Factory

2016-06-29 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2016-06-29 15:10:33

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2016-05-23 16:38:52.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2016-06-29 15:10:36.0 +0200
@@ -1,0 +2,6 @@
+Fri Jun 24 23:12:29 UTC 2016 - ldun...@suse.com
+
+- Updated spec file: Removed Provides/Obsoletes for python-rtslib,
+  and added Conflicts for same (bsc#986475)
+
+---



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.wpplG2/_old  2016-06-29 15:10:37.0 +0200
+++ /var/tmp/diff_new_pack.wpplG2/_new  2016-06-29 15:10:37.0 +0200
@@ -27,8 +27,7 @@
 License:Apache-2.0
 Group:  Development/Languages/Python
 Source: %{oname}-%{realver}.tar.gz
-Provides:   python-rtslib = %{version}
-Obsoletes:  python-rtslib < %{version}
+Conflicts:  python-rtslib
 BuildRequires:  fdupes
 BuildRequires:  python-devel
 BuildRequires:  python-setuptools




commit python-rtslib-fb for openSUSE:Factory

2016-05-23 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2016-05-23 16:38:50

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2016-05-13 09:24:08.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2016-05-23 16:38:52.0 +0200
@@ -1,0 +2,5 @@
+Tue May 17 21:37:14 UTC 2016 - ldun...@suse.com
+
+- Fixing build issue: removed 'noarch' from main package
+
+---



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.fIRQcL/_old  2016-05-23 16:38:52.0 +0200
+++ /var/tmp/diff_new_pack.fIRQcL/_new  2016-05-23 16:38:52.0 +0200
@@ -33,7 +33,6 @@
 BuildRequires:  python-devel
 BuildRequires:  python-setuptools
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
-BuildArch:  noarch
 Requires:   pyudev
 
 %description




commit python-rtslib-fb for openSUSE:Factory

2016-05-13 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2016-05-13 09:24:07

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2016-04-28 16:58:52.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2016-05-13 09:24:08.0 +0200
@@ -1,0 +2,5 @@
+Tue May 10 20:12:50 UTC 2016 - ldun...@suse.com
+
+- Added SPEC-file Requires for pyudev
+
+---



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.XCbOfb/_old  2016-05-13 09:24:08.0 +0200
+++ /var/tmp/diff_new_pack.XCbOfb/_new  2016-05-13 09:24:08.0 +0200
@@ -34,6 +34,7 @@
 BuildRequires:  python-setuptools
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
 BuildArch:  noarch
+Requires:   pyudev
 
 %description
 rtslib-fb is an object-based Python library for configuring the LIO generic 




commit python-rtslib-fb for openSUSE:Factory

2016-04-28 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2016-04-28 16:55:27

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is "python-rtslib-fb"

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2015-05-16 19:02:05.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2016-04-28 16:58:52.0 +0200
@@ -1,0 +2,7 @@
+Wed Apr 20 16:17:30 UTC 2016 - ldun...@suse.com
+
+- Update to version 2.1.fb60
+  * no changelog available, but git log shows 59 changes,
+some trivial
+
+---

Old:

  rtslib-fb-2.1.51.tar.gz

New:

  rtslib-fb-2.1.fb60.tar.gz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.GSvKip/_old  2016-04-28 16:58:55.0 +0200
+++ /var/tmp/diff_new_pack.GSvKip/_new  2016-04-28 16:58:55.0 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -16,42 +16,78 @@
 #
 
 
-Name:   python-rtslib-fb
-Version:2.1.51
-Release:0
+%define oname rtslib-fb
+%define realver 2.1.fb60
+
+Name:   python-%{oname}
+Version:2.1.60
+Release:1%{?dist}
+Url:http://github.com/agrover/rtslib-fb
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0
 Group:  Development/Languages/Python
-Url:http://github.com/agrover/rtslib-fb
-Source: 
https://pypi.python.org/packages/source/r/rtslib-fb/rtslib-fb-%{version}.tar.gz
+Source: %{oname}-%{realver}.tar.gz
+Provides:   python-rtslib = %{version}
+Obsoletes:  python-rtslib < %{version}
+BuildRequires:  fdupes
 BuildRequires:  python-devel
 BuildRequires:  python-setuptools
 BuildRoot:  %{_tmppath}/%{name}-%{version}-build
-%if 0%{?suse_version} && 0%{?suse_version} <= 1110
-%{!?python_sitelib: %global python_sitelib %(python -c "from 
distutils.sysconfig import get_python_lib; print get_python_lib()")}
-%else
 BuildArch:  noarch
-%endif
-# This is the "free branch" of rtslib, they share modules but have differnt 
code...
-Conflicts:  python-rtslib
 
 %description
 rtslib-fb is an object-based Python library for configuring the LIO generic 
 SCSI target, present in 3.x Linux kernel versions. rtslib-fb is licensed under
 the Apache 2.0 license. Contributions are welcome
 
+%package doc
+Summary:Documentatoin for Python rtslib-fb
+Group:  Documentation/HTML
+BuildArch:  noarch
+BuildRequires:  epydoc
+BuildRequires:  pyudev
+
+%description doc
+rtslib-fb is an object-based Python library for configuring the LIO generic 
+SCSI target, present in 3.x Linux kernel versions. rtslib-fb is licensed under
+the Apache 2.0 license. Contributions are welcome
+
 %prep
-%setup -q -n rtslib-fb-%{version}
+%setup -q -n %{oname}-%{realver}
 
 %build
-python setup.py build
+%__python setup.py build
+%__mkdir_p doc/
+epydoc --no-sourcecode --html -n %{oname} --exclude configobj rtslib_fb/*.py
+%__mv html doc/
 
 %install
-python setup.py install --prefix=%{_prefix} --root=%{buildroot}
+[ "%{buildroot}" != "/" ] && %__rm -rf %{buildroot}
+%__python setup.py install --skip-build --prefix=%{_prefix} --root=%{buildroot}
+%fdupes %{buildroot}%{python_sitelib}
+%__install -d -m755 %{buildroot}%{_defaultdocdir}/python-rtslib-doc-%{version}
+%__cp -r doc/* %{buildroot}%{_defaultdocdir}/python-rtslib-doc-%{version}/
+%fdupes %{buildroot}%{_defaultdocdir}
+%__install -d -m755 %{buildroot}%{_sysconfdir}/target
+%__install -d -m755 %{buildroot}%{_mandir}/man5
+%__install -m644 doc/saveconfig.json.5 %{buildroot}%{_mandir}/man5
+%__install -d -m755 %{buildroot}%{_mandir}/man8
+%__install -m644 doc/targetctl.8 %{buildroot}%{_mandir}/man8
+
+%clean
+[ "%{buildroot}" != "/" ] && %__rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root,-)
-/usr/bin/targetctl
+%{_bindir}/targetctl
 %{python_sitelib}/*
+%doc COPYING README.md
+%dir %{_sysconfdir}/target
+%doc %{_mandir}/man5/saveconfig.json.5.gz
+%doc %{_mandir}/man8/targetctl.8.gz
+
+%files doc
+%defattr(-,root,root,-)
+%{_defaultdocdir}/python-rtslib-doc-%{version}
 
 %changelog

++ rtslib-fb-2.1.51.tar.gz -> rtslib-fb-2.1.fb60.tar.gz ++
 2406 lines of diff (skipped)




commit python-rtslib-fb for openSUSE:Factory

2015-05-16 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2015-05-16 19:02:03

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is python-rtslib-fb

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2014-09-05 09:34:40.0 +0200
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2015-05-16 19:02:05.0 +0200
@@ -1,0 +2,6 @@
+Tue May 12 14:58:13 UTC 2015 - benoit.mo...@gmx.fr
+
+- update to version 2.1.51:
+  * no changelog available
+
+---

Old:

  rtslib-fb-2.1.49.tar.gz

New:

  rtslib-fb-2.1.51.tar.gz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.Uo6vj2/_old  2015-05-16 19:02:05.0 +0200
+++ /var/tmp/diff_new_pack.Uo6vj2/_new  2015-05-16 19:02:05.0 +0200
@@ -1,7 +1,7 @@
 #
 # spec file for package python-rtslib-fb
 #
-# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany.
+# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:   python-rtslib-fb
-Version:2.1.49
+Version:2.1.51
 Release:0
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0

++ rtslib-fb-2.1.49.tar.gz - rtslib-fb-2.1.51.tar.gz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.49/PKG-INFO 
new/rtslib-fb-2.1.51/PKG-INFO
--- old/rtslib-fb-2.1.49/PKG-INFO   2014-08-28 20:25:36.0 +0200
+++ new/rtslib-fb-2.1.51/PKG-INFO   2014-12-02 18:57:51.0 +0100
@@ -1,6 +1,6 @@
 Metadata-Version: 1.0
 Name: rtslib-fb
-Version: 2.1.49
+Version: 2.1.51
 Summary: API for Linux kernel SCSI target (aka LIO)
 Home-page: http://github.com/agrover/rtslib-fb
 Author: Andy Grover
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.49/rtslib/__init__.py 
new/rtslib-fb-2.1.51/rtslib/__init__.py
--- old/rtslib-fb-2.1.49/rtslib/__init__.py 2014-08-28 20:14:27.0 
+0200
+++ new/rtslib-fb-2.1.51/rtslib/__init__.py 2014-12-02 18:29:22.0 
+0100
@@ -24,7 +24,7 @@
 from fabric import FabricModule
 
 from tcm import FileIOStorageObject, BlockStorageObject
-from tcm import PSCSIStorageObject, RDMCPStorageObject
+from tcm import PSCSIStorageObject, RDMCPStorageObject, UserBackedStorageObject
 from tcm import StorageObjectFactory
 
 __version__ = 'GIT_VERSION'
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.49/rtslib/fabric.py 
new/rtslib-fb-2.1.51/rtslib/fabric.py
--- old/rtslib-fb-2.1.49/rtslib/fabric.py   2014-08-08 00:26:19.0 
+0200
+++ new/rtslib-fb-2.1.51/rtslib/fabric.py   2014-12-02 18:29:22.0 
+0100
@@ -176,7 +176,7 @@
 if os.path.isfile(path):
 return fread(path)
 else:
-raise RTSLibError(Can't find version for fabric module %s.
+raise RTSLibError(Can't find version for fabric module %s
   % self.name)
 else:
 return None
@@ -214,8 +214,8 @@
 
 def _assert_feature(self, feature):
 if not self.has_feature(feature):
-raise RTSLibError(This fabric module does not implement 
-  + the %s feature. % feature)
+raise RTSLibError(Fabric module %s does not implement 
+  + the %s feature % (self.name, feature))
 
 def clear_discovery_auth_settings(self):
 self._check_self()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.49/rtslib/node.py 
new/rtslib-fb-2.1.51/rtslib/node.py
--- old/rtslib-fb-2.1.49/rtslib/node.py 2014-08-08 00:26:19.0 +0200
+++ new/rtslib-fb-2.1.51/rtslib/node.py 2014-11-21 00:56:58.0 +0100
@@ -33,6 +33,12 @@
 def __init__(self):
 self._path = self.configfs_dir
 
+def __eq__(self, other):
+return self._path == other._path
+
+def __ne__(self, other):
+return self._path != other._path
+
 def _get_path(self):
 return self._path
 
@@ -47,17 +53,17 @@
 if mode not in ['any', 'lookup', 'create']:
 raise RTSLibError(Invalid mode: %s % mode)
 if self.exists and mode == 'create':
-raise 

commit python-rtslib-fb for openSUSE:Factory

2014-09-05 Thread h_root
Hello community,

here is the log from the commit of package python-rtslib-fb for 
openSUSE:Factory checked in at 2014-09-05 09:34:19

Comparing /work/SRC/openSUSE:Factory/python-rtslib-fb (Old)
 and  /work/SRC/openSUSE:Factory/.python-rtslib-fb.new (New)


Package is python-rtslib-fb

Changes:

--- /work/SRC/openSUSE:Factory/python-rtslib-fb/python-rtslib-fb.changes
2014-01-23 15:54:44.0 +0100
+++ /work/SRC/openSUSE:Factory/.python-rtslib-fb.new/python-rtslib-fb.changes   
2014-09-05 09:34:40.0 +0200
@@ -1,0 +2,16 @@
+Wed Sep  3 12:01:09 UTC 2014 - dmuel...@suse.com
+
+- update to 2.1.49:
+  * Improve error message when NetworkPortal restore fails
+  * Python 3.x porting fixes
+  * targetctl: A missing restore file is not an error 
+  * Add a message if no configfile is found
+  * Add StorageObjectFactory
+  * Convert all exceptions in set_parameter/attribute to RTSLibError
+  * Change set_parameters/attributes to take an err_func
+  * Fix missing err_func parameter to set_attributes 
+  * '!' allowed character in block and partition names 
+  * Don't add to cache if cfs create fails 
+  * Don't lower-case return values from _parse_info functions 
+
+---

Old:

  rtslib-fb-2.1.43.tar.gz

New:

  rtslib-fb-2.1.49.tar.gz



Other differences:
--
++ python-rtslib-fb.spec ++
--- /var/tmp/diff_new_pack.bkn1H1/_old  2014-09-05 09:34:41.0 +0200
+++ /var/tmp/diff_new_pack.bkn1H1/_new  2014-09-05 09:34:41.0 +0200
@@ -17,7 +17,7 @@
 
 
 Name:   python-rtslib-fb
-Version:2.1.43
+Version:2.1.49
 Release:0
 Summary:API for Linux kernel SCSI target (aka LIO)
 License:Apache-2.0

++ rtslib-fb-2.1.43.tar.gz - rtslib-fb-2.1.49.tar.gz ++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.43/PKG-INFO 
new/rtslib-fb-2.1.49/PKG-INFO
--- old/rtslib-fb-2.1.43/PKG-INFO   2013-12-04 18:24:20.0 +0100
+++ new/rtslib-fb-2.1.49/PKG-INFO   2014-08-28 20:25:36.0 +0200
@@ -1,6 +1,6 @@
 Metadata-Version: 1.0
 Name: rtslib-fb
-Version: 2.1.43
+Version: 2.1.49
 Summary: API for Linux kernel SCSI target (aka LIO)
 Home-page: http://github.com/agrover/rtslib-fb
 Author: Andy Grover
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.43/rtslib/__init__.py 
new/rtslib-fb-2.1.49/rtslib/__init__.py
--- old/rtslib-fb-2.1.43/rtslib/__init__.py 2013-11-08 01:21:56.0 
+0100
+++ new/rtslib-fb-2.1.49/rtslib/__init__.py 2014-08-28 20:14:27.0 
+0200
@@ -1,6 +1,7 @@
 '''
 This file is part of RTSLib.
 Copyright (c) 2011-2013 by Datera, Inc
+Copyright (c) 2011-2014 by Red Hat, Inc.
 
 Licensed under the Apache License, Version 2.0 (the License); you may
 not use this file except in compliance with the License. You may obtain
@@ -24,6 +25,7 @@
 
 from tcm import FileIOStorageObject, BlockStorageObject
 from tcm import PSCSIStorageObject, RDMCPStorageObject
+from tcm import StorageObjectFactory
 
 __version__ = 'GIT_VERSION'
 __author__ = Jerome Martin j...@risingtidesystems.com
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/rtslib-fb-2.1.43/rtslib/fabric.py 
new/rtslib-fb-2.1.49/rtslib/fabric.py
--- old/rtslib-fb-2.1.43/rtslib/fabric.py   2013-11-20 20:39:46.0 
+0100
+++ new/rtslib-fb-2.1.49/rtslib/fabric.py   2014-08-08 00:26:19.0 
+0200
@@ -1,7 +1,7 @@
 '''
 This file is part of RTSLib.
 Copyright (c) 2011-2013 by Datera, Inc
-Copyright (c) 2013 by Andy Grover
+Copyright (c) 2011-2014 by Red Hat, Inc.
 
 Licensed under the Apache License, Version 2.0 (the License); you may
 not use this file except in compliance with the License. You may obtain
@@ -187,7 +187,7 @@
 according to the spec, and returns a tuple of our preferred string 
 representation of the wwn, and what type it turned out to be.
 '''
-return normalize_wwn(self.wwn_types, wwn, self.wwns)
+return normalize_wwn(self.wwn_types, wwn)
 
 def to_fabric_wwn(self, wwn):
 '''
@@ -198,7 +198,10 @@
 
 def from_fabric_wwn(self, wwn):
 '''
-see to_fabric_wwn.
+Converts from WWN format used in this fabric's LIO configfs to 
canonical
+format.
+Note: Do not call from wwns(). There's no guarantee fabric wwn format 
is
+the same as wherever wwns() is reading from.
 '''
 return wwn
 
@@ -347,10 +350,7 @@
 for fname in glob(/sys/bus/firewire/devices/fw*/is_local):
 if bool(int(fread(fname))):
 guid_path =