[Openvpn-devel] [PATCH v2 4/9] client-connect: Move multi_client_connect_setenv into early_setup

2015-01-17 Thread Fabian Knittel
This patch moves multi_client_connect_setenv into multi_client_connect_early_setup and makes sure that every client-connect handling function updates the virtual address selection. Background: This unifies how the client-connect handling functions work. Signed-off-by: Fabian Knittel --- src/ope

[Openvpn-devel] [PATCH v2 7/9] client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect

2015-01-17 Thread Fabian Knittel
This patch moves the state, that was previously tracked within the multi_connection_established() function, into struct client_connect_state. The multi_connection_established() function can now be exited and re-entered as many times as necessary - without losing the client-connect handling state.

[Openvpn-devel] [PATCH v2 3/9] client-connect: Refactor multi_client_connect_source_ccd

2015-01-17 Thread Fabian Knittel
Refactor multi_client_connect_source_ccd(), so that options_server_import() (or the success path in general) is only entered in one place within the function. Signed-off-by: Fabian Knittel --- src/openvpn/multi.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(

[Openvpn-devel] [PATCH v2 5/9] client-connect: Refactor to use return values instead of modifying a passed-in flag

2015-01-17 Thread Fabian Knittel
This patch changes the way the client-connect helper functions communicate with the main function. Instead of updating cc_succeeded and cc_succeeded_count, they now return either CC_RET_SUCCEEDED, CC_RET_FAILED or CC_RET_SKIPPED. In addition, the client-connect helpers are now called in completel

[Openvpn-devel] [PATCH v2 8/9] client-connect: Add deferred support to the client-connect script handler

2015-01-17 Thread Fabian Knittel
This patch introduces the concept of a return value file for the client-connect handlers. (This is very similar to the auth value file used during deferred authentication.) The file name is stored in the client_connect_state struct. In addition, the patch also allows the storage of the client con

[Openvpn-devel] [PATCH v2 9/9] client-connect: Add deferred support to the client-connect plugin v1 handler

2015-01-17 Thread Fabian Knittel
Uses the infrastructure provided and used in the previous patch to provide deferral support to the v1 client-connect plugin handler as well. Signed-off-by: Fabian Knittel --- src/openvpn/multi.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git

[Openvpn-devel] [PATCH v2 2/9] client-connect: Properly indent all functions

2015-01-17 Thread Fabian Knittel
This patch adds proper indentation to all new helper functions. No functional changes are performed. Nothing is moved around. Signed-off-by: Fabian Knittel --- src/openvpn/multi.c | 408 ++-- 1 file changed, 204 insertions(+), 204 deletions(-) d

[Openvpn-devel] [PATCH v2 6/9] client-connect: Refactor client-connect handling to calling a bunch of hooks in a loop

2015-01-17 Thread Fabian Knittel
This patch changes the calling of the client-connect functions into an array of hooks and a block of code that calls them in a loop. Signed-off-by: Fabian Knittel --- src/openvpn/multi.c | 57 +++-- 1 file changed, 16 insertions(+), 41 deletions(-)

[Openvpn-devel] [PATCH v2 1/9] client-connect: Split multi_connection_established into separate functions

2015-01-17 Thread Fabian Knittel
This patch splits up the multi_connection_established() function. Each new helper function does a specific job. Functions that do a similar job receive a similar calling interface. The patch tries not to reindent code, so that the real changes are as clearly visible as possible. (A follow-up pa

[Openvpn-devel] [PATCH v2 0/9] Refactor client-connect / add support for deferred handling

2015-01-17 Thread Fabian Knittel
Hi, changes from v1: - rebased to the current master, - reports errors during file delete Introduction to the patch-set: A few years ago I wrote a patch-set concerning OpenVPN's client-connect code. The first part of the patch-set (patches 1 to 6) refactors and unifies the client-connect code

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Gert Doering
Hi, On Sat, Jan 17, 2015 at 01:00:13PM +0100, Arne Schwabe wrote: > On 17.01.2015 12:56, ?? wrote: > > have a look at wire speed of tap adapter, https://yadi.sk/i/zz4WbnOHe3hJf > > I see 10mb > We could easily patch that to say 100 GBit/s and it would not change > anything :)

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Arne Schwabe
On 17.01.2015 12:56, Илья Шипицин wrote: > have a look at wire speed of tap adapter, https://yadi.sk/i/zz4WbnOHe3hJf > I see 10mb > > We could easily patch that to say 100 GBit/s and it would not change anything :) Arne

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Илья Шипицин
have a look at wire speed of tap adapter, https://yadi.sk/i/zz4WbnOHe3hJf I see 10mb 2015-01-17 0:02 GMT+05:00 Dan Moulding : > Hello all, > > I have been extensively testing OpenVPN recently, for potential deployment > with some other systems I have been developing. One thing I have noticed >

Re: [Openvpn-devel] Windows TAP driver profiling

2015-01-17 Thread Gert Doering
Hiya, On Fri, Jan 16, 2015 at 12:02:10PM -0700, Dan Moulding wrote: > I have been extensively testing OpenVPN recently, for potential > deployment with some other systems I have been developing. One > thing I have noticed during this testing is that performance of > Windows clients connected to a