Re: [Openvpn-devel] [PATCH v2] Drop recursively routed packets

2016-08-07 Thread ValdikSS
Tested on Windows 10 and Linux. Works as intended. I've connected to the VPN which redirects the gateway and physically unplugged Ethernet cable. Git version started to consume 100% CPU while patched version either doesn't consume CPU and doesn't print anything or doesn't consume CPU and print

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread Selva Nair
Hi, On Sun, Aug 7, 2016 at 8:55 AM, Илья Шипицин wrote: > I also noticed, that "openvpn administrators" membership is required. > > Should we modify installer to make it adf current user to that group? > With multiple users on a system, the installer will have to choose

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread Selva Nair
On Sun, Aug 7, 2016 at 8:55 AM, debbie10t wrote: > On 07/08/16 13:46, debbie10t wrote: > > > > > > On 05/08/16 03:04, Selva Nair wrote: > >> On Thu, Aug 4, 2016 at 6:53 PM, debbie10t wrote: > >> > >>> Hi > >>> > >>> So windows 10 as a Server. > > I

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-07 Thread Selva Nair
Hi, On Sun, Aug 7, 2016 at 10:04 AM, Steffan Karger wrote: > On 5 August 2016 at 15:09, Selva Nair wrote: > > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger > wrote: > >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering

Re: [Openvpn-devel] [PATCH] Avoid format specifier %zu for Windows compatibility

2016-08-07 Thread Steffan Karger
On 5 August 2016 at 15:09, Selva Nair wrote: > On Fri, Aug 5, 2016 at 3:32 AM, Steffan Karger wrote: >> On Fri, Aug 5, 2016 at 8:14 AM, Gert Doering wrote: >> > On Thu, Aug 04, 2016 at 11:39:54PM -0400, Selva Nair wrote: >> >> -

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread Илья Шипицин
I also noticed, that "openvpn administrators" membership is required. Should we modify installer to make it adf current user to that group? 7 авг. 2016 г. 17:48 пользователь "debbie10t" написал: > > > On 05/08/16 03:04, Selva Nair wrote: > > On Thu, Aug 4, 2016 at 6:53 PM,

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread debbie10t
On 07/08/16 13:46, debbie10t wrote: On 05/08/16 03:04, Selva Nair wrote: On Thu, Aug 4, 2016 at 6:53 PM, debbie10t wrote: Hi So windows 10 as a Server. I should also mention finding this odd error in the log: WARNING: 'link-mtu' is used inconsistently,

Re: [Openvpn-devel] Win10 Tun Server +Standard W10 User +OVPN Interactive Service +OVPN GUI

2016-08-07 Thread debbie10t
On 05/08/16 03:04, Selva Nair wrote: On Thu, Aug 4, 2016 at 6:53 PM, debbie10t wrote: Hi So windows 10 as a Server. If you have any specific tests please send me details. Tasks needing admin access happens early on when the server starts so this looks good

[Openvpn-devel] [PATCH 2/3] Do not pass env for system commands on Windows

2016-08-07 Thread ValdikSS
--- src/openvpn/route.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index c327866..822d02b 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1487,7 +1487,7 @@ add_route (struct route_ipv4 *r, else if

[Openvpn-devel] [PATCH 1/3] Do not pass env for system commands on Linux

2016-08-07 Thread ValdikSS
It's possible to have so much routes that they won't fit into stack and execve would fail with E2BIG (Argument list too long). This commit fixes this issue by not adding route information into execve'd application env. --- src/openvpn/lladdr.c | 2 +- src/openvpn/route.c | 8

[Openvpn-devel] [PATCH 3/3] Do not pass env for system commands on OS X

2016-08-07 Thread ValdikSS
--- src/openvpn/route.c | 8 src/openvpn/tun.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 822d02b..c1ce7fd 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1601,7 +1601,7 @@ add_route (struct