Re: [Openvpn-devel] [PATCH v2] reformatting: fix style in crypto*.{c, h}

2016-12-21 Thread Selva Nair
On Wed, Dec 21, 2016 at 4:09 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > > Hmmm ... I like that we're trying to clean up the formatting further. > But I'm not too happy that uncrustify seems to disagree slightly ... > See the attached patch what happened after applying your

Re: [Openvpn-devel] [PATCH v2] reformatting: fix style in crypto*.{c, h}

2016-12-21 Thread Steffan Karger
Hi, On 21 December 2016 at 22:09, David Sommerseth wrote: > On 18/12/16 19:26, Steffan Karger wrote: >> Now that we have touched each and every file anyway, I decided to go over >> the code I regularly work with and reformat it some more by hand. This is >>

Re: [Openvpn-devel] [PATCH release/2.4] Update copyrights

2016-12-21 Thread Christian Hesse
David Sommerseth on Wed, 2016/12/21 21:00: > Signed-off-by: David Sommerseth As we will (hopefully) see a release in 2016... Does it make sense to update to 2017? -- main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"

Re: [Openvpn-devel] [PATCH release/2.3] docs: Further improve --reneg-bytes and SWEET32 information

2016-12-21 Thread Steffan Karger
Hi, On 21 December 2016 at 21:54, David Sommerseth wrote: > +If using ciphers with cipher block sizes less than 128-bits, > \-\-reneg\-bytes is > +set to 64MB by default, unless it is explicitly disabled by setting the > value to > +0,but this is (As in the patch for

Re: [Openvpn-devel] [PATCH master+v2.4] docs: Further enhance the documentation related to SWEET32

2016-12-21 Thread Steffan Karger
Hi, On 21 December 2016 at 21:54, David Sommerseth wrote: > User-visible Changes > > +- When using ciphers with cipher blocks less than 128-bits > + OpenVPN will complain loudly if the configuration uses ciphers considered > + weak, such as the

Re: [Openvpn-devel] [PATCH 1/1] do not race on RuntimeDirectory

2016-12-21 Thread Christian Hesse
debbie10t on Tue, 2016/12/20 00:32: > On 16/12/16 15:57, Christian Hesse wrote: > > From: Christian Hesse > > > > Different unit instances create and destroy the same RuntimeDirectory. > > This leads to running instances where the status file (and possibly > >

Re: [Openvpn-devel] [PATCH v2] reformatting: fix style in crypto*.{c, h}

2016-12-21 Thread David Sommerseth
On 18/12/16 19:26, Steffan Karger wrote: > Now that we have touched each and every file anyway, I decided to go over > the code I regularly work with and reformat it some more by hand. This is > how for I got today, and is a large enough patch I think. > > This commit is mostly just reordering

Re: [Openvpn-devel] [PATCH applied] Bump master to version 2.5_git

2016-12-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit e1dd49a38875909bda218c0c3f772e791681ac36 Author: Steffan Karger Date: Sun Dec 18 17:38:15 2016 +0100 Bump master to version 2.5_git Signed-off-by: Steffan Karger

Re: [Openvpn-devel] [PATCH applied] Update copyrights

2016-12-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the release/2.3 branch. commit 782c95330b630c3823418a7867fcc1763d3f103f Author: David Sommerseth Date: Wed Dec 21 21:00:53 2016 +0100 Update copyrights Signed-off-by: David Sommerseth

Re: [Openvpn-devel] [PATCH applied] Update copyrights

2016-12-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the master branch. commit 58716979640b5d8850b39820f91da616964398cc Author: David Sommerseth Date: Wed Dec 21 21:00:52 2016 +0100 Update copyrights Signed-off-by: David Sommerseth

Re: [Openvpn-devel] [PATCH applied] Update copyrights

2016-12-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Your patch has been applied to the release/2.4 branch. commit a0006fa431d2109a55ecc741a34510aea00dd608 Author: David Sommerseth Date: Wed Dec 21 21:00:54 2016 +0100 Update copyrights Signed-off-by: David Sommerseth

[Openvpn-devel] [PATCH] Improve documentation related to SWEET32 and --reneg-bytes

2016-12-21 Thread David Sommerseth
There have been several support questions related to the enforced renegotiation happening in OpenVPN v2.3.13. This will also be visible to users when they upgrade to v2.4.0. These patches updates both master (including release/2.4) and release/2.3 branches with additional details to hopefully

[Openvpn-devel] [PATCH release/2.3] docs: Further improve --reneg-bytes and SWEET32 information

2016-12-21 Thread David Sommerseth
There are still some support tickets related to SWEET32 and our defult enforced --reneg-bytes 64 when using weaker ciphers (less than 128-bits cipher blocks). Try to clarify this even more. Also fix a few mistakes, saying less than 128-bits and not 128-bits and less. Signed-off-by: David

[Openvpn-devel] [PATCH master+v2.4] docs: Further enhance the documentation related to SWEET32

2016-12-21 Thread David Sommerseth
The git master/2.4 code lacked some useful information about the changes to --reneg-bytes, SWEET32 and weak ciphers (less than 128-bits cipher blocks) Signed-off-by: David Sommerseth --- Changes.rst | 6 ++ doc/openvpn.8 | 13 ++--- 2 files changed, 16

Re: [Openvpn-devel] [PATCH master] Update copyrights

2016-12-21 Thread Steffan Karger
Hi, On 21-12-16 21:00, David Sommerseth wrote: > Signed-off-by: David Sommerseth > --- > COPYING | 2 +- > ChangeLog | 2 +- > Makefile.am

Re: [Openvpn-devel] [PATCH release/2.3] Update copyrights

2016-12-21 Thread Steffan Karger
Hi, On 21-12-16 21:00, David Sommerseth wrote: > Signed-off-by: David Sommerseth > --- > COPYING| 2 +- > ChangeLog | 2 +- > Makefile.am| 2 +- > PORTS

Re: [Openvpn-devel] [PATCH release/2.4] Update copyrights

2016-12-21 Thread Steffan Karger
Hi, On 21-12-16 21:00, David Sommerseth wrote: > Signed-off-by: David Sommerseth > --- > COPYING | 2 +- > ChangeLog | 2 +- > Makefile.am

[Openvpn-devel] [PATCH release/2.3] Update copyrights

2016-12-21 Thread David Sommerseth
Signed-off-by: David Sommerseth --- COPYING| 2 +- ChangeLog | 2 +- Makefile.am| 2 +- PORTS | 2 +- build/Makefile.am | 2 +-

[Openvpn-devel] [PATCH release/2.4] Update copyrights

2016-12-21 Thread David Sommerseth
Signed-off-by: David Sommerseth --- COPYING | 2 +- ChangeLog | 2 +- Makefile.am | 2 +- PORTS

[Openvpn-devel] [PATCH] Update copyrights

2016-12-21 Thread David Sommerseth
These patches updates the copyright lines with an updated year. The result is generated by the ./dev-tools/update-copyright.sh script. -- kind regards, David Sommerseth OpenVPN Technologies, Inc -- Developer Access

[Openvpn-devel] [PATCH master] Update copyrights

2016-12-21 Thread David Sommerseth
Signed-off-by: David Sommerseth --- COPYING | 2 +- ChangeLog | 2 +- Makefile.am | 2 +- PORTS

Re: [Openvpn-devel] [PATCH applied] dev-tools: Added script for updating copyright years in files

2016-12-21 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've done a quick update to the patch at commit time. As suggested by Steffan, I've changed from excluding cmocka to exclude vendor/. In addition @sophos.com copyright lines will also be included in this update. If anyone else wants to be included

Re: [Openvpn-devel] Google Summer of Code

2016-12-21 Thread Matthias Andree
Am 19.12.2016 um 11:01 schrieb Илья Шипицин: > > it seems, it depends on network-manager version. > on fedora 23 I cannot import files, but on ubuntu I can. Fedora 23 goes out of support these days (it's now more than 4 weeks after Fedora 25 release), so it's time to upgrade...