[Openvpn-devel] [PATCH v2] pf: clean up temporary files if plugin init fails

close_instance() tries to remove the file in c2.pf.filename, but that only works if we actually set that if we fail. So, set that filename as soon as we know we've created the file. Signed-off-by: Steffan Karger --- v2: As suggested by Antionio, get rid of local 'gc' and 'file' vars. src/openv

[Openvpn-devel] [PATCH] Check whether in pull_mode before warning about previous connection blocks

From: Selva Nair Eliminate the confusing message that says "explicit-exit-notify is ignored by previous blocks" when the option is pushed. Reported by: Eike Lohmann e.lohm...@ic3s.de https://www.mail-archive.com/openvpn-users@lists.sourceforge.net/msg04052.html Signed-off-by: Selva Nair --- s

Re: [Openvpn-devel] [PATCH 2/2] pf: clean up temporary files if plugin init fails

Hi, On 15/09/17 05:34, Steffan Karger wrote: > close_instance() tries to remove the file in c2.pf.filename, but that only > works if we actually set that if we fail. So, set that filename as soon > as we know we've created the file. > > Signed-off-by: Steffan Karger > --- > src/openvpn/pf.c |

Re: [Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

I just did a quick skim for now and I only have a codestyle comment below: On 15/09/17 05:34, Steffan Karger wrote: > This function is called in response to connecting clients, and can fail > when I/O fails for some (possibly temporary) reason. In such cases we > should not exit the process, but

[Openvpn-devel] [PATCH 2/2] pf: clean up temporary files if plugin init fails

close_instance() tries to remove the file in c2.pf.filename, but that only works if we actually set that if we fail. So, set that filename as soon as we know we've created the file. Signed-off-by: Steffan Karger --- src/openvpn/pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Openvpn-devel] [PATCH 1/2] Don't throw fatal errors from create_temp_file()

This function is called in response to connecting clients, and can fail when I/O fails for some (possibly temporary) reason. In such cases we should not exit the process, but just reject the connecting client. This commit changes the function to actually return NULL on errors, and (where needed)

[Openvpn-devel] Better error recognition and error/status reporting to the mgmt i/f

Hi, Quoting from the meeting logs: > Discussed having more fine-grained signalling from OpenVPN to OpenVPN > GUI. The lack of clear signals from OpenVPN to OpenVPN GUI has been a > rather common problem: > > >

Re: [Openvpn-devel] [openvpn-devel] Forum upgrade problems

I will look into these. I'm surprised [oconf] is broken, since I wrote that myself and it is not a normal part of phpBB. Eric Crist > On Sep 14, 2017, at 6:36 AM, fragmentux wrote: > > The forum upgrade has broken the following BBCodes. > > 1. [quote="Name"] > "Name" is no longer shown. > >

Re: [Openvpn-devel] how to roll your own OpenVPN Windows installer

Hi all, On 11/09/17 09:06, Samuli Seppänen wrote: Il 08/09/2017 13:10, Jan Just Keijser ha scritto: hi dev list, someone asked me this question: how can one roll their own Windows OpenVPN installer, including a signed TAP driver? There's no need to rebuild OpenVPN or the TAP driver, but they

[Openvpn-devel] [openvpn-devel] Forum upgrade problems

The forum upgrade has broken the following BBCodes. 1. [quote="Name"] "Name" is no longer shown. 2. [code] Appears to strip out all newline / CRLF. 3. [oconf=x] Appears to strip off last line. 4. [list] Always inserts a bullet point even if no [*] is used. --