Re: [Openvpn-devel] [PATCH] Enable extra compiler warnings by default

2018-01-25 Thread Selva Nair
Hi, On Sun, Jan 21, 2018 at 4:17 AM, Steffan Karger wrote: > Hi, > > On 21-01-18 06:37, Selva Nair wrote: >> >> On Sat, Jan 20, 2018 at 11:41 AM, Steffan Karger wrote: >>> >>> This by default enables the compiler warnings any could previously >>> enable using the --enable-strict configure option

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

2018-01-25 Thread Selva Nair
Hi, On Thu, Jan 25, 2018 at 6:01 PM, David Sommerseth wrote: > On 25/01/18 19:46, Selva Nair wrote: >> Hi, >> >> On Thu, Jan 25, 2018 at 1:36 PM, Jonathan K. Bullard >> wrote: >>> Hi. >>> >>> On Mon, Jan 22, 2018 at 12:31 PM, Selva Nair wrote: What about extending the current "version" com

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

2018-01-25 Thread David Sommerseth
On 25/01/18 19:46, Selva Nair wrote: > Hi, > > On Thu, Jan 25, 2018 at 1:36 PM, Jonathan K. Bullard > wrote: >> Hi. >> >> On Mon, Jan 22, 2018 at 12:31 PM, Selva Nair wrote: >>> What about extending the current "version" command with an argument >>> where the client states the version of "manage

Re: [Openvpn-devel] [PATCH 3/3] Document management request >ECDSA_SIGN and response ecdsa-sig

2018-01-25 Thread Selva Nair
Hi, On Sun, Jan 14, 2018 at 2:44 PM, wrote: > From: Selva Nair > > Signed-off-by: Selva Nair > --- > doc/management-notes.txt | 30 ++ > 1 file changed, 30 insertions(+) > Documentation changes are now handled in the management client version patches and v3 of ecd

[Openvpn-devel] [PATCH v3 2/3] Allow external EC key through --management-external-key

2018-01-25 Thread selva . nair
From: Selva Nair - This automatically supports EC certificates through --management-external-cert - EC signature request from management is prompted by >PK_SIGN if the client supports it (or >RSA_SIGN) Response should be of the form 'pk-sig' (or rsa-sig by older clients) followed by DER e

[Openvpn-devel] [PATCH 2/2] Prompt for signature using '>PK_SIGN' if the client supports it

2018-01-25 Thread selva . nair
From: Selva Nair - Increase the management version from 1 to 2 - If the client announces support for management version > 1 prompt for signature using >PK_SIGN to which the client responds using 'pk-sig' Older (current) clients will be continued to be prompted by '>RSA_SIGN' and can respo

[Openvpn-devel] [PATCH 1/2] Add management client version

2018-01-25 Thread selva . nair
From: Selva Nair - "version" command from client to management can now set the version of management interface supported by the client by specifying an optional integer parameter. If no parameter is specified the version of OpenVPN and its management interface is returned (current behavi

Re: [Openvpn-devel] [PATCH 2/3] Allow external EC key through --management-external-key

2018-01-25 Thread Selva Nair
Hi, On Thu, Jan 25, 2018 at 1:36 PM, Jonathan K. Bullard wrote: > Hi. > > On Mon, Jan 22, 2018 at 12:31 PM, Selva Nair wrote: >> What about extending the current "version" command with an argument >> where the client states the version of "management-speak" that it >> supports. Current managemen

[Openvpn-devel] Fwd: [PATCH 2/3] Allow external EC key through --management-external-key

2018-01-25 Thread Jonathan K. Bullard
Hi. On Mon, Jan 22, 2018 at 12:31 PM, Selva Nair wrote: > What about extending the current "version" command with an argument > where the client states the version of "management-speak" that it > supports. Current management version is 1, we increase it to 1.1 and > unless the client says "versio

Re: [Openvpn-devel] [PATCH applied] Re: TLS v1.2 support for cryptoapicert -- RSA only

2018-01-25 Thread Selva Nair
Hi, On Thu, Jan 25, 2018 at 12:00 PM, Steffan Karger wrote: > On 25-01-18 16:14, Selva Nair wrote: >> A more useful thing to do is to catch the case of user setting min = >> 1.2 (as in trac 977) and we changing max to 1.1 when key is in a >> legacy key store. That would cause a handshake failure

Re: [Openvpn-devel] [PATCH applied] Re: TLS v1.2 support for cryptoapicert -- RSA only

2018-01-25 Thread Steffan Karger
On 25-01-18 16:14, Selva Nair wrote: > A more useful thing to do is to catch the case of user setting min = > 1.2 (as in trac 977) and we changing max to 1.1 when key is in a > legacy key store. That would cause a handshake failure with a cryptic > error. Better to catch early with a helpful warnin

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

2018-01-25 Thread Gert Doering
Hi, On Wed, Dec 06, 2017 at 05:10:45PM +, Simon Rozman wrote: > > > The get_interface_metric() function should get a more thorough rewrite > > than just a compiler warning shut-up. So the patch will probably get divided > > in two - the simple signed/unsigned fixes and get_interface_metric() >

Re: [Openvpn-devel] [PATCH applied] Re: TLS v1.2 support for cryptoapicert -- RSA only

2018-01-25 Thread Selva Nair
Hi, On Thu, Jan 25, 2018 at 6:18 AM, Gert Doering wrote: > Your patch has been applied to the master and release/2.4 branch. > > I have tested on unix (where it obviously did not make a difference), > compile-tested on my old ubuntu 14.04 build environment (fails with > CERT_NCRYPT_KEY_SPEC not

[Openvpn-devel] [PATCH applied] Re: Refactor get_interface_metric to return metric and auto flag separately

2018-01-25 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. Sorry for taking so long. Test built on my new and shiny ubuntu 16.04 test rig :-) commit 4229243563bcb22990f71d50e25be9ea6d44f519 (master) commit 92b4c0e96f797775df18269bc7295dc163688cb4 (release/2.4) Author: Selva Nair Date: T

[Openvpn-devel] [PATCH applied] Re: Refactor ssl_openssl.c in prep for external EC key support

2018-01-25 Thread Gert Doering
Your patch has been applied to the master branch. For the time being, I've decided to follow the rule "refactoring and new features go to master", and since this "refactoring in preparation for a new feature" (EC external key), it falls under this rule. If there's good arguments we should have it

[Openvpn-devel] [PATCH applied] Re: Plug memory leak if push is interrupted

2018-01-25 Thread Gert Doering
ACK. Makes sense. The changes to crypto_mbedtls.c match the documentation for the mbedtls md functions, and the rest is just basic "if you make it, clean it up later on again" :-) - lightly tested ("t_client"), too lazy to come up with a test rig to trigger and truly test this. Your patch has b

[Openvpn-devel] [PATCH applied] Re: Document missing OpenVPN states

2018-01-25 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. commit 12b12ff944a378dbb14cc508f887191303b24703 (master) commit e10f32174cf17b77896fc92744974352a3ee1874 (release/2.4) Author: Simon Rozman Date: Mon Jan 15 12:47:28 2018 +0100 Document missing OpenVPN states Acked-by:

[Openvpn-devel] [PATCH applied] Re: TLS v1.2 support for cryptoapicert -- RSA only

2018-01-25 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. I have tested on unix (where it obviously did not make a difference), compile-tested on my old ubuntu 14.04 build environment (fails with CERT_NCRYPT_KEY_SPEC not being defined, because mingw *there* needs "_WIN32_WINNT >= 0x0601"

[Openvpn-devel] [PATCH applied] Re: Add SSL_CTX_get_max_proto_version() not in openssl 1.0

2018-01-25 Thread Gert Doering
ACK. Same code as in master (+ifdef), compile-tested with 1.0.1 and 0.9.8 Your patch has been applied to the release/2.4 branch. commit 51ab66a52b9b12402495274bc7070d0b9a2ebde6 Author: Selva Nair Date: Sat Jan 20 12:11:34 2018 -0500 Add SSL_CTX_get_max_proto_version() not in openssl 1.0