Re: [Openvpn-devel] [PATCH 1/2] plugin: Export base64 encode and decode functions

2018-07-31 Thread Selva Nair
Hi, Now that the minor "fix" for plugin header seems settled, back to the base64 export patch from David. On Fri, May 5, 2017 at 5:46 PM, David Sommerseth wrote: > This patch builds on the "Export secure_memzero() to plug-ins" patch and > adds export of openvpn_base64_encode() and

Re: [Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

2018-07-31 Thread Gert Doering
Hi, On Wed, Aug 01, 2018 at 01:21:35AM +0800, Antonio Quartulli wrote: > On 21/11/17 09:43, selva.n...@gmail.com wrote: > > From: Selva Nair > > > > - This is an opaque pointer so the change should not affect > > existing plugins. But it makes the code consistent and clears up > > the

Re: [Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return'

2018-07-31 Thread Antonio Quartulli
Hi, On 21/11/17 09:43, selva.n...@gmail.com wrote: > From: Selva Nair > > - This is an opaque pointer so the change should not affect > existing plugins. But it makes the code consistent and clears up > the documentation as the handle pointer is treated as of type >

Re: [Openvpn-devel] [PATCH v3] Parse static challenge response in auth-pam plugin

2018-07-31 Thread Selva Nair
HI On Tue, Jul 31, 2018 at 3:07 AM, David Sommerseth wrote: > On 30/07/18 16:58, Selva Nair wrote: >> Hi, >> >> On Mon, Jul 30, 2018 at 10:31 AM, Antonio Quartulli wrote: >>> Hi, >>> >>> On 30/07/18 04:16, Selva Nair wrote: Yes that's the base64 patch. What is stopping it is not the

[Openvpn-devel] [PATCH] Clarify and expand management interface documentation

2018-07-31 Thread Jonathan K. Bullard via Openvpn-devel
Clarify and expand the documentation for the management interface: * Add examples of static and dynamic challenge/response sequences in the "COMMAND -- password and username" section. * Expand the "Challenge/Response" section with more detail. * Use "management interface client" throughout

Re: [Openvpn-devel] [PATCH v3] Parse static challenge response in auth-pam plugin

2018-07-31 Thread David Sommerseth
On 30/07/18 16:58, Selva Nair wrote: > Hi, > > On Mon, Jul 30, 2018 at 10:31 AM, Antonio Quartulli wrote: >> Hi, >> >> On 30/07/18 04:16, Selva Nair wrote: >>> Yes that's the base64 patch. What is stopping it is not the >>> disagreement on that patch but an "error" [*] in the plugin header >>>