[Openvpn-devel] [PATCH] Fix broken fragment/mssfix with NCP

2018-11-12 Thread Lev Stipakov
From: Lev Stipakov NCP negotiation replaces worst cast crypto overhead with actual one in data channel frame. That frame params are used by mssfix. Fragment frame still contains worst case overhead. Because of that TCP packets are fragmented, since MSS value exceeds max fragment size. Fix by

Re: [Openvpn-devel] [PATCH v5] Implement block-ipv6

2018-11-12 Thread Arne Schwabe
Am 29.10.18 um 18:20 schrieb Arne Schwabe: > +#define MAX_ICMPV6LEN IPV6_MIN_MTU This should be #define MAX_ICMPV6LEN 1280 Antonios suggestion of using IPV6_MIN_MTU works on Android on my linux test box but breaks on other Linux machines and FreeBSD does not even have this define. Arne

[Openvpn-devel] [PATCH 3/3] Make MSI custom action debug pop-up more informative

2018-11-12 Thread Simon Rozman
Each MSI custom action pops-up a message box in the _DEBUG version before commencing execution. This opens a time window for developer to attach debugger to the msiexec.exe process, set the breakpoints before custom action proceeds with execution. While those pop-up dialogs are targeted to a

[Openvpn-devel] [PATCH 2/3] Change C++ to C comments

2018-11-12 Thread Simon Rozman
--- src/openvpnmsica/openvpnmsica.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/openvpnmsica/openvpnmsica.c b/src/openvpnmsica/openvpnmsica.c index d1642d6a..99b47bf0 100644 --- a/src/openvpnmsica/openvpnmsica.c +++ b/src/openvpnmsica/openvpnmsica.c @@

[Openvpn-devel] [PATCH 1/3] Delete TAP interface before the TAP driver is uninstalled

2018-11-12 Thread Simon Rozman
The previous version of MSI installer did: - Execution Pass: rename the TAP interface to some temporary name - Commit/Rollback Pass: delete the TAP interface / rename the interface back to original name However, the WiX Toolset's Diffx extension to install and remove

[Openvpn-devel] [PATCH v3 05/13] client-connect: Refactor client-connect handling to calling a bunch of hooks in a loop

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch changes the calling of the client-connect functions into an array of hooks and a block of code that calls them in a loop. Signed-off-by: Fabian Knittel Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 45 - 1

[Openvpn-devel] [PATCH v3 07/13] client-connect: Add CC_RET_DEFERRED and cope with deferred client-connect

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch moves the state, that was previously tracked within the multi_connection_established() function, into struct client_connect_state. The multi_connection_established() function can now be exited and re-entered as many times as necessary - without losing the

[Openvpn-devel] [PATCH v3 12/13] client-connect: Implement deferred connect support for plugin API v2

2018-11-12 Thread Arne Schwabe
The V2 API is simpler than the V1 API since there is no passing of data via files. This also means that with the current API the V2 API cannot support async notify via files. Adding a file just for async notify seems very hacky and when needed we should implement a better option when async is

[Openvpn-devel] [PATCH v3 09/13] client-connect: Move adding inotify watch into its own function

2018-11-12 Thread Arne Schwabe
This make the code a bit better readable and also prepares resuing the function for client-connect return files Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 46 + 1 file changed, 30 insertions(+), 16 deletions(-) diff --git

[Openvpn-devel] [PATCH v3 08/13] client-connect: Add deferred support to the client-connect script handler

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch introduces the concept of a return value file for the client-connect handlers. (This is very similar to the auth value file used during deferred authentication.) The file name is stored in the client_connect_state struct. In addition, the patch also allows the

[Openvpn-devel] [PATCH v3 10/13] client-connect: Also use inotify for the deferred client-connect status file

2018-11-12 Thread Arne Schwabe
As we never do client-connect and authentication at the same time it is safe to reuse the existing fields for client-connect return status file Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[Openvpn-devel] [PATCH v3 11/13] client-connect: Add deferred support to the client-connect plugin v1 handler

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel Uses the infrastructure provided and used in the previous patch to provide deferral support to the v1 client-connect plugin handler as well. Signed-off-by: Fabian Knittel PATCH V3: Modify the API to also (optionally) call the plugin on a deferred call. This allows the

[Openvpn-devel] [PATCH v3 01/13] client-connect: Split multi_connection_established into separate functions

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch splits up the multi_connection_established() function. Each new helper function does a specific job. Functions that do a similar job receive a similar calling interface. The patch tries not to reindent code, so that the real changes are as clearly visible as

[Openvpn-devel] [PATCH v3 06/13] client-connect: Change connection_established_flag from bool to enum

2018-11-12 Thread Arne Schwabe
This prepares from the yes/no logic to a tristate logic with defered being the third state. This deviates from Fabian's original patch that that used a pointer being NULL or non NULL as implicit third state. Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 14 --

[Openvpn-devel] [PATCH v3 04/13] client-connect: Refactor to use return values instead of modifying a passed-in flag

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch changes the way the client-connect helper functions communicate with the main function. Instead of updating cc_succeeded and cc_succeeded_count, they now return either CC_RET_SUCCEEDED, CC_RET_FAILED or CC_RET_SKIPPED. In addition, the client-connect helpers are

[Openvpn-devel] [PATCH v3 00/13] Deferred client-connect patch set

2018-11-12 Thread Arne Schwabe
Fabian submitted the original patch set in 2015. When I started working on it I had quite big rebase conflicts and decided to rebsae it manually. During this rebase I adjusted the code and made other minor and major adjustments to the code to better fit our current code style. The minor

[Openvpn-devel] [PATCH v3 02/13] client-connect: Refactor multi_client_connect_source_ccd

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel Refactor multi_client_connect_source_ccd(), so that options_server_import() (or the success path in general) is only entered in one place within the function. Signed-off-by: Fabian Knittel Signed-off-by: Arne Schwabe --- src/openvpn/multi.c | 31

[Openvpn-devel] [PATCH v3 03/13] client-connect: Move multi_client_connect_setenv into early_setup

2018-11-12 Thread Arne Schwabe
From: Fabian Knittel This patch moves multi_client_connect_setenv into multi_client_connect_early_setup and makes sure that every client-connect handling function updates the virtual address selection. Background: This unifies how the client-connect handling functions work. Signed-off-by:

Re: [Openvpn-devel] [PATCH 4/5] Add MSI custom action for reliable Windows 10 detection

2018-11-12 Thread Simon Rozman
Hi, > > It might be somewhat more convenient to add the PID to the debug > > MessageBox call, but it is probably MUCH more convenient to use the > > CustomAction debugging facility built into the MSI service itself: > > > > https://docs.microsoft.com/en-us/windows/desktop/Msi/debugging-custom- >