Re: [Openvpn-devel] [PATCH applied] cleanup: Remove RPM openvpn.spec build approach

2019-03-07 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 I've fixed the minor differences causing conflict and applied it to release/2.4 as well, keeping Gerts ACK - as he said was fine in the previous "patch applied" mail. Your patch has been applied to the following branches commit 57ec6cec85b92e6af35a

Re: [Openvpn-devel] [PATCH] Do not set pkcs11-helper "safe fork mode"

2019-03-07 Thread David Sommerseth
On 18/02/2019 16:31, Hilko Bengen wrote: > From the pkcs11-helper API documentation about pkcs11h_setForkMode(): > >> This funciton is releavant if PKCS11H_FEATURE_MASK_THREADING is >> set. If safe mode is on, the child process can use the loaded >> PKCS#11 providers but it cannot use fork(), whil

Re: [Openvpn-devel] [PATCH applied] Re: Better error message when script fails due to script-security setting

2019-03-07 Thread David Sommerseth
On 28/02/2019 18:25, Gert Doering wrote: > > (Since David was mostly happy with the v1 approach except for the > "127" and "switch()", I assume he's totally fine with v2 now :-) ) Yeah, sorry I didn't manage to do the second review. I've done it post-apply, and it looks much better. It would ge