Hi Paolo,
Thank you very much for this patch. Selva has already given this a
feature-ack, which I agree to. So lets continue here.
First of all, it is really important that the commit message is good on
patches. Please read this really good blog post on this topic:
Hi,
I've rebased the last attempt of the struct argv overual patches [1]
to the lastest public git master [2].
This rebase just needed a few minor changes to account for changes
with tls-crypt-v2 and sitnl patches now being included. I've also
applied Arne's review comments [3].
To simplify
Added doxygen comments for all the functions in argv.c.
There are some slight refactoring, renaming a few variables to make
their use case more obvious and ensure lines do not break our 80-chars
per line coding style limit.
Signed-off-by: David Sommerseth
---
src/openvpn/argv.c | 251
From: Heiko Hund
Prevent the re-allocations of memory when the internal argv grows
beyond 2 and 4 arguments by initially allocating argv to hold up to
7 (+ trailing NULL) pointers.
While at it rename argv_reset to argv_free to actually express
what's going on. Redo the argv_reset functionality
From: Heiko Hund
The previous implementation had the problem that it was not fully
compatible with printf() and could only detect % format directives
following a space character (0x20).
It modifies the format string and inserts marks to separate groups
before passing it to the regular printf in
