[Openvpn-devel] [PATCH v2] Persist management-query-remote and proxy prompts

2020-02-20 Thread selva . nair
From: Selva Nair Currently this prompt is only output once, not re-written to the management interface when the management client connects. It is thus not seen by a client that connects after the prompt is output or one that disconnects and reconnects. This leads to a deadlock: the daemon

Re: [Openvpn-devel] [PATCH applied] Fix possible access of uninitialized pipe handles

2020-02-20 Thread Selva Nair
Hi On Thu, Feb 20, 2020 at 1:20 PM David Sommerseth wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Your patch has been applied to the master branch > > commit 32723d29b2775d63d3fe329d017e7a08e0cdcb72 > Author: Selva Nair > Date: Wed Feb 19 20:56:43 2020 -0500 I think this

Re: [Openvpn-devel] [PATCH v4 4/5] Move NCP related function into a seperate file and add unit tests

2020-02-20 Thread David Sommerseth
On 17/02/2020 15:43, Arne Schwabe wrote: > This allows unit test the NCP functions. The ssl.c file has too > many dependencies to make unit testing of it viable. > > Patch V2: Removing the include "ssl_ncp.h" from options.c for V2 of > implement dynamic NCP forces a new version of this

Re: [Openvpn-devel] [PATCH] Fix possible access of uninitialized pipe handles

2020-02-20 Thread Selva Nair
Hi On Thu, Feb 20, 2020 at 4:24 AM Lev Stipakov wrote: > > Strangely, I do not see this warning (unlike another one about error > in common.c) > with GCC 7.3 despite adding -O1 and -Wmaybe-uninitialized. I saw it on the travis build. With gcc 7.3, for some reason, -O1 doesn't show it but -O2 or

Re: [Openvpn-devel] [PATCH applied] Fix possibly uninitialized return value in GetOpenvpnSettings()

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit e1f7d7885752ac3a0279ecc7e31ccee2af40fbe4 Author: Selva Nair Date: Wed Feb 19 19:49:37 2020 -0500 Fix possibly uninitialized return value in GetOpenvpnSettings() Signed-off-by:

Re: [Openvpn-devel] [PATCH applied] Warn about insecure ciphers also in init_key_type

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 3ca9d94f8688b7851312f7edabae0ff8690bee63 Author: Arne Schwabe Date: Wed Feb 19 12:21:53 2020 +0100 Warn about insecure ciphers also in init_key_type Signed-off-by: Arne Schwabe

Re: [Openvpn-devel] [PATCH applied] Fix possible access of uninitialized pipe handles

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 32723d29b2775d63d3fe329d017e7a08e0cdcb72 Author: Selva Nair Date: Wed Feb 19 20:56:43 2020 -0500 Fix possible access of uninitialized pipe handles Signed-off-by: Selva Nair

Re: [Openvpn-devel] [PATCH applied] re-implement argv_printf_*()

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 4ed7bf7f94a8cecbc2430d8025a2b8a46f94e429 Author: Heiko Hund Date: Thu Feb 6 14:21:00 2020 +0100 re-implement argv_printf_*() Signed-off-by: Heiko Hund Signed-off-by: David

Re: [Openvpn-devel] [PATCH applied] Documented all the argv related code with minor refactoring

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 3226c2edaf0ddd1b4541ce81ebce97a9ae9ecd2a Author: David Sommerseth Date: Thu Feb 6 14:21:03 2020 +0100 Documented all the argv related code with minor refactoring Signed-off-by:

Re: [Openvpn-devel] [PATCH applied] Add gc_arena to struct argv to save allocations

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit e7500875efe03937fc222d737050789f97c30c03 Author: Heiko Hund Date: Thu Feb 6 14:21:02 2020 +0100 Add gc_arena to struct argv to save allocations Signed-off-by: Heiko Hund

Re: [Openvpn-devel] [PATCH applied] argv: do fewer memory re-allocations

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 870e2405e27fb0c119ade6fc0032c81af4d89819 Author: Heiko Hund Date: Thu Feb 6 14:21:01 2020 +0100 argv: do fewer memory re-allocations Signed-off-by: Heiko Hund

Re: [Openvpn-devel] [PATCH 2.4 v3] Swap the order of checks for validating interactive service user

2020-02-20 Thread Lev Stipakov
Compared this code code with corresponding patch to master and ensured that only changes are using swprintf+manually adding null terminator instead of openvpn_swprintf. Compiled with MinGW. Acked-by: Lev Stipakov ke 19. helmik. 2020 klo 3.55 selva.n...@gmail.com kirjoitti: > > From: Selva Nair

Re: [Openvpn-devel] [PATCH] Fix float comparisons of OPENVPN_VERSION_NUMBER

2020-02-20 Thread Илья Шипицин
чт, 20 февр. 2020 г. в 13:44, Arne Schwabe : > Am 20.02.20 um 09:38 schrieb Arne Schwabe: > > These checks are probably the result of copying a > > check from the LibreSSL and modifying it to be > > a OpenSSL check. For some arcane reason LibreSSL decided > > that its version number should be a

Re: [Openvpn-devel] [PATCH] Fix possible access of uninitialized pipe handles

2020-02-20 Thread Lev Stipakov
Strangely, I do not see this warning (unlike another one about error in common.c) with GCC 7.3 despite adding -O1 and -Wmaybe-uninitialized. Change looks reasonable, compiled with MSVC and MinGW. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list

Re: [Openvpn-devel] [PATCH] Fix possibly uninitialized return value in GetOpenvpnSettings()

2020-02-20 Thread Lev Stipakov
Hi, Compiled with MSVC and MinGW, warning is gone. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Fix float comparisons of OPENVPN_VERSION_NUMBER

2020-02-20 Thread Arne Schwabe
Am 20.02.20 um 09:38 schrieb Arne Schwabe: > These checks are probably the result of copying a > check from the LibreSSL and modifying it to be > a OpenSSL check. For some arcane reason LibreSSL decided > that its version number should be a long float (double) rather > than an integer. > >

[Openvpn-devel] [PATCH] Fix float comparisons of OPENVPN_VERSION_NUMBER

2020-02-20 Thread Arne Schwabe
These checks are probably the result of copying a check from the LibreSSL and modifying it to be a OpenSSL check. For some arcane reason LibreSSL decided that its version number should be a long float (double) rather than an integer. Signed-off-by: Arne Schwabe --- src/openvpn/ssl_openssl.c | 6