Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-29 Thread Gert Doering
Hi, On Sun, Mar 29, 2020 at 11:54:36PM +0200, David Sommerseth wrote: > > Applying: Reformat all source files > > error: patch failed: src/openvpn/tun.c:3418 > > error: src/openvpn/tun.c: patch does not apply > > Patch failed at 0001 Reformat all source files > > Ahh, sorry ... I did the reviews

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Jonathan K. Bullard
Hi, On Sun, Mar 29, 2020 at 7:58 PM Selva Nair wrote: > > Hi, > > On Sun, Mar 29, 2020 at 7:13 PM Jonathan K. Bullard > wrote: > > On a Mac using Tunnelblick (which uses the management interface with > > management-query-passwords enabled), if the auth-user-pass file > > contains only the

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Selva Nair
Hi, On Sun, Mar 29, 2020 at 7:13 PM Jonathan K. Bullard wrote: > > Hi, > > On Sun, Mar 29, 2020 at 4:34 PM wrote: > > > > From: Selva Nair > > > > If only username is found in the file, redirect the auth-user-pass > > query to the management on Windows if (i) management-query-passwords > > is

Re: [Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread Jonathan K. Bullard
Hi, On Sun, Mar 29, 2020 at 4:34 PM wrote: > > From: Selva Nair > > If only username is found in the file, redirect the auth-user-pass > query to the management on Windows if (i) management-query-passwords > is enabled and (ii) stdout is redirected to a log file. These > restrictions avoid

Re: [Openvpn-devel] [Openvpn-users] Removing --disable-server option from OpenVPN

2020-03-29 Thread David Sommerseth
On 28/02/2020 20:18, Radu Hociung wrote: > I would recommend that rather than removing the useful bit of > documentation that is P2MP_SERVER, the developers consider: > > 1. Restructure the source tree to split the src/openvpn code into >src/{common,client,server} > > 2. Remove the configure

Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-29 Thread David Sommerseth
On 28/03/2020 12:33, Gert Doering wrote: > Hi, > > On Fri, Mar 27, 2020 at 04:24:00PM +0100, David Sommerseth wrote: >> On 16/11/2019 11:28, Arne Schwabe wrote: >>> Over time some patches slipped in that were not 100% complient to uncrustify >>> This rerun fixes those issues > [..] >> Only done

Re: [Openvpn-devel] [PATCH] Document some limitations of --auth-user-pass

2020-03-29 Thread Selva Nair
Hi, On Tue, Mar 17, 2020 at 6:25 AM Gert Doering wrote: > > Hi, > > On Tue, Mar 17, 2020 at 11:06:53AM +0100, David Sommerseth wrote: > > On 16/03/2020 14:48, Selva Nair wrote: > > [...snip...] > > >> I would just rephrase it to say: > > >> > > >> OpenVPN GUI v11 and newer uses its own

[Openvpn-devel] [PATCH 2/2] When auth-user-pass file has no password, query the management

2020-03-29 Thread selva . nair
From: Selva Nair If only username is found in the file, redirect the auth-user-pass query to the management on Windows if (i) management-query-passwords is enabled and (ii) stdout is redirected to a log file. These restrictions avoid regressive behaviour: those running from the command line will

[Openvpn-devel] [PATCH 1/2] Move querying username/password from management to a function

2020-03-29 Thread selva . nair
From: Selva Nair This helps the next patch. No functionality changes, only refactoring. Signed-off-by: Selva Nair --- src/openvpn/misc.c | 54 ++ 1 file changed, 34 insertions(+), 20 deletions(-) diff --git a/src/openvpn/misc.c