[Openvpn-devel] [Patch] New man page corrections - script-options.rst

2020-07-06 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/script-options.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/man-sections/script-options.rst b/doc/man-sections/script-options.rst index 280127b1..8ea5b4a7 100644 --- a/doc/man-sections/script-o

[Openvpn-devel] [Patch] New man page corrections - server-options.rst

2020-07-06 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/server-options.rst | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/doc/man-sections/server-options.rst b/doc/man-sections/server-options.rst index ada387a2..218d4f35 100644 --- a/doc/man-sect

Re: [Openvpn-devel] [PATCH 1/2] Remember if we have seen a push request without async push

2020-07-06 Thread Arne Schwabe
Am 06.07.20 um 20:43 schrieb Gert Doering: > Hi, > > On Mon, Jul 06, 2020 at 06:35:15PM +0200, Arne Schwabe wrote: >> The logic if we already have seen a push request is still >> correct/useful without async push. I am not entirely sure if also >> deferred management authentication can trigger thi

Re: [Openvpn-devel] [PATCH 2/2] merge key_state->authenticated and key_state->auth_deferred

2020-07-06 Thread Antonio Quartulli
Hi, Thanks for taking one more step towards simplifying this state jungle.. On 06/07/2020 18:35, Arne Schwabe wrote: > Both are tightly coupled often both are checked at the same time. > Merging them into one state makes the code simpler and also brings > us closer in the direction of a state mac

[Openvpn-devel] [PATCH] Remove --writepid file on program exit.

2020-07-06 Thread Gert Doering
For whatever reason, we never removed the pid file on program exit. Not only this is unclean, but it also makes testing for "I want this test case to FAIL" in t_client.sh more annoying to code for "is the OpenVPN process still around?"... Do not unlink the file if chroot() is active (might be out

Re: [Openvpn-devel] [PATCH 1/2] Remember if we have seen a push request without async push

2020-07-06 Thread Gert Doering
Hi, On Mon, Jul 06, 2020 at 06:35:15PM +0200, Arne Schwabe wrote: > The logic if we already have seen a push request is still > correct/useful without async push. I am not entirely sure if also > deferred management authentication can trigger this code path but > it should be able to. The other be

Re: [Openvpn-devel] [PATCH applied] Re: Unified success messages for setting mtu

2020-07-06 Thread Jonathan K. Bullard
Hi, On Mon, Jul 6, 2020 at 11:43 AM Gert Doering wrote: > > Acked-by: Gert Doering > > Thanks :-) - given that this is somewhat trivial, I have not actually > run a binary to look at the messages. I have counted arguments and done > a test build to see if new warnings show up (no). > > I *do* s

[Openvpn-devel] [PATCH 1/2] Remember if we have seen a push request without async push

2020-07-06 Thread Arne Schwabe
The logic if we already have seen a push request is still correct/useful without async push. I am not entirely sure if also deferred management authentication can trigger this code path but it should be able to. The other benefit is removing a number of ifdefs. Signed-off-by: Arne Schwabe --- sr

[Openvpn-devel] [PATCH 2/2] merge key_state->authenticated and key_state->auth_deferred

2020-07-06 Thread Arne Schwabe
Both are tightly coupled often both are checked at the same time. Merging them into one state makes the code simpler and also brings us closer in the direction of a state machine Signed-off-by: Arne Schwabe --- src/openvpn/ssl.c| 29 - src/openvpn/ssl_common.h

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-06 Thread Gert Doering
Hi, On Thu, Jul 02, 2020 at 11:04:41PM +0200, David Sommerseth wrote: > Can we please see this discussion also in context of this mail thread, which > tries to look a broader at this challenge? There's two things here - a small and useful featurette which can go into 2.5, and the broader negotiat

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-06 Thread Gert Doering
Hi, On Tue, Jun 30, 2020 at 04:15:58PM +0200, Jan Just Keijser wrote: > On 30/06/20 16:11, Gert Doering wrote: > > On Tue, Jun 30, 2020 at 04:07:52PM +0200, Jan Just Keijser wrote: > >> @@ -5697,6 +5740,11 @@ build_dhcp_options_string(struct buffer *buf, const > >> struct tuntap_options *o) > >>

[Openvpn-devel] [PATCH applied] Re: Unified success messages for setting mtu

2020-07-06 Thread Gert Doering
Acked-by: Gert Doering Thanks :-) - given that this is somewhat trivial, I have not actually run a binary to look at the messages. I have counted arguments and done a test build to see if new warnings show up (no). I *do* see an old warning... tun.c: In function 'windows_set_mtu': tun.c:5523:2

[Openvpn-devel] [Patch] New man page corrections - tls-options.rst

2020-07-06 Thread Richard Bonhomme
Signed-off-by: Richard Bonhomme --- doc/man-sections/tls-options.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index bb8fc986..21549bdb 100644 --- a/doc/man-sections/tls-options.rst +++ b/doc/man-sec

[Openvpn-devel] [PATCH applied] Re: tap.c: fix adapter renaming

2020-07-06 Thread Gert Doering
Your patch has been applied to the master branch. I have changed the // comments to /* C */ style and word-wrapped the commit message a bit. I have not actually tested a .msi install, but I have test-compiled it (at least) (unbuntu 18 / mingw) and that worked fine. commit 5b313a3565558cd1da4723c

Re: [Openvpn-devel] [PATCH] tap.c: fix adapter renaming

2020-07-06 Thread Simon Rozman via Openvpn-devel
Hi, > +// stripped version of ExecCommand in interactive.c static DWORD C++ style comment. > +// rename adapter via netsh call C++ style comment. > +const TCHAR* szFmt = _T("netsh interface set interface name=\"%s\" > newname=\"%s\""); > +size_t ncmdline = _tcslen(szFmt) + _tcslen(