[Openvpn-devel] [PATCH applied] Re: openvpnmsica: make adapter renaming non-fatal

2020-09-04 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch. Thanks for coming up with the solution & testing & reviewing it! The comment line is a bit long... uncrustify will catch it next time. I have not tested anything, trusting Lev and Simon here :-) (but from a cursory glance, the

Re: [Openvpn-devel] New man-section pages format

2020-09-04 Thread tincanteksup
On 04/09/2020 14:36, David Sommerseth wrote: On 04/09/2020 15:21, tincanteksup wrote: Hi, this is just something to chew-over.. See: https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst I noticed that generally the option names, eg: --auth-nocache, wrap and

[Openvpn-devel] [PATCH applied] Re: In tap.c use DiInstallDevice to install the driver on a new adapter

2020-09-04 Thread Gert Doering
Your patch has been applied to the master and release/2.5 branch. Minor typo in commit message ("instalaltion") fixed. (I have not tested anything, fully trusting you and Lev here - thanks!) commit f3f09541dcff3f0b307067bdf5dcaabc530db4c7 (master) commit 87b43ded380af06129ea59744d27684e36635c74

Re: [Openvpn-devel] New man-section pages format

2020-09-04 Thread David Sommerseth
On 04/09/2020 15:21, tincanteksup wrote: > Hi, > > this is just something to chew-over.. > > See: > https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst > > > I noticed that generally the option names, eg: --auth-nocache, wrap and the > result is unpleasant. > >

Re: [Openvpn-devel] New man-section pages format

2020-09-04 Thread Илья Шипицин
I thought of using autogen. No time yet On Fri, Sep 4, 2020, 4:23 PM tincanteksup wrote: > Hi, > > this is just something to chew-over.. > > See: > > https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst > > I noticed that generally the option names, eg:

[Openvpn-devel] New man-section pages format

2020-09-04 Thread tincanteksup
Hi, this is just something to chew-over.. See: https://github.com/OpenVPN/openvpn/blob/master/doc/man-sections/generic-options.rst I noticed that generally the option names, eg: --auth-nocache, wrap and the result is unpleasant. However, further down that same page --daemon progname does

Re: [Openvpn-devel] [PATCH] In tap.c use DiInstallDevice to install the driver on a new adapter

2020-09-04 Thread Lev Stipakov
Hi, > +HMODULE libnewdev = NULL; I think we are moving to C99 so this could be defined closer to actual usage. Tested with MSVC and mingw - compiled, built installer - installed - tested that tapctl creates adapters which then can be used by non-admin users. Acked-by: Lev Stipakov --