Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Gert Doering
Hi, On Mon, Nov 22, 2021 at 04:55:40PM -0500, Selva Nair wrote: > > (Also, the PR isn't exactly proceeding smoothly... no idea why the > > vcpkg maintainer does not want to see why Lev's PR is an improvement > > of the situation) > > I didn't realize there is a pushback for the patch..May be he

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Selva Nair
On Mon, Nov 22, 2021 at 4:37 PM Gert Doering wrote: > Hi, > > On Mon, Nov 22, 2021 at 04:33:36PM -0500, Selva Nair wrote: > > I think setting env vars would give us extra protection as we can detect > > the actual location of Program Files or executable's path at run time. > > Indeed. > > (Also,

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Gert Doering
Hi, On Mon, Nov 22, 2021 at 04:33:36PM -0500, Selva Nair wrote: > I think setting env vars would give us extra protection as we can detect > the actual location of Program Files or executable's path at run time. Indeed. (Also, the PR isn't exactly proceeding smoothly... no idea why the vcpkg

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Selva Nair
Hi, On Mon, Nov 22, 2021 at 3:27 PM Lev Stipakov wrote: > Hi, > > I added > > _putenv("OPENSSL_CONF=c:\\Temp\\lol.conf"); > > to openvpn_main() and see > > 22:01:38,9512311 openvpn.exe 27668 CreateFile C:\Temp\lol.conf > NAME NOT FOUND > > in procmon. So would it be enough to set

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Lev Stipakov
Hi, I added _putenv("OPENSSL_CONF=c:\\Temp\\lol.conf"); to openvpn_main() and see 22:01:38,9512311 openvpn.exe 27668 CreateFile C:\Temp\lol.conf NAME NOT FOUND in procmon. So would it be enough to set config/engines/modules paths as env variables for openvpn and gui? OTOH we also ship

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Selva Nair
Hi, On Mon, Nov 22, 2021 at 12:20 PM Lev Stipakov wrote: > I added a commit to vcpkg/openssl PR > (https://github.com/microsoft/vcpkg/pull/21540) which gives an option > to customize ENGINESDIR. Unfortunately openssl doesn't make it easy - > ENGINESDIR is built based on --prefix, which is set

Re: [Openvpn-devel] OpenSSL build on Windows: OPENSSLDIR and MODULESDIR

2021-11-22 Thread Lev Stipakov
I added a commit to vcpkg/openssl PR (https://github.com/microsoft/vcpkg/pull/21540) which gives an option to customize ENGINESDIR. Unfortunately openssl doesn't make it easy - ENGINESDIR is built based on --prefix, which is set to vcpkg build dir. The prefix cannot be set to something like

[Openvpn-devel] [PATCH applied] Re: doc/man (vpn-network-options): fix foreign_option_{n} typo

2021-11-22 Thread Gert Doering
Acked-by: Gert Doering Verified by "git grep" for both spelling versions. Thanks for spotting this and sending a fix. Your patch has been applied to the master and release/2.5 branch (bugfix). commit aee54a47142c13a29c2b59142e944fd448a406d9 (master) commit

[Openvpn-devel] [PATCH applied] Re: Update IRC information in CONTRIBUTING.rst

2021-11-22 Thread Gert Doering
Acked-by: Gert Doering Thanks for spotting this and sending a patch. Your patch has been applied to the master and release/2.5 branch. commit 072dabdb1bbc53b422929d33dc6c51ff6457d4e4 (master) commit 55268c83ff2d156a450cfd66f7d0b0d3e90362bf (release/2.5) Author: Todd Zullinger Date: Mon Nov

[Openvpn-devel] [PATCH] Update IRC information in CONTRIBUTING.rst

2021-11-22 Thread Gert Doering
From: Todd Zullinger The developer IRC channel is now on libera.chat. Update CONTRIBUTING.rst to match the wiki. Signed-off-by: Todd Zullinger --- CONTRIBUTING.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index

[Openvpn-devel] [PATCH] doc/man (vpn-network-options): fix foreign_option_{n} typo

2021-11-22 Thread Gert Doering
From: Todd Zullinger In 2da29362 (Improve the documentation for --dhcp-option, 2020-08-16), `foreign_option_{n}` became plural between the first and second versions of the patch. Correct it. Signed-off-by: Todd Zullinger --- doc/man-sections/vpn-network-options.rst | 2 +- 1 file changed, 1

Re: [Openvpn-devel] [PATCH master+release/2.5] Tune down verbosity for suspected retransmits

2021-11-22 Thread Gert Doering
Hi, On Mon, Nov 22, 2021 at 12:20:08PM +0200, Lev Stipakov wrote: > I've discussed this with James, in his opinion it is not needed to be > fixed in openvpn3 server side, since those duplicated packets are > dropped anyway in openvpn2/3 clients. Well. I'd say this is a matter of protocol

Re: [Openvpn-devel] [PATCH master+release/2.5] Tune down verbosity for suspected retransmits

2021-11-22 Thread Lev Stipakov
I've discussed this with James, in his opinion it is not needed to be fixed in openvpn3 server side, since those duplicated packets are dropped anyway in openvpn2/3 clients. OpenVPN3 client doesn't display those errors but increments error counter, which is then dumped to log on disconnect. The

Re: [Openvpn-devel] [PATCH master+release/2.5] Tune down verbosity for suspected retransmits

2021-11-22 Thread Gert Doering
Hi, On Wed, Nov 17, 2021 at 05:53:21AM +0200, Lev Stipakov wrote: > OpenVPN 3, however, doesn't change packet-id on retransmission, > which triggers replay protection and causes level 1 nonfatal errors > in logs. > > When replay protection sees the packet with the same timestamp > and packet-id