Re: [Openvpn-devel] [PATCH release/2.5] Fix M_ERRNO behavior on Windows

2022-05-11 Thread Selva Nair
Acked-by: Selva Nair Same as the patch 2429 for master except for the minor change in x_check_status() to match 2.5. On Wed, May 4, 2022 at 5:13 AM Lev Stipakov wrote: > From: Lev Stipakov > > We use M_ERRNO flag in logging to display error code >

Re: [Openvpn-devel] [PATCH] Implement ED448 and ED25519 support in xkey_provider

2022-05-11 Thread Selva Nair
Hi, On Tue, May 10, 2022 at 7:32 AM Arne Schwabe wrote: > OpenSSL's implementation of ED448 and ED25519 has a few idiosyncrasies. > Instead of belonging to the eliptic curve type or to a common Edwards > curve type, ED448 and ED25519 have each their own type. > > Also, OpenSSL excepts

[Openvpn-devel] [PATCH] doc: fix literal block in tls-options.rst

2022-05-11 Thread Heiko Hund
Signed-off-by: Heiko Hund --- doc/man-sections/tls-options.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/man-sections/tls-options.rst b/doc/man-sections/tls-options.rst index c06ee335..d51aff77 100644 --- a/doc/man-sections/tls-options.rst +++

Re: [Openvpn-devel] [PATCH v3 26/28] Allow setting control channel packet size with tls-mtu

2022-05-11 Thread Frank Lichtenheld
> Arne Schwabe hat am 11.05.2022 13:08 geschrieben: > > > Currently control packet size is controlled by tun-mtu in a very > non-obvious way since the control overhead is not taken into account > and control channel packet will end up with a different size than > data channel packet. > >

[Openvpn-devel] [PATCH v3 26/28] Allow setting control channel packet size with tls-mtu

2022-05-11 Thread Arne Schwabe
Currently control packet size is controlled by tun-mtu in a very non-obvious way since the control overhead is not taken into account and control channel packet will end up with a different size than data channel packet. Instead we decouple this and introduce tls-mtu which defaults to 1250.

[Openvpn-devel] Summary of the community meeting (11th May 2022)

2022-05-11 Thread Samuli Seppänen
Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on libera.chat Date: Wed 11th May 2022 Time: 10:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local meeting

Re: [Openvpn-devel] [PATCH 27/28] Add unit test for reliable_get_num_output_sequenced_available

2022-05-11 Thread Frank Lichtenheld
Acked-By: Frank Lichtenheld Not sure whether it should be concerning that reliable_get_num_output_sequenced_available is happy to give results given the complete garbage we put into the test buffer. But anyway, an UT is better than no UT and the test code looks correct to me. Obviously depends

Re: [Openvpn-devel] [PATCH v2 26/28] Allow setting control channel packet size with tls-mtu

2022-05-11 Thread Frank Lichtenheld
> Arne Schwabe hat am 10.05.2022 19:07 geschrieben: [...] > diff --git a/Changes.rst b/Changes.rst > index 67a23c792..f40fc09ae 100644 > --- a/Changes.rst > +++ b/Changes.rst > @@ -79,6 +79,12 @@ Cookie based handshake for UDP server > shake. The tls-crypt-v2 option allows controlling if

Re: [Openvpn-devel] [PATCH v2 25/28] Ensure that control channel packet are respecting tls-mtu

2022-05-11 Thread Frank Lichtenheld
Typo/grammar fixes only for now. > Arne Schwabe hat am 10.05.2022 19:04 geschrieben: > This ensure that control packets are actually smaller than tls-mtu. "ensures" > Since OpenVPN will consider a control message packet complete > when the TLS record is complete, we have to ensure that the

Re: [Openvpn-devel] [PATCH] Implement --mtu-disc for IPv6 UDP sockets.

2022-05-11 Thread Arne Schwabe
Am 22.02.22 um 15:35 schrieb Gert Doering: Commit 4225114b96 repaired "--mtu-disc yes" brokenness for IPv4 UDP sockets (caused by autoconf/ifdef issues). This patch adds new functionality to do --mtu-disc for IPv6 sockets as well. Half of it (setsockopt(IPV6_MTU_DISCOVER)) was already there,