[Openvpn-devel] [PATCH] Remove management_write_peer_info_file and related code

2022-06-30 Thread selva . nair
From: Selva Nair Use of this has never been documented and the code was dead for a long while now. Signed-off-by: Selva Nair --- Alternative for [PATCH 2/3] Reactivate record_peer_info in manage.c src/openvpn/init.c| 1 - src/openvpn/manage.c | 49

Re: [Openvpn-devel] [PATCH v2 1/4] Implement exit notification via control channel

2022-06-30 Thread Arne Schwabe
Am 30.06.2022 um 22:25 schrieb David Sommerseth: On 20/05/2022 23:32, Arne Schwabe wrote: Current exit notification relies on data channel messages with specific prefix. Adding these to new data channel modules (DCO) adds unncessary complexity for the data for messages that from their idea

Re: [Openvpn-devel] [PATCH 2/3] Reactivate record_peer_info in manage.c

2022-06-30 Thread Arne Schwabe
Am 30.06.2022 um 21:05 schrieb selva.n...@gmail.com: From: Selva Nair --management-client has an obscure and undocumented feature to take a file argument where the peer's address and port are recorded. This has become dead code over time. - reactivate the dead code - make it work with v6

Re: [Openvpn-devel] [PATCH v2 3/4] Implement AUTH_FAIL, TEMP message support

2022-06-30 Thread David Sommerseth
On 20/05/2022 23:32, Arne Schwabe wrote: This allows a server to indicate a temporary problem on the server and allows the server to indicate how to proceed (i.e. move to the next server, retry the same server, wait a certain time,...) This adds options_utils.c/h to be able to unit test the new

Re: [Openvpn-devel] [PATCH v2 1/4] Implement exit notification via control channel

2022-06-30 Thread David Sommerseth
On 20/05/2022 23:32, Arne Schwabe wrote: Current exit notification relies on data channel messages with specific prefix. Adding these to new data channel modules (DCO) adds unncessary complexity for the data for messages that from their idea belong to the control channel anyway. This patch adds

[Openvpn-devel] [PATCH 3/3] Log address of management client on accept

2022-06-30 Thread selva . nair
From: Selva Nair Currently when we are listening on the management interface, the local address/port is logged as that of the connecting client. Fix it. Signed-off-by: Selva Nair --- src/openvpn/manage.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff

[Openvpn-devel] [PATCH 2/3] Reactivate record_peer_info in manage.c

2022-06-30 Thread selva . nair
From: Selva Nair --management-client has an obscure and undocumented feature to take a file argument where the peer's address and port are recorded. This has become dead code over time. - reactivate the dead code - make it work with v6 addresses as well - do not exit on error in writing the

[Openvpn-devel] [PATCH 1/3] Log the actual management interface port in use

2022-06-30 Thread selva . nair
From: Selva Nair When the port is specified as zero, log the actual port bound to, instead of 0. Signed-off-by: Selva Nair --- src/openvpn/manage.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index

[Openvpn-devel] [PATCH v5 05/25] dco: let open_tun_generic handle the DCO case

2022-06-30 Thread Antonio Quartulli
open_tun_generic already contains the logic required to find a device name when not specified b the user. For this reason the DCO case can easily leverage on function and avoid code duplication. Signed-off-by: Antonio Quartulli --- Changes from v4: * in open_tun_generic() use sizeof(tunname)

Re: [Openvpn-devel] [PATCH v4] dco: let open_tun_generic handle the DCO case

2022-06-30 Thread Antonio Quartulli
On 30/06/2022 15:44, Heiko Hund wrote: On Mittwoch, 29. Juni 2022 14:49:45 CEST Antonio Quartulli wrote: name when not specified b the user. For this reason the DCO case can nit: b -> by thanks +strncpynt(tunname, dynamic_name, +

Re: [Openvpn-devel] [PATCH v4] dco: let open_tun_generic handle the DCO case

2022-06-30 Thread Heiko Hund
On Mittwoch, 29. Juni 2022 14:49:45 CEST Antonio Quartulli wrote: > name when not specified b the user. For this reason the DCO case can nit: b -> by > +strncpynt(tunname, dynamic_name, > + sizeof(dynamic_name)); This need to be