From: Selva Nair
Without this, replies to commands from the management client
are sometimes lost if the server is writing when a command
comes in and leads to a recursive call to this function.
For some reason I've not been able to trigger this on Linux,
but it does sometimes happen on Windows
From: Selva Nair
Generally we expect a response of SUCCESS: or ERROR: to every
command sent to the management interface. But, while in
the management-hold state, sending "signal foo" returns only
the following reply (with foo = SIGHUP, SIGUSR1 etc.):
>HOLD:Waiting for hold release:0
Fix by
From: Selva Nair
v2: also fix building test_provider
- ifdefs in test_provider.c
- include integer.h for min_int as manage.h
may not always pull it in
Too many ifdefs, unfortunately..
Signed-off-by: Selva Nair
---
src/openvpn/xkey_helper.c| 4
Hi,
On Sun, Jun 26, 2022 at 01:41:46AM +0200, Arne Schwabe wrote:
> +
> +/**
> + * Checks if the cipher is allowed and updates the TLS session cipher with
> it,
> + * otherwise returns false
> + */
> +bool
> +update_session_cipher(struct tls_session *session, struct options *options);
> +
Is
Hi,
On Tue, Jul 26, 2022 at 07:51:00AM -0400, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Signed-off-by: Selva Nair
> ---
> src/openvpn/xkey_helper.c | 4
> 1 file changed, 4 insertions(+)
Close ;-)
This fixes compilation of xkey_helper.c for --disable-management, but
"make
Acked-by: Gert Doering
Can't pass the chance to apply something that says "remove systemd" while
David is not looking...
Joke aside, this seems to be a straightforward "make sure generated stuff
is cleaned on 'make clean'" thing :-) - I have not tested it in earnest,
though, as none of my
Acked-by: Gert Doering
The change to init.c is easier viewed with "-w" - wrapping the existing
code to initialize the ping intervals into "if (!dco_enabled)".
The remainder does not really do much yet - introduce structure elements
and enums, but they are not used yet. Also, record the ACK
Acked-by: Gert Doering
This is a joint work with many iterations... so we have Antonio's ACK
on "the changes v10 to v11", and my ACK on the rest.
The patch has been tested on Linux with and without DCO enabled (passes
everything in both cases, as long as the system does not have a DCO
driver ->
Hi,
On 21/07/2022 20:24, Gert Doering wrote:
From: Antonio Quartulli
This function is similar to the essence of open_tun_generic(), but
calling open_tun_dco() instead of trying to do a file open on
"/dev/%s"
Previous attempts to save code duplication by including this into
open_tun_generic()
