Hi,
On Tue, Jul 05, 2022 at 11:36:37AM +0200, Antonio Quartulli wrote:
> On 05/07/2022 11:32, Frank Lichtenheld wrote:
> > I think this commit could use an additional sentence
> > in the commit message on why exactly you remove this?
> >
> > Doesn't immediately make sense to me.
>
> To be
Hi,
On Thu, Aug 04, 2022 at 03:30:25PM +0200, Gert Doering wrote:
> Test sets failed: 2b 2c 2f.
So, this is an interesting one.
To trigger this, you need to connect over UDP + IPv6 transport, and
then you need to inject a packet into "openvpn with DCO" that is
fragmented into two parts,
We only need to include this when we want the
git version. This is currently only the case
in options.c
Signed-off-by: Frank Lichtenheld
---
src/openvpn/block_dns.c | 3 ---
src/openvpn/plugin.c| 3 ---
src/tapctl/main.c | 3 ---
3 files changed, 9 deletions(-)
diff --git
To increase the reproducibility of builds
we shouldn't use __DATE__. However, for
the development builds there is some demand
for leaving this in.
So as suggested by Gert Doering go for a
compromise where we only use __DATE__ if
we also include the git information. This
will remove this
Hi,
On Thu, Jul 28, 2022 at 7:19 AM Lev Stipakov wrote:
> From: Lev Stipakov
>
> This code reads the state of OpenVPNService,
> such as startup mode and running, and sets MSI
> property value. If that property is set, installer
> selects OpenVPNService as a feature to be installed.
>
> This
On 04/08/2022 15:30, Gert Doering wrote:
Acked-by: Gert Doering
[]>
Your patch has been applied to the master branch.
Wohooo! Great stuff!
Thanks to everybody who contributed to this first milestone!
However, the party is not over yet :-)
Cheers,
commit
Acked-by: Gert Doering
After all the preliminary infrastructure building, *this* is the beginning
of the real thing :-)
I have tested
- full set of server side tests, without --enable-dco
(this system does not have kernel DCO, so it does not matter)
--> all works
- full set of client
Hi,
On 04/08/2022 13:49, Lev Stipakov wrote:
Hi,
+static bool
+can_preserve_tun(struct tuntap *tt)
+{
+#ifdef TARGET_ANDROID
+return false;
+#elif _WIN32
+return tt && tt->dco.real_tun_init;
Looks like dco.real_tun_init has been added in the very next patch, 22/25.
Darn - must
Hi,
> +static bool
> +can_preserve_tun(struct tuntap *tt)
> +{
> +#ifdef TARGET_ANDROID
> +return false;
> +#elif _WIN32
> +return tt && tt->dco.real_tun_init;
Looks like dco.real_tun_init has been added in the very next patch, 22/25.
___
Acked-by: Gert Doering
Thanks for shuffling this around a bit :-)
Tis is the same code change as v3, with a bit of reformatting in the
message and comment, and it's applied in "part1" now (do_deferred_options()).
Does nothing if DCO is not available (not compiled in / no kernel support),
does
Hi,
On 04/08/2022 10:25, Gert Doering wrote:
If we get a permission denied error on one DCO device, trying 255 more
times will not succeed, and just fill the log file with errors.
Also, remove the msg() call there because it was at debug level
(needed --verb 4 to be seen), didn't see the
If we get a permission denied error on one DCO device, trying 255 more
times will not succeed, and just fill the log file with errors.
Also, remove the msg() call there because it was at debug level
(needed --verb 4 to be seen), didn't see the correct errno, and the
sitnl code already prints the
With this change we introduce ovpn-dco support only along the p2p/client
code path. Server codebase is still unchanged.
Signed-off-by: Antonio Quartulli
---
Changes from v1:
* rebased
---
src/openvpn/dco.c | 91 +++
src/openvpn/dco.h | 48
A server may push options that are not compatible with DCO.
In this case we should log a message and bail out.
Signed-off-by: Antonio Quartulli
---
Changes from v3:
* move pull-option-check to before opening the tun device, for earlier
bail out
* fix typ0 in error message (missing blank)
14 matches
Mail list logo
