Re: [Openvpn-devel] [PATCH] Fix delcarion of pubkeys in test_provider.c in MSVC builds

2022-08-25 Thread Selva Nair
On Thu, Aug 25, 2022 at 4:37 PM Gert Doering wrote: > Hi, > > On Wed, Aug 24, 2022 at 06:57:18PM +0200, Arne Schwabe wrote: > > Error: test_provider.c(74): error C2099: initializer is not a constant > > > > Fix this issue by making the const char* to const char[]. This is > probably > > of one

[Openvpn-devel] [PATCH applied] Re: DCO: require valid netbits setting for non-primary iroutes.

2022-08-25 Thread Gert Doering
Thanks for the reviewes. Dunno why I thought that "we must have no spaces around operators" :-) - so, fixed that whitespace plus 3 tabs that escaped. Patch has been applied to the master branch. commit 104e4ef1e3d49cccb3bc677bab9c24158f91b97b Author: Gert Doering Date: Sat Aug 20 16:01:24

[Openvpn-devel] [PATCH applied] Re: Fix declaration of pubkeys in test_provider.c in MSVC builds

2022-08-25 Thread Gert Doering
I have removed the godbolt reference, and fixed "declaration" :-) - the godbolt thing is not truly relevant in git history, but can be found via the URL: when going to the discussion (if someone is really interested) Your patch has been applied to the master branch. commit

Re: [Openvpn-devel] [PATCH] Fix delcarion of pubkeys in test_provider.c in MSVC builds

2022-08-25 Thread Gert Doering
Hi, On Thu, Aug 25, 2022 at 10:36:21PM +0200, Gert Doering wrote: > On Wed, Aug 24, 2022 at 06:57:18PM +0200, Arne Schwabe wrote: > > Error: test_provider.c(74): error C2099: initializer is not a constant > > > > Fix this issue by making the const char* to const char[]. This is probably > > of

Re: [Openvpn-devel] [PATCH] Fix delcarion of pubkeys in test_provider.c in MSVC builds

2022-08-25 Thread Gert Doering
Hi, On Wed, Aug 24, 2022 at 06:57:18PM +0200, Arne Schwabe wrote: > Error: test_provider.c(74): error C2099: initializer is not a constant > > Fix this issue by making the const char* to const char[]. This is probably > of one the weird array decay corner cases Out of curiosity - does the

Re: [Openvpn-devel] [PATCH applied] Re: t_client: Allow to force FAIL on prerequisite fails

2022-08-25 Thread Gert Doering
Hi, On Fri, Jul 22, 2022 at 05:09:08PM +0200, Gert Doering wrote: > Acked-by: Gert Doering > > "makes sense" - in a buildbot (or any other CI) environment, do not > silently skip missing prereqs, but fail hard. > > Tested with "make check" ;-) - with and without TCLIENT_SKIP_RC=1 > and

[Openvpn-devel] [PATCH applied] Re: t_client.sh: do not require fping6

2022-08-25 Thread Gert Doering
Thanks for working on that ancient script :-) - so far I mostly just fixed the buildslaves by adding wrapper scripts, but of course this is nicer. I have not actually *tested* this yet, but the change looks reasonable, and the buildbots will tell us soon enough... To avoid the conflict when

Re: [Openvpn-devel] [PATCH v101 5/7] dco-win: update GH Actions config file

2022-08-25 Thread Gert Doering
Hi, On Sat, Aug 13, 2022 at 10:42:22PM +0200, Antonio Quartulli wrote: > Signed-off-by: Lev Stipakov > Signed-off-by: Antonio Quartulli > --- > .github/workflows/build.yaml | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/.github/workflows/build.yaml

[Openvpn-devel] [PATCH applied] Re: dco-win: add documentation to README.dco.md

2022-08-25 Thread Gert Doering
Acked-by: Gert Doering Not very much to review here, anyway :-) Your patch has been applied to the master branch. commit a8b00c908b4b8567dcfd792b7ab1d9005bcc587b Author: Antonio Quartulli Date: Sat Aug 13 22:42:21 2022 +0200 dco-win: add documentation to README.dco.md

[Openvpn-devel] [PATCH applied] Re: dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-25 Thread Gert Doering
Acked-by: Gert Doering Thanks for the test reports. I had stared-at-code in v102, and the changes 102->105 are still fine with me. I have subjected this to build tests on github (fine), and had my test machinery chew on the linux and freebsd DCO and non-DCO builds very thoroughly, as this

[Openvpn-devel] [PATCH v105] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-25 Thread Lev Stipakov
From: Antonio Quartulli With this change it is possible to use ovpn-dco-win when running OpenVPN in client or P2P mode. Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- Changes from v104: * query first crypto library for chacha support and then,

Re: [Openvpn-devel] [PATCH] t_client.sh: do not require fping6

2022-08-25 Thread Frank Lichtenheld
On Mon, Aug 22, 2022 at 04:18:06PM +0200, Frank Lichtenheld wrote: > fping and fping6 were merged in version 4.0, > released in 2017. Many recent distributions do > not include the compatibility symlink anymore. > > So if we find fping but not fping6 do not error > out but assume that fping is

Re: [Openvpn-devel] [PATCH v103] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-25 Thread Arne Schwabe
Am 25.08.22 um 13:29 schrieb Gert Doering: Hi, On Mon, Aug 22, 2022 at 11:56:47AM +0300, Lev Stipakov wrote: From: Antonio Quartulli With this change it is possible to use ovpn-dco-win when running OpenVPN in client or P2P mode. Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov

[Openvpn-devel] [PATCH v104] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-25 Thread Lev Stipakov
From: Antonio Quartulli With this change it is possible to use ovpn-dco-win when running OpenVPN in client or P2P mode. Signed-off-by: Arne Schwabe Signed-off-by: Lev Stipakov Signed-off-by: Antonio Quartulli --- Changes from v103: * Query DCO code for default --data-ciphers only on

Re: [Openvpn-devel] [PATCH v103] dco-win: implement ovpn-dco support in P2P Windows code path

2022-08-25 Thread Gert Doering
Hi, On Mon, Aug 22, 2022 at 11:56:47AM +0300, Lev Stipakov wrote: > From: Antonio Quartulli > > With this change it is possible to use ovpn-dco-win when running OpenVPN > in client or P2P mode. > > Signed-off-by: Arne Schwabe > Signed-off-by: Lev Stipakov > Signed-off-by: Antonio Quartulli

Re: [Openvpn-devel] [PATCH] Fix delcarion of pubkeys in test_provider.c in MSVC builds

2022-08-25 Thread Frank Lichtenheld
Typo "delcarion" in summary line On Wed, Aug 24, 2022 at 06:57:18PM +0200, Arne Schwabe wrote: > Error: test_provider.c(74): error C2099: initializer is not a constant > > Fix this issue by making the const char* to const char[]. This is probably > of one the weird array decay corner cases >