From: Selva Nair
Use a unified logging format for various route-methods
- Route add/delete errors are always logged with M_WARN, so
log only additional information (succeed/exists) with D_ROUTE.
- Non-windows platforms log route errors with a prefix "ERROR:" and
debug info with "ROUTE:".
From: Selva Nair
- Instead of 0, 1, 2 use RTA_ERROR, RTA_SUCCESS, RTA_EEXIST
as the return code of route addition functions.
- Also fix a logging error: status -> (status == RTA_SUCCESS)
Signed-off-by: Selva Nair
---
src/openvpn/route.c | 106 ++--
1
On Wed, Jan 11, 2023 at 11:38 AM Gert Doering wrote:
> The code in sitnl_route_set() used to treat "route can not be installed
> because it already exists" (EEXIST) as "not an error".
>
> This is arguably a reasonable approach, but needs to handled higher
> up - if the low level add_route()
Antonio, thanks for the ACK, and yes, we need a FreeBSD 14 buildbot
(Github Actions has no support for "not yet released" OSes yet, as
far as I'm aware)
Patch has been applied to the master and release/2.6 branch.
commit cf545d603ecd9fbacc6bd519efaa92d60f944287 (master)
commit
Hi,
On 13/01/2023 09:07, Gert Doering wrote:
commit 67c4eebdae introduces a new peer disconnect reason (transport
disconnected, aka "TCP session closed") which breaks compilation on
FreeBSD - OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT not part of the
enum in freebsd_dco.h, and no kernel support
Hi,
On 13/01/2023 09:44, Gert Doering wrote:
Hi,
On Fri, Jan 13, 2023 at 09:37:49AM +0100, Antonio Quartulli wrote:
On 13/01/2023 09:32, Kristof Provost wrote:
I???m not sure how we???d cope with supporting building on older releases
though. Not a worry just yet, because FreeBSD main is the
On 13 Jan 2023, at 20:35, Gert Doering wrote:
On Thu, Jan 12, 2023 at 12:50:52AM +0100, Antonio Quartulli wrote:
diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index 77dcaa60..99123c39 100644
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3244,6 +3244,10 @@
Hi,
On Fri, Jan 13, 2023 at 09:37:49AM +0100, Antonio Quartulli wrote:
> On 13/01/2023 09:32, Kristof Provost wrote:
> > I???m not sure how we???d cope with supporting building on older releases
> > though. Not a worry just yet, because FreeBSD main is the only version
> > with DCO support in
Hi,
On 13/01/2023 09:32, Kristof Provost wrote:
I’m not sure how we’d cope with supporting building on older releases
though. Not a worry just yet, because FreeBSD main is the only version
with DCO support in it, but it’ll be a problem sooner or later.
OpenVPN ships its own "recent"| version
commit 67c4eebdae introduces a new peer disconnect reason (transport
disconnected, aka "TCP session closed") which breaks compilation on
FreeBSD - OVPN_DEL_PEER_REASON_TRANSPORT_DISCONNECT not part of the
enum in freebsd_dco.h, and no kernel support for TCP anyway.
This patch is an intermediate
10 matches
Mail list logo
