Hi,
On Sat, Feb 25, 2023 at 12:23:42PM -0500, Selva Nair wrote:
> > OTOH, there might be a bit of polishing needed - the other tests
> > print out what they are doing ("Running 7 test(s)"), while the
> > cryptoapi unit test "just succeeds". Is there something missing
> > wrt cmocka
Hi
On Sat, Feb 25, 2023 at 11:29 AM Gert Doering wrote:
> Acked-by: Gert Doering
>
> Thanks for the v4. This enabled me to just push to GH to have
> to build and run the tests, without having to bother myself with
> copying binaries around :-)
>
> OTOH, there might be a bit of polishing
Acked-by: Gert Doering
"Makes sense".
Before:
--disable-lzo disable LZO compression support [default=yes]
--disable-lz4 Disable LZ4 compression support
--enable-comp-stub Don't compile compression support but still allow
limited interoperability with
Acked-by: Gert Doering
I'm not a big fan of adding (cast) to silence compiler warnings,
but this signed/unsigned char * nonsense is really hard to avoid -
casting to (void *) is the right fix here.
I have only test compiled on MinGW - and my MinGW did not warn
about these anyway (maybe not
Acked-by: Gert Doering
Thanks for the v4. This enabled me to just push to GH to have
to build and run the tests, without having to bother myself with
copying binaries around :-)
OTOH, there might be a bit of polishing needed - the other tests
print out what they are doing ("Running 7
Acked-by: Gert Doering
While I do have no idea about windows drivers and such, having some
helpful debug output for "adapter not found" issues is good.
I have stared at the code for a bit, and it's all fairly trivial
msg()'ing of strings and integers (plus an M_ERRNO added in one
of the error
This patch is identical to v3, except that it modifies the github
actions to avoid GHA explosions on the linux workers. So recording
Selva's and Antonio's ACKs of v3 here on v6.
Pushed to GHA and buildbots, all of them are happy now.
(We need to remember to add this to Changes.rst, as it might
