Re: [Openvpn-devel] [PATCH] Support --inactive option for DCO

2023-03-16 Thread Heiko Hund
On Mittwoch, 15. März 2023 14:38:08 CET Lev Stipakov wrote: > Change-Id: Ib417b965bc4a2c17b51935b43c9627b106716526 > Signed-off-by: Lev Stipakov Acked-by: Heiko Hund ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

Re: [Openvpn-devel] [PATCH] dns option: allow up to two addresses per family

2023-03-16 Thread Gert Doering
Hi, On Tue, Feb 28, 2023 at 05:26:45AM +0100, Heiko Hund wrote: > Signed-off-by: Heiko Hund > --- > doc/man-sections/client-options.rst | 7 +-- > src/openvpn/dns.c | 70 - > src/openvpn/dns.h | 19 +--- >

[Openvpn-devel] OpenVPN 2.6.1 released

2023-03-16 Thread Frank Lichtenheld
The OpenVPN community project team is proud to release OpenVPN 2.6.1. This is mostly a bugfix release with some improvements. Feature changes: * Dynamic TLS Crypt: When both peers are OpenVPN 2.6.1+, OpenVPN will dynamically create a tls-crypt key that is used for renegotiation. This

Re: [Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
Hi, On Thu, Mar 16, 2023 at 07:59:42AM -0400, Selva Nair wrote: > > I have tried testing this on a "real" Win10 VM, but I am missing some > > intricacies with the cert store - I wanted to see if certs are properly > > cleaned up, but I can't even see my own .p12 I have imported, so I am > > doing

Re: [Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Selva Nair
> > > I have tried testing this on a "real" Win10 VM, but I am missing some > intricacies with the cert store - I wanted to see if certs are properly > cleaned up, but I can't even see my own .p12 I have imported, so I am > doing something wrong... This works for me: Run "certmgr" from a user

[Openvpn-devel] [PATCH applied] Re: Add a test for signing with certificates in Windows store

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering More tests are always welcome :-) - stared at the code (looks good), tested on MinGW->W10 and GHA. [==] Running 6 test(s). [ RUN ] test_parse_hexstring [ OK ] test_parse_hexstring [ RUN ] import_certs [ OK ] import_certs

[Openvpn-devel] [PATCH applied] Re: Refactor SSL_CTX_use_CryptoAPI_certificate()

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering Stared-at-code, looks all reasonable. Tested on local MinGW->W10 build (of cryptoapi_testdriver.exe) and GHA (to get all 32/64 bit and OpenSSL 1/3 combinations built), everything passes. Your patch has been applied to the master and release/2.6 branch. commit

[Openvpn-devel] [PATCH applied] Re: Add tests for finding certificates in Windows cert store

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering Code looks reasonable and tests what we want tested. Tested with a local MinGW build -> copied to windows10, and with GHA. [==] Running 5 test(s). [ RUN ] test_parse_hexstring [ OK ] test_parse_hexstring [ RUN ] import_certs [

[Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering This is a welcome addition so we can have actual cryptoapi unit tests. The code looks reasonable, and GHA says "it passes"... Run ./unittests/cryptoapi_testdriver.exe [==] Running 2 test(s). [ RUN ] test_parse_hexstring [