On 29/03/2023 14:46, Arne Schwabe wrote:
This can happen if the memory alloc fails.
Patch V2: add goto error
Change-Id: Iee66caa794d267ac5f8bee584633352893047171
Signed-off-by: Arne Schwabe
---
src/openvpn/dco_linux.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
This can happen if the memory alloc fails.
Patch V2: add goto error
Change-Id: Iee66caa794d267ac5f8bee584633352893047171
Signed-off-by: Arne Schwabe
---
src/openvpn/dco_linux.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c
index
Add the ability for users to specify a custom
routing table where routes should be installed in.
As of now routes are always installed in the main
routing table of the operating system, however,
with the new --route-table option it is possibile
to specify the ID of the default routing table
to be
I have only loosely followed the discussion, but since this has an ACK
*and* passes all GHA compiles and tests, this is good enough for me :-)
I have added the "co-authored-by" as requested.
Your patch has been applied to the master branch.
commit 846951665a60424b98097ad0a77ec6cb1c3d05ac
Having pkcs#11 tests available is most welcome. This said, I have not
really looked into "how can I make this do things for my test beds?",
but will do...
With the #if HAVE_SOFTHSM2, this does not actually do anything for
most build environments yet, but patch 3/3 will enable it for GHA Ubuntu
Ran this through GHA, it claims success, and claims having tested this...
[==] Running 3 test(s).
Slot 0 has a free/uninitialized token.
The token has been initialized and is reassigned to slot 347291425
[ RUN ] test_pkcs11_ids
[ OK ] test_pkcs11_ids
[ RUN ]
Just some very basic tests.
Signed-off-by: Frank Lichtenheld
---
tests/unit_tests/openvpn/test_buffer.c | 59 ++
1 file changed, 59 insertions(+)
diff --git a/tests/unit_tests/openvpn/test_buffer.c
b/tests/unit_tests/openvpn/test_buffer.c
index 9e3b1d2e..5e61fb07
Since we use strlen() to determine the length
and then check it ourselves, there is really
no point in using strncpy.
But the compiler might complain that we use
the output of strlen() for the length of
strncpy which is usually a sign for bugs:
error: ‘strncpy’ specified bound depends
on the
"git show --color-moved=zebra" agrees with "this is just moving stuff
around". I have tested that "make dist" picks up the new file (this
is something we tend to get wrong), and ran this by GHA (pass).
At this point in the 2.6 life cycle, I think we can go back to the
"everything goes to master,
