[Openvpn-devel] [XS] Change in openvpn[release/2.6]: Support for long INFO/INFO_PRE messages

2023-09-11 Thread stipa (Code Review)
stipa has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/327?usp=email ) Change subject: Support for long INFO/INFO_PRE messages .. Abandoned We decided that this is a server bug, it is not supposed to send

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Warn user if INFO control command is too long

2023-09-11 Thread stipa (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/329?usp=email to review the following change. Change subject: Warn user if INFO control command is too long

Re: [Openvpn-devel] [PATCH] GHA: new workflow to submit scan to Coverity Scan service

2023-09-11 Thread Frank Lichtenheld
On Fri, Aug 11, 2023 at 05:35:03PM +0200, Arne Schwabe wrote: > Am 11.08.23 um 17:12 schrieb Gert Doering: > > Hi, > > > > generally good, but... > > > > On Fri, Jul 28, 2023 at 02:40:05PM +0200, Frank Lichtenheld wrote: > > > index ..0620f638 > > > --- /dev/null > > > +++

[Openvpn-devel] [PATCH v2] GHA: new workflow to submit scan to Coverity Scan service

2023-09-11 Thread Frank Lichtenheld
Not on every push due to submit limits. Use caching to not submit a scan for the same git commit twice. Since we have many days without pushes to master this saves a lot of Github and Coverity resources. v2: - add caching to not submit redundant scans Change-Id:

Re: [Openvpn-devel] [PATCH v2] Fix StatusChangeCallback so it works without a LogCallback

2023-09-11 Thread Jeremy Fleischman
Thank you for the update, and patience. My first email-based patch :) On Mon, Sep 11, 2023, 1:57 AM David Sommerseth wrote: > On 06/09/2023 19:17, Jeremy Fleischman wrote: > > `StatusChangeCallback` requires that LogForward be enabled, which > > previously only happened in `LogCallback`. Now

Re: [Openvpn-devel] [PATCH v2] Fix StatusChangeCallback so it works without a LogCallback

2023-09-11 Thread David Sommerseth
On 06/09/2023 19:17, Jeremy Fleischman wrote: `StatusChangeCallback` requires that LogForward be enabled, which previously only happened in `LogCallback`. Now both of them do it, which requires a bit of bookkeeping. This fixes https://github.com/OpenVPN/openvpn3-linux/issues/197 Signed-off-by: