[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-03-07 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#6) to the change originally created by its_Giaan. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email ) Change subject: Persist-key: enable persist-key option by default .. Persist-key:

[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-03-07 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email ) Change subject: Persist-key: enable persist-key option by default .. Persist-key: enable persist-key option by default Change the default

[Openvpn-devel] [PATCH applied] Re: Persist-key: enable persist-key option by default

2024-03-07 Thread Gert Doering
Thanks for this. We discussed this and nobody seemed to remember why persist-key was configurable really ("you could swap out the key + cert while openvpn is running and then SIGUSR1 it", but yeah, who does this?) - so thanks for throwing out these extra code paths. Tested with the full

[Openvpn-devel] [PATCH v5] Persist-key: enable persist-key option by default

2024-03-07 Thread Gert Doering
From: Gianmarco De Gregori Change the default behavior of the OpenVPN configuration by enabling the persist-key option by default. This means that all the keys will be kept in memory across restart. Fixes: Trac #1405 Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Signed-off-by: Gianmarco

[Openvpn-devel] [M] Change in openvpn[master]: Persist-key: enable persist-key option by default

2024-03-07 Thread its_Giaan (Code Review)
Attention is currently required from: flichtenheld, its_Giaan, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/529?usp=email to look at the new patch set (#5). The following approvals got outdated and were

[Openvpn-devel] [PATCH v5] Minor fix to process_ip_header

2024-03-07 Thread Gert Doering
From: Gianmarco De Gregori Removed if-guard checking if any feature is enabled before performing per-feature check. It doesn't save us much but instead introduces uneeded complexity. While at it, fixed a typo IMCP -> ICMP for defined PIPV6_ICMP_NOHOST_CLIENT and PIPV6_ICMP_NOHOST_SERVER macros.

[Openvpn-devel] [M] Change in openvpn[master]: Minor fix to process_ip_header

2024-03-07 Thread its_Giaan (Code Review)
Attention is currently required from: its_Giaan, ordex. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/525?usp=email to look at the new patch set (#5). The change is no longer submittable:

[Openvpn-devel] [M] Change in openvpn[master]: Minor fix to process_ip_header

2024-03-07 Thread its_Giaan (Code Review)
Attention is currently required from: its_Giaan, ordex. Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/525?usp=email to look at the new patch set (#4). The change is no longer submittable: