[Openvpn-devel] [S] Change in openvpn[master]: GHA: general update March 2024

2024-03-15 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/544?usp=email to review the following change. Change subject: GHA: general update March 2024

Re: [Openvpn-devel] [PATCH v2] Implement server_poll_timeout for socks

2024-03-15 Thread Frank Lichtenheld
On Fri, Mar 15, 2024 at 05:20:11PM +0100, Frank Lichtenheld wrote: > From: 5andr0 > > So far --server-poll-timeout was only applied > for HTTP proxies, apply it also to SOCKS proxies. > > This removes the default 5 second socks connect timeout > which can be too small depending on network setup

[Openvpn-devel] [PATCH v2] Implement server_poll_timeout for socks

2024-03-15 Thread Frank Lichtenheld
From: 5andr0 So far --server-poll-timeout was only applied for HTTP proxies, apply it also to SOCKS proxies. This removes the default 5 second socks connect timeout which can be too small depending on network setup and replaces it with the configurable overall connect timeout (default 120

[Openvpn-devel] [S] Change in openvpn[master]: Disable DCO if proxy is set via management

2024-03-15 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/543?usp=email ) Change subject: Disable DCO if proxy is set via management ..

[Openvpn-devel] [S] Change in openvpn[master]: Disable DCO if proxy is set via management

2024-03-15 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/543?usp=email to review the following change. Change subject: Disable DCO if proxy is set via management

[Openvpn-devel] [S] Change in openvpn[master]: Remove license warning from README.mbedtls

2024-03-15 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/561?usp=email ) Change subject: Remove license warning from README.mbedtls .. Remove license warning from README.mbedtls The licenses are compatible now,

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Remove license warning from README.mbedtls

2024-03-15 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/562?usp=email ) Change subject: Remove license warning from README.mbedtls .. Remove license warning from README.mbedtls The licenses are compatible now,

[Openvpn-devel] [S] Change in openvpn[release/2.6]: Remove license warning from README.mbedtls

2024-03-15 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/562?usp=email ) Change subject: Remove license warning from README.mbedtls .. Remove license warning

[Openvpn-devel] [S] Change in openvpn[master]: Remove license warning from README.mbedtls

2024-03-15 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/561?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Remove license warning from README.mbedtls

[Openvpn-devel] [PATCH applied] Re: Remove license warning from README.mbedtls

2024-03-15 Thread Gert Doering
Well spotted :-) Your patch has been applied to the master and release/2.6 branch. commit 91eb4606a4a3e8e2a4ed2ac4e2257e7ea44ccc44 (master) commit 366ca5b9b5ec104e0c7ae2f3cf563b9057ee879a (release/2.6) Author: Max Fillinger Date: Thu Mar 14 19:55:27 2024 +0100 Remove license warning from