[Openvpn-devel] [S] Change in openvpn[master]: misc.c: remove unused code

2024-03-29 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/550?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by flichtenheld Change subject: misc.c: remove unused code

[Openvpn-devel] [S] Change in openvpn[master]: misc.c: remove unused code

2024-03-29 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/550?usp=email ) Change subject: misc.c: remove unused code .. misc.c: remove unused code Commit 3a4fb1 "Ensure --auth-nocache is handled during renegot

[Openvpn-devel] [PATCH applied] Re: misc.c: remove unused code

2024-03-29 Thread Gert Doering
Your patch has been applied to the master and release/2.6 branch. (Trivial and obvious removal of dead code, passes all tests, and having the code align can be helpful) commit 4c71e816031f564f834df695b3fa717ea22720d2 (master) commit f50c67707ed033040c93a6b5d4efbbd2c0933459 (release/2.6) Author: L

[Openvpn-devel] [PATCH v1] misc.c: remove unused code

2024-03-29 Thread Gert Doering
From: Lev Stipakov Commit 3a4fb1 "Ensure --auth-nocache is handled during renegotiation" has changed the behavior of set_auth_token(), but left unused parameter struct user_pass *up Remove this parameter and amend comments accordingly. Also remove unused function definition from misc.h.