[Openvpn-devel] [M] Change in openvpn[master]: test_user_pass: Check fatal errors for empty username/password

2024-05-17 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/474?usp=email to look at the new patch set (#11). Change subject: test_user_pass: Check fatal errors for empty username/password

[Openvpn-devel] [S] Change in openvpn[master]: Only schedule_exit() once

2024-05-17 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#4) to the change originally created by reynir. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Only schedule_exit() once

[Openvpn-devel] [S] Change in openvpn[master]: Only schedule_exit() once

2024-05-17 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/555?usp=email ) Change subject: Only schedule_exit() once .. Only schedule_exit() once If an exit has already been scheduled we should not schedule it

[Openvpn-devel] [PATCH applied] Re: Only schedule_exit() once

2024-05-17 Thread Gert Doering
Thanks :-) - this is mostly the same as v2, with a whitespace fix, and remodeling receive_exit_message() to avoid -Werror failures when comping without ENABLE_MANAGEMENT ("unused variable"). Tested on GHA, buildbots and the server testbed. Your patch has been applied to the master and