Re: [Openvpn-devel] [PATCH] Allow ncp-disable and ncp-ciphers to be specified in ccd files

On Fri, Jul 29, 2016 at 5:18 PM, Jan Just Keijser wrote: > another remark: making this option CCD-file specific a good idea, but how > you do ensure that the server only applies it to this particular client? > o->ncp_enabled seems a global at first glance. Consider this

Re: [Openvpn-devel] [PATCH] Allow ncp-disable and ncp-ciphers to be specified in ccd files

Hi, On 25/07/16 20:52, Steffan Karger wrote: This allows the ncp-disable and ncp-ciphers options to be used in 'client config dir' files, to disable or change the negotiable crypto parameter settings for specific clients. Signed-off-by: Steffan Karger ---

Re: [Openvpn-devel] [PATCH] Allow ncp-disable and ncp-ciphers to be specified in ccd files

Hi JJK, On 26-07-16 04:17, Jan Just Keijser wrote: > ACK from me, but just to nitpick: > > we now have an option 'disable-occ' and an option 'ncp-disable' - > wouldn't it make more sense to make it "disable-ncp" as well? Yes, I considered this, but I like --ncp-disable more because: * it has

Re: [Openvpn-devel] [PATCH] Allow ncp-disable and ncp-ciphers to be specified in ccd files

ACK from me, but just to nitpick: we now have an option 'disable-occ' and an option 'ncp-disable' - wouldn't it make more sense to make it "disable-ncp" as well? JJK On 25/07/16 20:52, Steffan Karger wrote: This allows the ncp-disable and ncp-ciphers options to be used in 'client config