Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Le 12/16/16 à 23:33, Steffan Karger a écrit : > Also, is -Werror=format-security needed (instead of -Wformat-security) > if we already have -Werror? No. In this case, it's indeed clearer to have -Wformat-security Julien signature.asc Description: OpenPGP digital signature

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Le 12/17/16 à 11:44, Gert Doering a écrit : > Taking 2.4_rc2 and building on AIX with -Wall -Wno-pointer-sign is > actually much less bad than I thought :-) - but there are things in > there which are annoying, like these > > ../../../git/src/openvpn/route.c: In function 'add_route_ipv6': >

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Hi, On Sat, Dec 17, 2016 at 04:26:46PM +0500, ?? wrote: > > The world is bigger than Linux. > > There should be high level autoconf magic, which will add option if chosen > compiler supports it. That wasn't my point. Some systems are making it hard to get Linux-developed

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

17 дек. 2016 г. 15:07 пользователь "Gert Doering" написал: Hi, On Fri, Dec 16, 2016 at 11:16:08PM +0100, Julien Muchembled wrote: > BTW, instead of failing on these 3 specific warnings, we could go the opposite way, since -Wall is quite silent. I suggest: > > -Wall

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Hi, On Sat, Dec 17, 2016 at 11:16:10AM +0100, Steffan Karger wrote: > > NAK to "-Wall -Werror", unless you've tested that this does not break > > compilation on any of the supported platforms. > > Sure, but I think we should help out with that. Such as, do a test > build on the supported

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

On 17 December 2016 at 11:05, Gert Doering wrote: > On Fri, Dec 16, 2016 at 11:16:08PM +0100, Julien Muchembled wrote: >> BTW, instead of failing on these 3 specific warnings, we could go the >> opposite way, since -Wall is quite silent. I suggest: >> >> -Wall -Wno-unused

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

On 16-12-16 23:16, Julien Muchembled wrote: > Le 12/16/16 à 21:52, Steffan Karger a écrit : >>> +AX_CHECK_COMPILE_FLAG([ -Werror=implicit ], [ >>> +CFLAGS_EXTRA="$CFLAGS_EXTRA -Werror=implicit" >>> +]) >>> +AX_CHECK_COMPILE_FLAG([ -Werror=format -Werror=format-security ], [ >>> +

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Le 12/16/16 à 21:52, Steffan Karger a écrit : >> +AX_CHECK_COMPILE_FLAG([ -Werror=implicit ], [ >> +CFLAGS_EXTRA="$CFLAGS_EXTRA -Werror=implicit" >> +]) >> +AX_CHECK_COMPILE_FLAG([ -Werror=format -Werror=format-security ], [ >> +CFLAGS_EXTRA="$CFLAGS_EXTRA -Werror=format

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

On 16-12-16 22:53, Arne Schwabe wrote: > Am 16.12.16 um 19:26 schrieb Julien Muchembled: >> The bug in Trac #792 (pointer wrongly truncated as 'int', leading to >> segfaults) >> would have been understood faster with either >> -Werror=implicit or -Werror=format >> (and above all, before

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Am 16.12.16 um 19:26 schrieb Julien Muchembled: > The bug in Trac #792 (pointer wrongly truncated as 'int', leading to > segfaults) > would have been understood faster with either > -Werror=implicit or -Werror=format > (and above all, before running buggy executables in production) > > Debian

Re: [Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

Hi, On 16-12-16 19:26, Julien Muchembled wrote: > The bug in Trac #792 (pointer wrongly truncated as 'int', leading to > segfaults) > would have been understood faster with either > -Werror=implicit or -Werror=format > (and above all, before running buggy executables in production) > > Debian

[Openvpn-devel] [PATCH] Build with a few -Werror= flags if the compiler supports them

The bug in Trac #792 (pointer wrongly truncated as 'int', leading to segfaults) would have been understood faster with either -Werror=implicit or -Werror=format (and above all, before running buggy executables in production) Debian already compiles with -Werror=format-security, and it's indeed