Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-07 Thread Samuli Seppänen
Il 07/12/2016 10:29, Gert Doering ha scritto: > Hi, > > On Tue, Dec 06, 2016 at 05:37:15PM -0500, Selva Nair wrote: >> Yes, it does work in tun mode (easy to test just use offset 0 on command >> line) > > Good :-) > >> I had posted a patch ( a year ago?) which sets the offset to 0. I did not >> rem

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-07 Thread Gert Doering
Hi, On Tue, Dec 06, 2016 at 05:37:15PM -0500, Selva Nair wrote: > Yes, it does work in tun mode (easy to test just use offset 0 on command > line) Good :-) > I had posted a patch ( a year ago?) which sets the offset to 0. I did not > remove the offset variable though it makes sense to get rid of

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-06 Thread Selva Nair
Hi, On Tue, Dec 6, 2016 at 3:33 PM, Gert Doering wrote: > I'm going to merge your documentation patch now, for 2.4.0 and 2.3.14, > but for git master we should revisit this piece of , get rid of > "dhcp_masq_custom_offset" *and* make it default to 0 for both tun > and tap... (since there is no

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-06 Thread Gert Doering
HI, On Fri, Dec 02, 2016 at 02:42:09PM -0500, Selva Nair wrote: > Also correct the default ifconfig-pool end in docs and comments > > Signed-off-by: Selva Nair > --- > doc/openvpn.8| 4 ++-- > src/openvpn/helper.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) "why oh why".

Re: [Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-02 Thread Selva Nair
Hi, On Fri, Dec 2, 2016 at 2:42 PM, Selva Nair wrote: > Also correct the default ifconfig-pool end in docs and comments > > Signed-off-by: Selva Nair > Not critical for 2.4, but posted it anyway because I was bitten by this again today: a new server with the last address .254 included the poo

[Openvpn-devel] [PATCH] Correctly state the default dhcp server address in man page

2016-12-02 Thread Selva Nair
Also correct the default ifconfig-pool end in docs and comments Signed-off-by: Selva Nair --- doc/openvpn.8| 4 ++-- src/openvpn/helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/openvpn.8 b/doc/openvpn.8 index e61b6bb..290a441 100644 --- a/doc/openvpn.8