Re: [Openvpn-devel] [PATCH] Exit early when external scripts are specified with script-security < 2

2019-02-16 Thread Selva Nair
Hi, On Sat, Feb 16, 2019 at 8:19 AM David Sommerseth < open...@sf.lists.topphemmelig.net> wrote: > On 15/02/2019 21:31, Selva Nair wrote: > > Hi > > > > On Fri, Feb 15, 2019 at 3:26 PM David Sommerseth > > open...@sf.lists.topphemmelig.net>> > > wrote: > > > > On 11/02/2019 21:46,

Re: [Openvpn-devel] [PATCH] Exit early when external scripts are specified with script-security < 2

2019-02-15 Thread Gert Doering
Hi, On Fri, Feb 15, 2019 at 09:26:50PM +0100, David Sommerseth wrote: > So I can give this a full ACK for git master only. I can see your line of reasoning, but there is another aspect to it - we want to change the windows GUI to override script-security, to disarm possibly dangerous .ovpn files

Re: [Openvpn-devel] [PATCH] Exit early when external scripts are specified with script-security < 2

2019-02-15 Thread David Sommerseth
On 11/02/2019 21:46, selva.n...@gmail.com wrote: > From: Selva Nair > > Currently this raises a warning only. A fatal error is triggered > later with a confusing message that script failed to execute. > > This helps the Windows GUI to show a relevant error message when > script-security is

[Openvpn-devel] [PATCH] Exit early when external scripts are specified with script-security < 2

2019-02-11 Thread selva . nair
From: Selva Nair Currently this raises a warning only. A fatal error is triggered later with a confusing message that script failed to execute. This helps the Windows GUI to show a relevant error message when script-security is over-ridden as a security measure. Signed-off-by: Selva Nair ---