Hi,
On Tue, Nov 19, 2019 at 9:09 AM David Sommerseth <
open...@sf.lists.topphemmelig.net> wrote:
> On 14/11/2019 22:58, Selva Nair wrote:
> > Hi David
> >
> > Thanks for the comments
> >
> > My idea was just to add -Werror right in the line above, and not
> extend the
> >
Am 14.11.19 um 22:58 schrieb Selva Nair:
> Hi David
>
> Thanks for the comments
>
> My idea was just to add -Werror right in the line above, and not
> extend the
> ACL_CHECK_ADD_COMPILE_FLAGS macro with another argument.
>
>
> I'm fine with that approach as well. Let me know if you
Hi,
On Thu, Nov 14, 2019 at 3:16 PM Илья Шипицин wrote:
> Thank you for your efforts.
> As you are touching this, can you try "dist: bionic" ? It might bring
> newer compilers
>
I don't expect newer compilers on bionic break this patch. But fwiw, I've
started a travis build with dist: bionic.
Hi David
Thanks for the comments
My idea was just to add -Werror right in the line above, and not extend the
> ACL_CHECK_ADD_COMPILE_FLAGS macro with another argument.
>
I'm fine with that approach as well. Let me know if you want a v2.
> I think you said it pretty well in your mail:
>
> >
On 14/11/2019 20:40, selva.n...@gmail.com wrote:
> From: Selva Nair
>
> Some compilers (e.g., clang) only issue a warning for
> unsupported options unless additional flags such
> as -Werror are used to convert the warning to an error.
>
> Add support for extra flags in
Thank you for your efforts.
As you are touching this, can you try "dist: bionic" ? It might bring newer
compilers
On Thu, Nov 14, 2019, 8:41 PM wrote:
> From: Selva Nair
>
> Some compilers (e.g., clang) only issue a warning for
> unsupported options unless additional flags such
> as -Werror
From: Selva Nair
Some compilers (e.g., clang) only issue a warning for
unsupported options unless additional flags such
as -Werror are used to convert the warning to an error.
Add support for extra flags in ACL_CHECK_ADD_COMPILE_FLAGS.
Note: a similar approach is used in AX_CHECK_COMPILE_FLAG
