Re: [Openvpn-devel] [PATCH] Fix error detection / abort in --inetd corner case.

2020-09-08 Thread Arne Schwabe
Am 08.09.20 um 12:51 schrieb Gert Doering: > Calling "openvpn --inetd" from the CLI (= no socket on stdin) will > lead to endless looping in the accept(4) loop. > > Instead of cluttering that function further, detect failure to call > getsockame() in phase2_inetd() already, and trigger a M_FATAL

[Openvpn-devel] [PATCH] Fix error detection / abort in --inetd corner case.

2020-09-08 Thread Gert Doering
Calling "openvpn --inetd" from the CLI (= no socket on stdin) will lead to endless looping in the accept(4) loop. Instead of cluttering that function further, detect failure to call getsockame() in phase2_inetd() already, and trigger a M_FATAL abort on "errno == ENOTSOCK" ("The argument s is a