Re: [Openvpn-devel] [PATCH] Fix logic error in checking early negotiation support check

2022-11-16 Thread Antonio Quartulli
Hi, On 16/11/2022 01:54, Arne Schwabe wrote: Without the == it is enough if any of the bits EARLY_NEG_START is set (0xf0), we want them all to be set. If EARLY_NEG_START were a flag/single bit, you would be right. Ouch, I indeed assumed it was 1 bit only.. Cheers, -- Antonio Quartulli

Re: [Openvpn-devel] [PATCH] Fix logic error in checking early negotiation support check

2022-11-15 Thread Arne Schwabe
Am 15.11.2022 um 13:36 schrieb Antonio Quartulli: Hi, On 15/11/2022 13:29, Arne Schwabe wrote: We want to check if EARLY_NEG_START is set and reserve the other bits for future expansions. Right now we also check if all reserved bits are zero. oops. Signed-off-by: Arne Schwabe ---   src/openv

Re: [Openvpn-devel] [PATCH] Fix logic error in checking early negotiation support check

2022-11-15 Thread Antonio Quartulli
Hi, On 15/11/2022 13:29, Arne Schwabe wrote: We want to check if EARLY_NEG_START is set and reserve the other bits for future expansions. Right now we also check if all reserved bits are zero. oops. Signed-off-by: Arne Schwabe --- src/openvpn/mudp.c | 2 +- 1 file changed, 1 insertion(+), 1

[Openvpn-devel] [PATCH] Fix logic error in checking early negotiation support check

2022-11-15 Thread Arne Schwabe
We want to check if EARLY_NEG_START is set and reserve the other bits for future expansions. Right now we also check if all reserved bits are zero. oops. Signed-off-by: Arne Schwabe --- src/openvpn/mudp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/mudp.c b/sr