Re: [Openvpn-devel] [PATCH] Make sure options->ciphername and options->authname are always defined

2016-09-28 Thread Steffan Karger
On 28 September 2016 at 13:09, Gert Doering wrote: > Your patch has been applied to master. Due to differences in surrounding > code (which do not affect this change) I had to do it manually - code change > is the same, patch looks different. Please verify that it's all as it > should be :-) Th

Re: [Openvpn-devel] [PATCH] Make sure options->ciphername and options->authname are always defined

2016-09-28 Thread Gert Doering
Hi, On Wed, Sep 28, 2016 at 11:33:51AM +0200, Steffan Karger wrote: > The NCP code does a strcmp(options->ciphername, ...) without first checking > whether options->ciphername is NULL. This could cause a crash when using > "--cipher none". This patch fixes that problem by ensuring that > options

Re: [Openvpn-devel] [PATCH] Make sure options->ciphername and options->authname are always defined

2016-09-28 Thread Arne Schwabe
Am 28.09.16 um 11:33 schrieb Steffan Karger: > The NCP code does a strcmp(options->ciphername, ...) without first checking > whether options->ciphername is NULL. This could cause a crash when using > "--cipher none". This patch fixes that problem by ensuring that > options->ciphername (and optio

[Openvpn-devel] [PATCH] Make sure options->ciphername and options->authname are always defined

2016-09-28 Thread Steffan Karger
The NCP code does a strcmp(options->ciphername, ...) without first checking whether options->ciphername is NULL. This could cause a crash when using "--cipher none". This patch fixes that problem by ensuring that options->ciphername (and options->authname) are never NULL. Ensuring that options->