Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Gert Doering
Hi, On Thu, Nov 27, 2014 at 05:08:09PM +0200, Lev Stipakov wrote: > As for the second question - hard to say. If we make it opt-in, we > probably will need to announce this feature loudly to make users aware > of that. From the other side, it is not inconceivable to assume that > someone might

Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Lev Stipakov
Hello, Currently it should be safe, since multi_create_instance returns NULL if amount of clients >= max_clients. In this case we won't reach that "for" loop thanks to "if (mi)" check. But it probably won't harm to assert if we've reached "for" loop and could not find available "instance" item.

Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-27 Thread Gert Doering
Hi, On Sun, Nov 23, 2014 at 05:17:11PM +0200, Lev Stipakov wrote: > Changes in v7: > A few nitpicks. Went in, and has just been pushed. Time for your dance now :-) Question to you: > @@ -75,6 +101,16 @@ multi_get_create_instance_udp (struct multi_context *m) > { >

Re: [Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-23 Thread Steffan Karger
On 23-11-14 16:17, Lev Stipakov wrote: > Added new packet format P_DATA_V2, which includes peer-id. If server > supports, client sends all data packets in the new format. When data > packet arrives, server identifies peer by peer-id. If peer's ip/port has > changed, server assumes that client has

[Openvpn-devel] [PATCH] Peer-id patch v7

2014-11-23 Thread Lev Stipakov
Added new packet format P_DATA_V2, which includes peer-id. If server supports, client sends all data packets in the new format. When data packet arrives, server identifies peer by peer-id. If peer's ip/port has changed, server assumes that client has floated, verifies HMAC and updates ip/port in