Re: [Openvpn-devel] [PATCH] Print DCO client stats on SIGUSR2

2023-03-22 Thread Lev Stipakov
Hi, > While this is expedient, adding dco dependence to parts of code which should > be independent of such inner details look wrong style to me. Finding a way to > keep struct context a const here will lead to a better logic, I think. We have the same approach in multi_print_status(). Not

Re: [Openvpn-devel] [PATCH] Print DCO client stats on SIGUSR2

2023-03-22 Thread Gert Doering
Hi, On Wed, Mar 22, 2023 at 09:03:02AM -0400, Selva Nair wrote: > Can't we have a coarse timer that keeps the stats updated? It doesn't have > to be frequent as this is just for information. I can see why you do not like the current style - but doing this with timers is something I'm not really

Re: [Openvpn-devel] [PATCH] Print DCO client stats on SIGUSR2

2023-03-22 Thread Selva Nair
Hi, On Wed, Mar 22, 2023 at 7:34 AM Lev Stipakov wrote: > From: Lev Stipakov > > Change-Id: I465febdf7ee5fe573e88255844f718efb60f8e8a > Signed-off-by: Lev Stipakov > --- > src/openvpn/sig.c | 13 + > src/openvpn/sig.h | 2 +- > 2 files changed, 10 insertions(+), 5 deletions(-) >

[Openvpn-devel] [PATCH] Print DCO client stats on SIGUSR2

2023-03-22 Thread Lev Stipakov
From: Lev Stipakov Change-Id: I465febdf7ee5fe573e88255844f718efb60f8e8a Signed-off-by: Lev Stipakov --- src/openvpn/sig.c | 13 + src/openvpn/sig.h | 2 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/openvpn/sig.c b/src/openvpn/sig.c index