Re: [Openvpn-devel] [PATCH] Repair "tap server" mode brokenness caused by fallout

2012-07-02 Thread David Sommerseth
On 30/06/12 22:50, Gert Doering wrote: > Operator/Cast precedence wrong: casting mac[0] to (bool) first - giving > "1" for "any mac address that does not start with 00:" - and only then > bit-anding with "1" - thus always returning "true". Which, in turn, > leads to "reject all incoming packets wi

Re: [Openvpn-devel] [PATCH] Repair "tap server" mode brokenness caused by fallout

2012-07-01 Thread Fabian Knittel
Hi everyone, 2012/6/30 Gert Doering : > diff --git a/src/openvpn/mroute.c b/src/openvpn/mroute.c > index aecb702..850e336 100644 > --- a/src/openvpn/mroute.c > +++ b/src/openvpn/mroute.c > @@ -52,7 +52,7 @@ mroute_addr_init (struct mroute_addr *addr) >  static inline bool >  is_mac_mcast_addr (con

[Openvpn-devel] [PATCH] Repair "tap server" mode brokenness caused by fallout

2012-06-30 Thread Gert Doering
Operator/Cast precedence wrong: casting mac[0] to (bool) first - giving "1" for "any mac address that does not start with 00:" - and only then bit-anding with "1" - thus always returning "true". Which, in turn, leads to "reject all incoming packets with 'bad source address'". OpenVPN bug #216. S