Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-11 Thread Gert Doering
Hi, On Tue, Aug 10, 2021 at 08:16:44AM +0200, Max Fillinger wrote: > The function mbedtls_ctr_drbg_update is deprecated as of mbedtls 2.16 > and is superseded by mbedtls_ctr_drbg_update_ret, which returns an error > code. This commit replaces the call to the deprecated function with the > new one

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-11 Thread Antonio Quartulli
Hi, On 10/08/2021 08:16, Max Fillinger wrote: > The function mbedtls_ctr_drbg_update is deprecated as of mbedtls 2.16 > and is superseded by mbedtls_ctr_drbg_update_ret, which returns an error > code. This commit replaces the call to the deprecated function with the > new one and logs a warning

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Antonio Quartulli
On 10/08/2021 14:51, Maximilian Fillinger wrote: >> Normally we have patch v2 here and also a patch v2 in the subject (use >> -v 2 when doing git format-patch) but for this small patch it is not a >> problem. > > I'll keep it in mind for next time! > >> Apart from the fact that we might want to

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Maximilian Fillinger
> Normally we have patch v2 here and also a patch v2 in the subject (use > -v 2 when doing git format-patch) but for this small patch it is not a > problem. I'll keep it in mind for next time! > Apart from the fact that we might want to abort (M_FATAL) if this fails > instead basically ignoring

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 08:16 schrieb Max Fillinger: > The function mbedtls_ctr_drbg_update is deprecated as of mbedtls 2.16 > and is superseded by mbedtls_ctr_drbg_update_ret, which returns an error > code. This commit replaces the call to the deprecated function with the > new one and logs a warning in

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 12:17 schrieb Maximilian Fillinger: >> From: Arne Schwabe [mailto:a...@rfc2549.org] >> Sent: dinsdag 10 augustus 2021 12:12 >> To: Maximilian Fillinger ; openvpn- >> de...@lists.sourceforge.net >> Subject: Re: [Openvpn-devel] [PATCH] Replace dep

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Maximilian Fillinger
> From: Arne Schwabe [mailto:a...@rfc2549.org] > Sent: dinsdag 10 augustus 2021 12:12 > To: Maximilian Fillinger ; openvpn- > de...@lists.sourceforge.net > Subject: Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG > update function > > Am 10.08.21 um 08:

Re: [Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Arne Schwabe
Am 10.08.21 um 08:16 schrieb Max Fillinger: > +#if MBEDTLS_VERSION_NUMBER < 0x0210 Is that really 2.16? Looking at the API doc (https://tls.mbed.org/api/version_8h.html#adb4f54ebb33fd1a25e2c4d4480cf4936) it sounds like there should be a 16 in that number. Arne

[Openvpn-devel] [PATCH] Replace deprecated mbedtls DRBG update function

2021-08-10 Thread Max Fillinger
The function mbedtls_ctr_drbg_update is deprecated as of mbedtls 2.16 and is superseded by mbedtls_ctr_drbg_update_ret, which returns an error code. This commit replaces the call to the deprecated function with the new one and logs a warning in case of an error. For older versions of mbedtls, we