Re: [Openvpn-devel] [PATCH] Swap the order of checks for validating interactive service user

2020-01-31 Thread Selva Nair
Hi, On Fri, Jan 31, 2020 at 5:29 AM Lev Stipakov wrote: > > Hi, > >> +if (!ValidateOptions(pipe, sud.directory, sud.options) >> +&& !IsAuthorizedUser(ovpn_user->User.Sid, imp_token, >> settings.ovpn_admin_group) >> { > > > Closing parenthesis is missing: That is embarrassing..

Re: [Openvpn-devel] [PATCH] Swap the order of checks for validating interactive service user

2020-01-31 Thread Lev Stipakov
Hi, +if (!ValidateOptions(pipe, sud.directory, sud.options) > +&& !IsAuthorizedUser(ovpn_user->User.Sid, imp_token, > settings.ovpn_admin_group) > { > Closing parenthesis is missing: >C:\Users\lev\Projects\openvpn\src\openvpnserv\interactive.c(1586,5): error C2143: syntax

[Openvpn-devel] [PATCH] Swap the order of checks for validating interactive service user

2020-01-30 Thread selva . nair
From: Selva Nair Check the config file location and command line options first and membership in OpenVPNAdministrators group after that as the latter could be a slow process for active directory users. When connection to domain controllers is poor or unavailable, checking the group membership