Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Selva Nair
> > How about we apply my original patch (0 for /28 and -1 for the rest) > to 2.5 and this one to master? I do not see the logic behind that. If there are any platforms where 0 (network address) is not acceptable, it's unlikely to work for /30 as well. /31 is special, /30 is not. And, based on

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Gert Doering
Hi, On Fri, Nov 12, 2021 at 02:33:31PM +0200, Lev Stipakov wrote: > How about we apply my original patch (0 for /28 and -1 for the rest) > to 2.5 and this one to master? I tend to go for "make it simple and consistent", which would make this "0 everywhere, if it breaks, the option is still

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-12 Thread Lev Stipakov
Hi, I tested yesterday on Windows 10 and today also on Windows 7 and 8.1. - /30 subnet (OpenVPN Cloud as server) - /24 subnet (openvpn2) with redirect-gateway def1. Tested that ping works and traffic goes through the tunnel. Also our QA tested this (not exactly this one, but my original patch

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-11 Thread Selva Nair
Hi On Thu, Nov 11, 2021 at 4:41 AM Lev Stipakov wrote: > From: Lev Stipakov > > This is the rebase of original Selva Nair's patch > which hasn't been merged: > > https://sourceforge.net/p/openvpn/mailman/message/34674818/ Yes, something I wanted 5 years ago > > and documentation change

Re: [Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-11 Thread Gert Doering
Hi, On Tue, Nov 09, 2021 at 03:59:27AM +0200, Lev Stipakov wrote: > For subnet topology use "offset 0" as default for > calculating DHCP server address, which makes it equal > to the network address. I assume this has been tested across all windows platforms, including Windows 7? On the patch

[Openvpn-devel] [PATCH] Use network address for emulated DHCP server as a default

2021-11-11 Thread Lev Stipakov
From: Lev Stipakov This is the rebase of original Selva Nair's patch which hasn't been merged: https://sourceforge.net/p/openvpn/mailman/message/34674818/ and documentation change to reflect code changes, which is basically a revert of another Selva's patch (which got merged):