Re: [Openvpn-devel] [PATCH] cleanup: gc usage

2012-04-02 Thread David Sommerseth
On 01/04/12 15:46, Alon Bar-Lev wrote: > Cleanup of "Use the garbage collector when retrieving x509 fields" > patch series. > > Discussed at [1]. > > There should be an effort to produce common function prologue > and epilogue, so that cleanups will be done at single point. > > [1]

Re: [Openvpn-devel] [PATCH] cleanup: gc usage

2012-04-02 Thread Alon Bar-Lev
On Mon, Apr 2, 2012 at 10:06 AM, Adriaan de Jong wrote: > Thanks, looks good. Does platform_open return -1 on failure on all > platforms? If so, ack, otherwise change that to < 0. As far as I know, yes. """open() and creat() return the new file descriptor, or -1 if an error

Re: [Openvpn-devel] [PATCH] cleanup: gc usage

2012-04-02 Thread Adriaan de Jong
On 04/01/2012 03:46 PM, Alon Bar-Lev wrote: > Cleanup of "Use the garbage collector when retrieving x509 fields" > patch series. > > Discussed at [1]. > > There should be an effort to produce common function prologue > and epilogue, so that cleanups will be done at single point. > > [1]

[Openvpn-devel] [PATCH] cleanup: gc usage

2012-04-01 Thread Alon Bar-Lev
Cleanup of "Use the garbage collector when retrieving x509 fields" patch series. Discussed at [1]. There should be an effort to produce common function prologue and epilogue, so that cleanups will be done at single point. [1] http://comments.gmane.org/gmane.network.openvpn.devel/5401