Re: [Openvpn-devel] [PATCH] is_ipv_X: improve packet consistency checks

2022-09-18 Thread Antonio Quartulli
Hi, On 18/09/2022 22:31, Gert Doering wrote: Hi, On Sun, Sep 18, 2022 at 09:47:56PM +0200, Antonio Quartulli wrote: In the worst case I will only address the second point of the list above (as we may later access an IPv6 header that is not fully allocated). I think everything that actually l

Re: [Openvpn-devel] [PATCH] is_ipv_X: improve packet consistency checks

2022-09-18 Thread Gert Doering
Hi, On Sun, Sep 18, 2022 at 09:47:56PM +0200, Antonio Quartulli wrote: > In the worst case I will only address the second point of the list above > (as we may later access an IPv6 header that is not fully allocated). I think everything that actually looks further down the header *does* check if

Re: [Openvpn-devel] [PATCH] is_ipv_X: improve packet consistency checks

2022-09-18 Thread Antonio Quartulli
Hi, On 18/09/2022 12:12, Gert Doering wrote: Hi, On Sat, Sep 17, 2022 at 11:31:54PM +0200, Antonio Quartulli wrote: This patch brings the following improvements: * check that ETH proto and version in IP header are consistent; * check that length of the packet is enough to store the expected IP

Re: [Openvpn-devel] [PATCH] is_ipv_X: improve packet consistency checks

2022-09-18 Thread Gert Doering
Hi, On Sat, Sep 17, 2022 at 11:31:54PM +0200, Antonio Quartulli wrote: > This patch brings the following improvements: > * check that ETH proto and version in IP header are consistent; > * check that length of the packet is enough to store the expected IP > header (it may be an IPv4 or an IPv6 h

[Openvpn-devel] [PATCH] is_ipv_X: improve packet consistency checks

2022-09-17 Thread Antonio Quartulli
This patch brings the following improvements: * check that ETH proto and version in IP header are consistent; * check that length of the packet is enough to store the expected IP header (it may be an IPv4 or an IPv6 header) * restyle a bit to improve readability; * remove spaces before ')' in inv